Complete functional options pattern refactoring for special pluginclaude/refactor-plugins-functional-options

Agent-Logs-Url: https://github.com/Loyalsoldier/geoip/sessions/0483b641-15da-4630-a3ad-53f8d1c65fe9

Co-authored-by: Loyalsoldier <[email protected]>

1 files changed, 41 insertions, 15 deletions

diff --git a/plugin/special/lookup.go b/plugin/special/lookup.go
index 96735146..25dd2521 100644
--- a/plugin/special/lookup.go
+++ b/plugin/special/lookup.go
@@ -18,14 +18,42 @@ const (
 
 func init() {
 	lib.RegisterOutputConfigCreator(TypeLookup, func(action lib.Action, data json.RawMessage) (lib.OutputConverter, error) {
-		return newLookup(action, data)
+		return NewLookupFromBytes(action, data)
 	})
-	lib.RegisterOutputConverter(TypeLookup, &Lookup{
+	lib.RegisterOutputConverter(TypeLookup, &lookup{
 		Description: DescLookup,
 	})
 }
 
-func newLookup(action lib.Action, data json.RawMessage) (lib.OutputConverter, error) {
+func NewLookup(action lib.Action, opts ...lib.OutputOption) lib.OutputConverter {
+	l := &lookup{
+		Type:        TypeLookup,
+		Action:      action,
+		Description: DescLookup,
+	}
+
+	for _, opt := range opts {
+		if opt != nil {
+			opt(l)
+		}
+	}
+
+	return l
+}
+
+func WithLookupSearch(search string) lib.OutputOption {
+	return func(l lib.OutputConverter) {
+		l.(*lookup).Search = strings.TrimSpace(search)
+	}
+}
+
+func WithLookupSearchList(searchList []string) lib.OutputOption {
+	return func(l lib.OutputConverter) {
+		l.(*lookup).SearchList = searchList
+	}
+}
+
+func NewLookupFromBytes(action lib.Action, data []byte) (lib.OutputConverter, error) {
 	var tmp struct {
 		Search     string   `json:"search"`
 		SearchList []string `json:"searchList"`
@@ -42,16 +70,14 @@ func newLookup(action lib.Action, data json.RawMessage) (lib.OutputConverter, er
 		return nil, fmt.Errorf("❌ [type %s | action %s] please specify an IP or a CIDR as search target", TypeLookup, action)
 	}
 
-	return &Lookup{
-		Type:        TypeLookup,
-		Action:      action,
-		Description: DescLookup,
-		Search:      tmp.Search,
-		SearchList:  tmp.SearchList,
-	}, nil
+	return NewLookup(
+		action,
+		WithLookupSearch(tmp.Search),
+		WithLookupSearchList(tmp.SearchList),
+	), nil
 }
 
-type Lookup struct {
+type lookup struct {
 	Type        string
 	Action      lib.Action
 	Description string
@@ -59,19 +85,19 @@ type Lookup struct {
 	SearchList  []string
 }
 
-func (l *Lookup) GetType() string {
+func (l *lookup) GetType() string {
 	return l.Type
 }
 
-func (l *Lookup) GetAction() lib.Action {
+func (l *lookup) GetAction() lib.Action {
 	return l.Action
 }
 
-func (l *Lookup) GetDescription() string {
+func (l *lookup) GetDescription() string {
 	return l.Description
 }
 
-func (l *Lookup) Output(container lib.Container) error {
+func (l *lookup) Output(container lib.Container) error {
 	switch strings.Contains(l.Search, "/") {
 	case true: // CIDR
 		if _, err := netip.ParsePrefix(l.Search); err != nil {