opensbi.git/Makefile, branch v1.3

Makefile: Dereference symlinks on install

2023-05-22T03:22:57Z

Adds the `-L` flag (follow symlinks) to the `cp` commands used to install `libsbi.a` and `include/sbi/*`. This should make no difference in regular compilation. However, it does make a difference when compiling with bazel. Namely, bazel's sandboxing will turn all the source files into symlinks. After installation with `cp` the destination files will be symlinks pointing to the sandbox symlinks. As the sandbox files are removed when compilation ends, the just-copied symlinks become dangling symlinks. The resulting include files will be unusable due to the dangling symlink issues. Adding `-L` when copying ensures that the files obtained by executing the `install` targets are always dereferenced to files, rather than symlinks, eliminating this issue. Signed-off-by: Filip Filmar Reviewed-by: Xiang W Reviewed-by: Anup Patel

make: Add a command line option for debugging OpenSBI

2023-03-01T03:53:17Z

Add a new make command line option "make DEBUG=1" to prevent compiler optimizations using -O2. Signed-off-by: Bin Meng Reviewed-by: Xiang W Reviewed-by: Anup Patel

Makefile: Add missing .dep files for fw_*.elf.ld

2023-02-08T11:06:55Z

Since we don't currently create these, changes to fw_base.ldS do not cause the preprocessed fw_*.elf.ld files to be rebuilt, and thus incremental builds can end up failing with missing symbols if crossing the recent commits that introduced _fw_rw_offset and then replaced it with _fw_rw_start. Reported-by: Ben Dooks Signed-off-by: Jessica Clarke Reviewed-by: Anup Patel

Makefile: Remove -N ldflag to prevent linker RWX warning

2023-01-06T12:21:15Z

-N option coalesce all sections into single LOAD segment which causes data and other sections to have executable permission causing warning with new binutils ld 2.39. New ld emits warning when any segment have all three permissions RWX. ld.bfd: warning: test.elf has a LOAD segment with RWX permissions ld.bfd: warning: fw_dynamic.elf has a LOAD segment with RWX permissions ld.bfd: warning: fw_jump.elf has a LOAD segment with RWX permissions ld.bfd: warning: fw_payload.elf has a LOAD segment with RWX permissions This option was added in below commit - commit: eeab92f2423e ("Makefile: Convert to a more standard format") Removing -N option allows to have text and rodata into one LOAD segment and other sections into separate LOAD segment which prevents RWX permissions on single LOAD segment. Here X == E Current LOAD 0x0000000000000120 0x0000000080000000 0x0000000080000000 0x000000000001d4d0 0x0000000000032ed8 RWE 0x10 -N removed LOAD 0x0000000000001000 0x0000000080000000 0x0000000080000000 0x00000000000198cc 0x00000000000198cc R E 0x1000 LOAD 0x000000000001b000 0x000000008001a000 0x000000008001a000 0x00000000000034d0 0x0000000000018ed8 RW 0x1000 Signed-off-by: Rahul Pathak Reviewed-by: Anup Patel Tested-by: Samuel Holland

Makefile: bugfix for handling platform paths

2022-12-04T15:32:33Z

If the path where this repo is located contains the platform name on it, the original Makefile replaced its occurrences from the path making it an invalid path. This commit prevents this behavior replacing only the last part of the path as intended. Signed-off-by: Alejandro Cabrera Aldaya Reviewed-by: Xiang W Reviewed-by: Andrew Jones Reviewed-by: Anup Patel

Makefile: replace `echo` with `printf` for compatibility

2022-12-04T15:11:30Z

I don't know why but `echo -n` didn't work for me. macOS supports the `-n` option but it doesn't work in the makefile. What it does instead is it literally writes `-n` to the file and then also leaves a newline at the end. I'm using GNU Make 4.4 (`gmake` from Homebrew). Signed-off-by: KaDiWa Reviewed-by: Andrew Jones Reviewed-by: Anup Patel

Makefile: Add rules for carray sources in lib/sbi

2022-10-23T05:29:26Z

Add back the missing rules needed to build carray files in lib/sbi. This allows future usage of carray in lib/sbi. Fixes: de80e9337d81 ("Makefile: Compile lib/utils sources separately for each platform") Signed-off-by: Vivian Wang Reviewed-by: Andrew Jones Reviewed-by: Anup Patel

Makefile: Add cscope support

2022-10-23T05:17:40Z

Add cscope support so that running `make cscope` will generate/update cscope files used for source code browsing, while running `make distclean` will remove the cscope files. Also add entry in .gitignore to ignore generated cscope files. Signed-off-by: Tan En De Reviewed-by: Xiang W Reviewed-by: Anup Patel Reviewed-by: Andrew Jones

Makefile: Fix typo related to object.mk

2022-08-08T04:04:43Z

The "object.mk" name referred in top-level makefile should be "objects.mk". Signed-off-by: Anup Patel Reviewed-by: Andrew Jones Tested-by: Andrew Jones Acked-by: Atish Patra Tested-by: Atish Patra

platform: Remove redundant config.mk from all platforms

2022-08-08T04:04:25Z

The options defined in config.mk can be specified in objects.mk of each platform so let us remove config.mk from all platforms. Signed-off-by: Anup Patel Tested-by: Andrew Jones Acked-by: Atish Patra Tested-by: Atish Patra