opensbi.git/firmware/fw_base.S, branch v1.4

firmware: fw_base.S: Fix boot hart status synchronization

2023-11-16T10:49:42Z

It's wrong to put the fence after setting the boot status flag because all relocation operations must be finished before setting the status flag. So, this fence must be put before the setting status flag, and there is no use in putting a fence between _start_warm and setting status flag. Also, nop can't delay other harts too much, so use div instead, just like Linux cpu_relax. Current opensbi force enables “M” Standard Extension, and mul instructions have been used in the fw_base.S. After the above two fixes, the boot hart index param of the fw_dynamic_info could be guaranteed properly for all platforms. Signed-off-by: Guo Ren Signed-off-by: Guo Ren Reviewed-by: Anup Patel

firmware: Remove handling of R_RISCV_{32,64}

2023-10-06T03:51:23Z

Since everything is statically linked, we won't actually have R_RISCV_{32,64} relocations. No need to handle these. Fixes: 0f20e8adcf42 ("firmware: Support position independent execution") Signed-off-by: Vivian Wang Reviewed-by: Anup Patel

fw_base.S: Fix assembler error with clang 16+

2023-08-06T05:36:02Z

Attempting to build OpenSBI with clang 16 and the following command: $ make LLVM=1 PLATFORM=generic Results in the following error: AS platform/generic/firmware/fw_dynamic.o /tmp/fw_dynamic-d000a6.s:429:9: error: symbol '_fw_start' can not be undefined in a subtraction expression .dword _fw_rw_start - _fw_start Work around this issue by eliminating the __fw_rw_offset variable and performing the offset calculation at run-time instead. This takes advantage of the fact that the a4 register contains the value of _fw_start. Signed-off-by: Mitchell Horne Reviewed-by: Anup Patel

firmware: Fix find hart index

2023-06-21T04:50:51Z

After the loop to find the hartid is launched, assigning -1 to index will fail in the subsequent compare instruction bge. Fix This. Signed-off-by: Xiang W Reviewed-by: Anup Patel

platform: Allow platforms to specify heap size

2023-06-05T10:15:33Z

We extend struct sbi_platform and struct sbi_scratch to allow platforms specify the heap size to the OpenSBI firmwares. The OpenSBI firmwares will use this information to determine the location of heap and provide heap base address in per-HART scratch space. Signed-off-by: Anup Patel Reviewed-by: Andrew Jones

firmware: Change to use positive offset to access relocation entries

2023-04-17T03:25:55Z

The codes currently skip the very first relocation entry, but later reference the elements in the relocation entry using minus offsets. Change to use positive offsets so that there is no need to skip the first relocation entry. Signed-off-by: Bin Meng Reviewed-by: Anup Patel Reviewed-by: Xiang W

firmware: Optimize loading relocation type

2023-04-17T03:25:49Z

't5' already contains relocation type so don't bother reloading it. Signed-off-by: Bin Meng Reviewed-by: Anup Patel Reviewed-by: Xiang W

lib: sbi_hart: clear mip csr during hart init

2023-04-06T13:22:03Z

If mip.SEIP bit is not cleared then on HiFive Unmatched board it causes spurious external interrupts. This breaks the boot up of HiFive Unmatched board. Hence it is required to bring the mip CSR to a known state during hart init and avoid spurious interrupts. Fixes: d9e7368 ("firmware: Not to clear all the MIP") Signed-off-by: Mayuresh Chitale Reviewed-by: Anup Patel

firmware: Not to clear all the MIP

2023-02-08T05:09:20Z

In generic behavior of QEMU, if the pending bits of PLIC are still set and we clear the SEIP, the QEMU may not set the SEIP back immediately and the interrupt may not be handled anymore until the new interrupts arrived and QEMU set the SEIP back which is a generic behavior in QEMU. Signed-off-by: Nick Hu Signed-off-by: Jim Shu Reviewed-by: Anup Patel

firmware: Fix fw_rw_offset computation in fw_base.S

2023-01-27T03:09:49Z

It seems BFD just does totally nonsensical things for SHN_ABS symbols when producing position-independent outputs (both -pie and -shared) for various historical reasons, and so SHN_ABS symbols are still subject to relocation as far as BFD is concerned (except AArch64, which fixes it in limited cases that don’t apply here...). The above affects the _fw_rw_offset provided through fw_base.ldS linker script which results in OpenSBI firmware failing to boot when loaded at an address different from FW_TEXT_START. Fixes: c10e3fe5f9a1 ("firmware: Add RW section offset in scratch") Signed-off-by: Jessica Clarke Reported-by: Lad Prabhakar Tested-by: Lad Prabhakar Tested-by: Anup Patel Signed-off-by: Anup Patel