opensbi.git/firmware, branch v1.1

firmware: Fix code for accessing hart_count and stack_size

2022-03-27T03:23:27Z

lwu exists under the current rv64 and should also exist under the rv128 in the future, so I modified the conditions of conditional compilation so that it can adapt to the future situation Signed-off-by: Xiang W Reviewed-by: Anup Patel

firmware: Move memcpy/memset mapping to fw_base.S

2021-12-23T12:16:09Z

Some of the external firmwares using OpenSBI as library are facing issues with the weak memcpy() and memset() aliases in libsbi.a so we move these to fw_base.S. This way mapping of implicit memcpy() or memset() calls to sbi_memcpy() or sbi_memset() will only be done for OpenSBI firmwares. (Refer, https://github.com/riscv-software-src/opensbi/issues/234) In addition, we also add memmove() and memcmp() mappings in fw_base.S because as-per the GCC documentation the freestanding environment must provide memcpy(), memmove(), memset(), and memcmp(). Signed-off-by: Anup Patel Reviewed-by: Atish Patra

payloads/test: Add support for SBI v0.2 ecalls

2021-08-20T04:18:45Z

It can be useful to make SBI v0.2 or newer ecalls from this payload for testing purposes. To support this, convert the macros to use the extension/function parameter convention. Signed-off-by: Samuel Holland Reviewed-by: Atish Patra

firmware: use _fw_start for load address

2021-07-27T09:50:49Z

The previous code uses _start as the load address, this default .entry is the first segment, using _fw_start does not need to make this assumption. Signed-off-by: Xiang W Reviewed-by: Anup Patel

firmware: Remove the unhelpful alignment codes before fdt relocation

2021-07-17T11:43:43Z

If the device tree is at an address that is not __SIZEOF_POINTER__ aligned, the fdt relocation code tries to align both source and destination address to __SIZEOF_POINTER__ before the memory copy. But such alignment can lead to unexpected results if either source or destination address is not aligned. In fact libfdt requires that the device tree must be at an 8-byte aligned address. Hence remove the unhelpful alignment codes. Signed-off-by: Bin Meng Reviewed-by: Anup Patel

firmware: Only default FW_PIC to y if supported

2021-07-11T14:33:06Z

Bare-metal GNU ld does not support PIE, so if using it this will result in a failure to build. Instead, default to FW_PIC=n if not supported. Note that an explicit FW_PIC=y is not overridden, to ensure the build fails rather than silently producing a position-dependent binary. Signed-off-by: Jessica Clarke Reviewed-by: Bin Meng Tested-by: Bin Meng Reviewed-by: Anup Patel

firmware: Explicitly pass -pie to the linker, not just the driver

2021-07-11T14:31:56Z

When using Clang with a bare-metal triple, -pie does not get passed to the linker as it's not normally a thing that makes sense, unlike GCC which will unconditionally forward it on and potentially result in a linker error. However, LLD does support it, and manually forwarding it on works as desired, so do so to fully support FW_PIC with Clang and LLD. Signed-off-by: Jessica Clarke Reviewed-by: Bin Meng Tested-by: Bin Meng Reviewed-by: Anup Patel

fw_base: Put data in .data rather than .text

2021-07-11T12:03:30Z

The -N linker option is supposed to make .text writable, but GNU ld and LLD differ in interpreting what that means. GNU ld will happily let you have relocations in it, but LLD will see that the input section is read-only (even though the output section is writable) and give an error. It's unclear if either of them intend to have that behaviour in this edge case, but regardless there's no reason not to just put the data in a writable .data section. Signed-off-by: Jessica Clarke Reviewed-by: Bin Meng Tested-by: Bin Meng Reviewed-by: Anup Patel

fw_base: Don't mark fw_platform_init as both global and weak

2021-07-11T11:50:42Z

These are mutually exclusive. GNU as and LLVM both let later binding directives override earlier ones so this works as intended, but LLVM 12 turned this into a warning as there's no good reason to do such a thing and could be a potential bug. Thus, remove the redundant and incorrect .globl directive for fw_platform_init. Signed-off-by: Jessica Clarke Reviewed-by: Bin Meng Tested-by: Bin Meng Reviewed-by: Anup Patel

firmware: Define a macro for version of struct fw_dynamic_info

2021-07-11T08:43:32Z

Avoid using a magic number, instead use a macro for the version of struct fw_dynamic_info. Signed-off-by: Bin Meng Reviewed-by: Xiang W Reviewed-by: Anup Patel