opensbi.git/lib/sbi/sbi_console.c, branch master

lib: sbi: Introduce an early console buffer for caching early prints

2024-07-24T06:48:41Z

The console device is registered by platform only in early_init() callback so any prints before this point will be lost. Introduce an early console buffer for caching prints before platform early_init(). For crashes before platform early_init(), users can simply dump the contents of the console_early_buffer[] string using a debugger. The relative address of the console_early_buffer[] string can be found using following two commands: CONSOLE_EARLY_FIFO_ADDR=`${CROSS_COMPILE}objdump -D \ build/platform/generic/firmware/fw_dynamic.elf | \ grep ":" | awk '{print $1}'` ${CROSS_COMPILE}objdump -R build/platform/generic/firmware/fw_dynamic.elf | \ grep $CONSOLE_EARLY_FIFO_ADDR | awk '{print $3}' Signed-off-by: Anup Patel Reviewed-By: Himanshu Chauhan

lib: sbi: Remove sbi_console_init() and console_init() platform callback

2024-07-24T06:48:33Z

Now that all platforms have been updated to initialize serial console device in early_init(), the sbi_console_init() and console_init() platform callback are redundant hence remove them. Signed-off-by: Anup Patel Reviewed-By: Himanshu Chauhan

lib: tests: Move tests to a separate directory

2024-03-19T05:50:40Z

Move all of the SBIUnit-related code into the lib/sbi/tests directory. Update 'Makefile' to index objects from the tests subdirectory. I don't think creating the full separate list of Makefile variables (libsbitests-objs-path-y, libsbitests-object-mks, etc. as it is done for libsbiutils) is necessary for the tests because: 1) `lib/sbi/tests/objects.mk` is already indexed into 'libsbi-objects-mks' since the find expression for the libsbi-object-mks variable looks for objects.mk files in the nested directories as well). 2) Tests are tightly coupled with the `lib/sbi/` sources, therefore it may be reasonable to store the list of lib/sbi and lib/sbi/tests object files together in the libsbi-objs-path-y variable. Additionally, update relative paths in the tests where necessary. Signed-off-by: Ivan Orlov Reviewed-by: Anup Patel

lib: tests: Add sbi_console test

2024-03-10T04:42:52Z

Add the test suite covering some of the functions from lib/sbi/sbi_console.c: putc, puts and printf. The test covers a variety of format specifiers for printf and different strings and characters for putc and puts. In order to do that, the test "mocks" the sbi_console_device structure by setting the 'console_dev' variable to the virtual console. Signed-off-by: Ivan Orlov Reviewed-by: Andrew Jones

lib: sbi: Make console_puts/console_putc interchangeable

2023-11-17T10:33:21Z

console_puts/console_putc should replace each other, but the previous sbi_putc can only use console_putc. This patch addresses this problem. Signed-off-by: Xiang W Reviewed-by: Guo Ren Reviewed-by: Anup Patel

lib: sbi: Fix missing '\0' when buffer szie equal 1

2023-07-12T05:07:43Z

Fix special case: sbi_snprintf(out, out_len, ...) when out_len equal 1, The previous code will not fill the buffer with any char. Signed-off-by: Xiang W Reviewed-by: Anup Patel

lib: sbi: Fix timing of clearing tbuf

2023-07-12T05:07:16Z

A single scan of the format char may add multiple characters to the tbuf, causing a buffer overflow. You should check if tbuf is full in printc so that it does not cause a buffer overflow. Signed-off-by: Xiang W Reviewed-by: Anup Patel

lib: sbi: Fix printc

2023-07-12T04:32:27Z

Because *out needs to reserve a byte to hold '\0', no more characters should be added to the buffer when *out has one byte left, and the buffer size *out_len should not be modified. this patch prevents the correction of *out_len when *out_len is 1. Signed-off-by: Xiang W Reviewed-by: Anup Patel

lib: sbi: Simplify prints

2023-07-12T04:32:06Z

When doing width = width - strlen(string) in prints there is no need to consider the case that witdh may be less than 0. This is because the code to do filling needs to be executed under the condition that width > 0. Signed-off-by: Xiang W Reviewed-by: Anup Patel

lib: sbi: Fix printi

2023-07-12T04:31:43Z

Fix two bug: > printf("%#08x", 0x123); /* print 0000x123 */ > printf("%#x", 0); /* print 0x0 */ Signed-off-by: Xiang W Reviewed-by: Anup Patel