opensbi.git/lib/sbi, branch v0.8

lib: Don't return any invalid error from SBI ecall

2020-06-20T05:06:13Z

We should only return valid error codes from SBI ecalls as defined by the RISC-V SBI spec. To achieve this: 1. We use SBI_Exxxx defines for OpenSBI internal errors with error values starting from -1000 2. We use SBI_ERR_xxxx defines for errors defined by SBI spec 3. We map some of the SBI_Exxxx defines to SBI_ERR_xxxx defines which are semantically same 4. We throw a error print and force return error code to SBI_ERR_FAILED in sbi_ecall_handler() if we see an invalid error code being returned to S-mode Signed-off-by: Anup Patel Reviewed-by: Atish Patra

lib: sbi: Fix 32/64 bits variable compatibility

2020-06-20T03:17:11Z

On RV64,"unsigned long" is 64bit and "unsigned int" is 32bit. So in function "pmp_get" and "pmp_set", if "pmpcfg_shift >= 32", "0xff << pmpcfg_shift" will go beyond "unsigned int" width. This patch tries to fix this issue. In function 'pmp_get': cfgmask = (0xff << pmpcfg_shift); --> cfgmask = (0xffUL << pmpcfg_shift); In function 'pmp_set': cfgmask = ~(0xff << pmpcfg_shift); --> cfgmask = ~(0xffUL << pmpcfg_shift); Signed-off-by: Liush Reviewed-by: Anup Patel

lib: Fix the SBI_HART_HAS_MCOUNTEREN feature check

2020-06-18T03:28:13Z

Signed-off-by: Alistair Francis Reviewed-by: Atish Patra Reviewed-by: Anup Patel

lib: Don't print delegation CSRs if there is no S-Mode

2020-06-18T03:26:54Z

If the platform doesn't support S-Mode don't print the delegation registers. Signed-off-by: Alistair Francis Reviewed-by: Atish Patra Reviewed-by: Anup Patel

lib: Fix __sbi_hfence_gvma_vmid_gpa() and __sbi_hfence_vvma_asid_va()

2020-06-15T03:54:27Z

The arguments/parameters of __sbi_hfence_gvma_vmid_gpa() and __sbi_hfence_vvma_asid_va() functions are swapped so we fix it. Currently, we did not face any issues because QEMU does a full TLB flush for all HFENCE instructions. We also improve documentation of HFENCE.GVMA and HFENCE.VVMA instruction encoding. Signed-off-by: Anup Patel Reviewed-by: Atish Patra

lib: Add RISC-V hypervisor v0.6.1 support

2020-06-08T10:11:23Z

To support RISC-V hypervisor v0.6.1, we: 1. Don't need to explicitly forward WFI traps from VS/VU-mode 2. Have to delegate virtual instruction trap to HS-mode 3. Have to update trap redirection for changes in HSTATUS CSR Signed-off-by: Anup Patel Reviewed-by: Atish Patra

lib: sbi_hart: Detect number of supported PMP regions

2020-05-19T03:49:48Z

It is not mandatory for a RISC-V systems to implement all PMP regions so we have to check all PMPADDRx CSRs to determine excat number of supported PMP regions. Signed-off-by: Anup Patel

lib: sbi: Few cosmetic improvements to HART feature detection

2020-05-19T03:49:44Z

This patch does few cosmetic improvements to HART feature detection: 1. Remove sbi_ perfix from HART feature detection functions because all local/static functions in sbi_hart.c don't have sbi_ prefix 2. Remove sbi_hart_set_feature() because it's quite small and local/static in sbi_hart.c Signed-off-by: Anup Patel Reviewed-by: Atish Patra

include: sbi: Use scratch pointer as parmeter in HART feature APIs

2020-05-19T03:49:42Z

It makes more sense to have scratch pointer as parameter in HART feature APIs because: 1. We already have scratch pointer at places where these APIs are used. 2. This is consistent with lot of other APIs in sbi_hart.h Signed-off-by: Anup Patel Reviewed-by: Atish Patra

lib: sbi: Print platform HART count just before boot HART id

2020-05-19T03:49:39Z

On platforms with continuous HART ids starting from zero: 0 <= boot HART id < platform HART count The above co-relation of boot HART id and platform HART count is true for most RISC-V platfors so it's better to print platform HART count just before boot HART id. Signed-off-by: Anup Patel Reviewed-by: Atish Patra