opensbi.git/lib/utils/fdt/fdt_domain.c, branch v1.8

lib: utils:Check that hartid is valid

2025-02-12T03:54:09Z

It is possible that hartid may not be sequential and it should not be validated against SBI_HARTMASK_MAX_BITS. Instead we should check the index of the hartid, hart index, against SBI_HARTMASK_MAX_BITS. Signed-off-by: Raj Vishwanathan Reviewed-by: Anup Patel

lib: utils: Make the enforce permission bit configurable from DT

2025-02-11T12:26:48Z

The domain_support.md documentation states that the enforce permission bit (BIT[6]) could be set in the "regions" property of a domain instance DT node. However, this bit is masked in the current implementation. This patch unmasks the bit to make it configurable from DT. Signed-off-by: Chao Du Reviewed-by: Xiang W Reviewed-by: Anup Patel

lib: utils/fdt: Use sbi_domain_memregion_init() when parsing domains

2024-10-25T17:30:02Z

Use sbi_domain_memregion_init() at the time of parsing domains from FDT so that sbi_domain_memregion_init() is always used for setting up all memregions. Signed-off-by: Anup Patel Reviewed-by: Samuel Holland

lib: utils: fdt_domain: Make opensbi-domain optional in CPU node

2024-08-24T08:38:00Z

The domain_support.md documentation states that "the HART to domain instance assignment can be parsed from the device tree using *optional* DT property opensbi-domain in each CPU DT node". However, the current implementation does not treat this parameter as optional when determining which HARTs to assign to a freshly discovered domain from the device tree, causing an effect where every HART in the system must be explicitly assigned to a domain only if a domain is specified in the device tree. Instead, this patch simply ignores CPUs that do not specify a domain, and does not attempt to assign them into the recently discovered domain. Signed-off-by: Gregor Haas Reviewed-by: Anup Patel

lib: utils/fdt: Constify FDT parsing functions

2024-08-24T07:32:25Z

Distinguish between functions which modify the devicetree and those which only extract information from it. Other than the iterators in fdt_domain.c, this is a mechanical conversion. Signed-off-by: Samuel Holland Reviewed-by: Andrew Jones Reviewed-by: Anup Patel

lib: utils: fdt_domain: Use consistent device-tree address when next-arg1 is missing

2024-08-23T08:47:29Z

The diagram shown below illustrates the boot-flow involving OP-TEE OS initialization. (1)-----------+ | U-Boot SPL | +------------+ | v (2)-------------------------------------------------------------+ | OpenSBI (fw_dynamic) | | (4)------------------------+ | | | optee dispatcher driver | | +-----------------+-------^---------|-------+------------------+ M-mode | | | ---------+--[trusted domain]---+----.----+--[untrusted domain]------- S-mode | (coldboot domain) | | | v | | v (3)---------------------------+ |(5)----------------------------+ | OP-TEE OS | | | U-Boot | +----------------------------+ | +-----------------------------+ | | | v |(6)----------------------------+ | | Linux | | +-----------------------------+ As OP-TEE OS has device-tree node fixups that need to be passed through to the next boot stages, e.g. the reserved memory node: reserved-memory { #address-cells = <2>; #size-cells = <2>; ranges; optee_core@f1000000 { no-map; reg = <0x0 0xf1000000 // OP-TEE OS base address 0x0 0x01000000>; }; <...> }; Instead of using 0x0 as the default value, allow identical next-arg1 to be used by non-coldboot domain (i.e., untrusted domain) when the property is not provided. Also, update the description of next-arg1 property in the document. Signed-off-by: Yu Chien Peter Lin Reviewed-by: Alvin Chang Reviewed-by: Anup Patel

lib: sbi: Extend sbi_hartmask to support both hartid and hartindex

2023-09-24T06:09:32Z

Currently, the sbi_hartmask is indexed by hartid which puts a limit on hartid to be less than SBI_HARTMASK_MAX_BITS. We extend the sbi_hartmask implementation to use hartindex and support updating sbi_hartmask using hartid. This removes the limit on hartid and existing code works largely unmodified. Signed-off-by: Xiang W Signed-off-by: Anup Patel

lib: utils/fdt: Use heap in FDT domain parsing

2023-06-05T10:29:35Z

Let's use heap allocation in FDT domain parsing instead of using a fixed size global array. Signed-off-by: Anup Patel Reviewed-by: Andrew Jones

lib: sbi: Fix how to check whether the domain contains fw_region

2023-04-06T10:44:35Z

Because firmware is split into rw/rx segments, it cannot be recorded by a root_fw_region. This problem is solved by adding a flag fw_region_inited to sbi_domain. Signed-off-by: Xiang W Reviewed-by: Himanshu Chauhan Reviewed-by: Anup Patel

lib: sbi: Add system_suspend_allowed domain property

2023-02-27T14:15:28Z

Only privileged domains should be allowed to suspend the entire system. Give the root domain this property by default and allow other domains to be given the property by specifying it in the DT. Signed-off-by: Andrew Jones Reviewed-by: Anup Patel