opensbi.git/lib/utils/gpio, branch master

lib: utils/gpio: Use fdt_driver for initialization

2024-11-28T11:59:12Z

FDT gpio drivers have an extra .xlate operation, so they need to embed the `struct fdt_driver` inside the subsystem-specific type. The gpio subsystem always initializes the driver for a specific DT node. Signed-off-by: Samuel Holland Reviewed-by: Anup Patel

treewide: Make carray arrays const and NULL-terminated

2024-11-28T11:39:17Z

This allows the compiler to generate significantly better code, because it does not have to maintain either the loop counter or loop limit. Plus there are half as many symbols to relocate. This also simplifies passing carray arrays to helper functions. Signed-off-by: Samuel Holland Reviewed-by: Anup Patel

lib: utils/gpio: Use FDT node offset as GPIO chip ID

2024-11-05T12:24:39Z

Since the FDT is not modified during driver initialization, node offsets are just as suitable as phandles for use as identifiers: they are stable and unique. With this change, it is no longer necessary to pass the phandle to the driver init functions, so these init functions now use the same prototype as other kinds of drivers. This matches what is already done for I2C adapters. Signed-off-by: Samuel Holland Reviewed-by: Anup Patel

lib: utils/gpio: Remove fdt_gpio_driver() function

2024-11-05T12:24:37Z

This function looks up a chip's driver by matching known drivers against chip->driver, but that is equivalent to using chip->driver directly. Signed-off-by: Samuel Holland Reviewed-by: Anup Patel

lib: utils/gpio: designware: Allocate chips on the heap

2024-10-28T05:10:25Z

This reduces firmware size for SoCs which do not use this driver. Signed-off-by: Samuel Holland Reviewed-by: Anup Patel

lib: utils/gpio: Constify FDT pointers in parsing functions

2024-08-24T07:32:27Z

Indicate that none of these functions modify the devicetree by constifying the parameter type. Signed-off-by: Samuel Holland Reviewed-by: Andrew Jones Reviewed-by: Anup Patel

Makefile: change to using .carray.c for carray files

2024-07-04T06:41:45Z

We would like to clean any files generated by the carray scripts by just searching for the filename as the current make system turns f.carray into f.o. Change to make the make system turn f.carray into f.carray.o note, command to go through .mk files changing the .o in the .mk files is: find . -type f -name "*.carray" | xargs -t -I fname /bin/bash -x -c ' fn=`basename -s .carray fname`; echo "$fn"; sed -i `dirname fname `/objects.mk -e s/"$fn".o/"$fn".carray.o/g' Link: https://patchwork.ozlabs.org/project/opensbi/patch/20240401213438.590209-2-ivan.orlov0322@gmail.com/ Reported-by: Ivan Orlov Suggested-by: Andrew Jones Signed-off-by: Ben Dooks Reviewed-by: Andrew Jones Reviewed-by: Anup Patel

lib: utils/gpio: respect flag GPIO_FLAG_ACTIVE_LOW

2024-05-23T10:12:52Z

"gpio-poweroff" and "gpio-restart" always set gpio to high to active the function, but some chips need a low signal to active. Fortunately, it can be achieved by setting GPIO_FLAG_ACTIVE_LOW for the gpio. Implement this flag support for the gpio library so the gpio reset can function well. Signed-off-by: Inochi Amaoto Reviewed-by: Anup Patel

gpio/starfive: redundant readl() call

2023-10-06T11:59:09Z

In starfive_gpio_direction_output() readl() is called twice to read the gpio direction register. The result of the first read is discarded. Remove the redundant read. Fixes: 908be1b85c8f ("gpio/starfive: add gpio driver and support gpio reset") Signed-off-by: Heinrich Schuchardt Reviewed-by: Anup Patel

lib: utils/gpio: Fix RV32 compile error for designware GPIO driver

2023-07-12T05:52:03Z

Currently, we see following compile error in the designeware GPIO driver for RV32 systems: lib/utils/gpio/fdt_gpio_designware.c:115:20: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] 115 | chip->dr = (void *)addr + (bank * 0xc); | ^ lib/utils/gpio/fdt_gpio_designware.c:116:21: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] 116 | chip->ext = (void *)addr + (bank * 4) + 0x50; We fix the above error using an explicit type-cast to 'unsigned long'. Fixes: 7828eebaaa77 ("gpio/desginware: add Synopsys DesignWare APB GPIO support") Signed-off-by: Anup Patel Reviewed-by: Xiang W