opensbi.git/lib/utils/irqchip/plic.c, branch v1.1

lib: irqchip/plic: fix typo in plic_warm_irqchip_init

2022-06-22T05:25:27Z

The second invocation of plic_context_init() incorrectly calls the function with m_cntx_id instead of s_cntx_id. This breaks systems which only have 1 external interrupt per hart. Fixes: 8c362e7 ("lib: irqchip/plic: Factor out a context init function") Signed-off-by: Jan Remes Reviewed-by: Anup Patel Reviewed-by: Samuel Holland

lib: irqchip/plic: Add priority save/restore helpers

2022-06-13T06:24:06Z

These can be used by platform code to save the PLIC priority state, if it would otherwise be lost during non-retentive suspend. The platform is responsible for allocating all necessary storage. As a space optimization, store the saved priority values as 8-bit integers, since that is large enough to hold any priority value on the relevant platforms. Reviewed-by: Anup Patel Signed-off-by: Samuel Holland

lib: irqchip/plic: Add context save/restore helpers

2022-06-13T06:24:06Z

These can be used by platform code to save the PLIC context state, if it would otherwise be lost during non-retentive suspend. The platform is responsible for allocating all necessary storage. Reviewed-by: Anup Patel Signed-off-by: Samuel Holland

lib: irqchip/plic: Factor out a context init function

2022-06-13T06:24:06Z

This simplifies both the callers and the callees by removing duplicated code and consolidating the error handling. It also fixes two bugs in the process: 1) ie_words was one too large when plic->num_src was a multiple of 32. 2) plic_set_ie takes a 32-bit mask, not a Boolean value, so the FPGA platforms previously only enabled one out of every 32 interrupts. Reviewed-by: Anup Patel Signed-off-by: Samuel Holland

lib: irqchip/plic: Constify plic_data pointers

2022-06-13T06:24:06Z

None of the functions modify the passed-in plic_data, so mark it const. Reviewed-by: Anup Patel Signed-off-by: Samuel Holland

lib: fix pointer of type 'void *' used in arithmetic

2022-01-21T16:28:12Z

Using "void *" in arithmetic causes errors with strict compiler settings: "error: pointer of type 'void *' used in arithmetic [-Werror=pointer-arith]" Avoid these by calculating on "char *" where 1-byte data size is assumed. Signed-off-by: Jukka Laitinen Reviewed-by: Dong Du Reviewed-by: Xiang W Reviewed-by: Anup Patel

lib: utils: Allow PLIC functions to be used for multiple PLICs

2020-05-23T05:06:29Z

We extend all PLIC functions to have a "struct plic_data *" parameter pointing to PLIC details. This allows platforms to use these functions for multiple PLIC instances. Signed-off-by: Anup Patel Reviewed-by: Atish Patra

lib: utils: Remove redundant parameters from PLIC init functions

2020-05-23T05:06:26Z

The "target_hart" and "hart_count" parameters of PLIC cold and warm init functions are only used for sanity checks and not required in PLIC initialization. Signed-off-by: Anup Patel Reviewed-by: Atish Patra

lib: irqchip/plic: Fix maximum priority threshold value

2020-04-06T03:28:56Z

As per the PLIC specification, maximum priority threshold value is 0x7. Even though, writing a higher value doesn't cause any error in qemu hifive unleashed, there may be some implementation which checks the upper and may result in an illegal access. Signed-off-by: Atish Patra Reviewed-by: Bin Meng Reviewed-by: Anup Patel

lib: utils: Move PLIC DT fix up codes to fdt_helper.c

2020-03-18T04:10:14Z

Now that we have a dedicated fdt_helper.c file for DT releated helper routines, move plic_fdt_fixup() codes from plic.c to fdt_helper.c and rename it to fdt_plic_fixup() at the same time, to keep name consistency in the same file. Signed-off-by: Bin Meng Reviewed-by: Atish Patra