opensbi.git/lib/utils/serial, branch v1.7

lib: utils/serial: Add PXA UARTs support

2025-03-27T14:50:05Z

The PXA variant of the uart8250 adds the UART Unit Enable bit (UUE) that needs to be set to enable the XScale PXA UART. And it is required for some RISC-V SoCs like the Spacemit K1 that implement the PXA UART. This introduces the "intel,xscale-uart" compatible to handle setting the UUE bit. Signed-off-by: Junhui Liu Reviewed-by: Anup Patel Link: https://lore.kernel.org/r/20250327-pxa-uart-support-v2-1-c4400c1fcd0b@pigmoral.tech Signed-off-by: Anup Patel

lib: sbi: Avoid GOT indirection for global symbol references

2025-03-24T11:30:59Z

OpenSBI is compiled with -fPIE, which generally implies dynamic linking. This causes the compiler to generate GOT references for global symbols in order to support runtime symbol interposition. However, OpenSBI does not actually perform dynamic linking, so the GOT indirection just adds unnecessary overhead. The GOT references can be avoided by declaring global symbols with hidden visibility, thus making them local to this dynamic object and non-interposable. GCC/Clang's -fvisibility parameter is insufficient for this purpose when referencing objects from other translation units; either __attribute__((visibility(...)) or the pragma is required. Use the pragma since it is easier to apply to every symbol. Additionally clean up the one GOT reference from inline assembly. With this change, a firmware linked with LLD does not contain either a GOT or a PLT, and a firmware linked with BFD ld contains only a GOT with a single (unreferenced, legacy) _GLOBAL_OFFSET_TABLE_ entry. Signed-off-by: Samuel Holland Reviewed-by: Anup Patel

lib: utils/serial: Use fdt_driver for initialization

2024-11-28T12:22:58Z

The serial driver subsystem does not need any extra data, so it can use `struct fdt_driver` directly. The generic fdt_serial_init() first attempts to match the chosen stdout device, and upon failure matches the first available serial device in the DT. It is a fatal error if no such device is found. This matches the behavior of fdt_driver_init_one(). Signed-off-by: Samuel Holland Reviewed-by: Anup Patel

treewide: Make carray arrays const and NULL-terminated

2024-11-28T11:39:17Z

This allows the compiler to generate significantly better code, because it does not have to maintain either the loop counter or loop limit. Plus there are half as many symbols to relocate. This also simplifies passing carray arrays to helper functions. Signed-off-by: Samuel Holland Reviewed-by: Anup Patel

lib: utils/serial: Pass the FDT to fdt_serial_init()

2024-08-24T07:33:01Z

Indicate that this function does not modify the FDT blob, and deduplicate the call to fdt_get_address(). Signed-off-by: Samuel Holland Reviewed-by: Andrew Jones Reviewed-by: Anup Patel

lib: utils/serial: Constify FDT pointers in parsing functions

2024-08-24T07:32:46Z

Indicate that none of these functions modify the devicetree by constifying the parameter type. Signed-off-by: Samuel Holland Reviewed-by: Andrew Jones Reviewed-by: Anup Patel

Makefile: change to using .carray.c for carray files

2024-07-04T06:41:45Z

We would like to clean any files generated by the carray scripts by just searching for the filename as the current make system turns f.carray into f.o. Change to make the make system turn f.carray into f.carray.o note, command to go through .mk files changing the .o in the .mk files is: find . -type f -name "*.carray" | xargs -t -I fname /bin/bash -x -c ' fn=`basename -s .carray fname`; echo "$fn"; sed -i `dirname fname `/objects.mk -e s/"$fn".o/"$fn".carray.o/g' Link: https://patchwork.ozlabs.org/project/opensbi/patch/20240401213438.590209-2-ivan.orlov0322@gmail.com/ Reported-by: Ivan Orlov Suggested-by: Andrew Jones Signed-off-by: Ben Dooks Reviewed-by: Andrew Jones Reviewed-by: Anup Patel

lib: serial: fix RX path in litex-uart

2024-06-13T16:24:09Z

When used to read characters from the terminal (e.g., when the SBI console is used via ecall from linux with `console=hvc0`), we must acknowledge receipt of each character to "pop" it off the LiteUART hardware queue, and allow the next character to be made available. Fixes: 52af6e4b ("lib: utils: Add LiteX UART support") Suggested-by: Dolu1990 Signed-off-by: Gabriel Somlo Reviewed-by: Anup Patel

lib: utils/serial: Fix fdt_serial to match more dt nodes

2024-06-13T13:09:37Z

If there are multiple dt nodes, the previous code only tries to match the first one, which may lose initialization. Signed-off-by: Xiang W Reviewed-by: Anup Patel

lib: utils/serial: Skip initialize serial when dt is not enabled

2024-06-13T13:06:49Z

When the dt node has a status property and the value is not ok or okay, skip initializing serial. Signed-off-by: Xiang W Reviewed-by: Anup Patel