opensbi.git/lib/utils, branch v1.3

platform/lib: Set no-map attribute on all PMP regions

2023-06-15T12:57:17Z

This reverts commit 6966ad0abe70 ("platform/lib: Allow the OS to map the regions that are protected by PMP"). It was thought at the time of this commit that allowing the kernel to map PMP protected regions was safe but it is actually not: for example, the hibernation process will try to access any linear mapping page and then will fault on such mapped PMP regions [1]. Another issue is that the device tree specification [2] states that a !no-map region must be declared as EfiBootServicesData/Code in the EFI memory map which would make the PMP protected regions reclaimable by the kernel. And to circumvent this, RISC-V edk2 diverges from the DT specification to declare those regions as EfiReserved. The no-map attribute was removed to allow the kernel to use hugepages larger than 2MB to map the linear mapping to improve the performance but actually a recent talk from Mike Rapoport [3] stated that the performance benefit was marginal. For all those reasons, let's mark all the PMP protected regions as "no-map". [1] https://lore.kernel.org/linux-riscv/CAAYs2=gQvkhTeioMmqRDVGjdtNF_vhB+vm_1dHJxPNi75YDQ_Q@mail.gmail.com/ [2] "3.5.4 /reserved-memory and UEFI" https://github.com/devicetree-org/devicetree-specification/releases/download/v0.4-rc1/devicetree-specification-v0.4-rc1.pdf [3] https://lwn.net/Articles/931406/ Signed-off-by: Alexandre Ghiti Reviewed-by: Atish Patra Reviewed-by: Xiang W

lib: utils/irqchip: Use scratch space to save per-HART IMSIC pointer

2023-06-06T10:31:14Z

Instead of using a global array indexed by hartid, we should use scratch space to save per-HART IMSIC pointer and IMSIC file number. Signed-off-by: Anup Patel Reviewed-by: Andrew Jones

lib: utils/irqchip: Don't check hartid in imsic_update_hartid_table()

2023-06-05T11:21:07Z

The imsic_map_hartid_to_data() already checks hartid before using so we don't need to check in imsic_update_hartid_table(). Signed-off-by: Anup Patel Reviewed-by: Andrew Jones

lib: utils/irqchip: Use scratch space to save per-HART PLIC pointer

2023-06-05T11:20:56Z

Instead of using a global array indexed by hartid, we should use scratch space to save per-HART PLIC pointer and PLIC context numbers. Signed-off-by: Anup Patel Reviewed-by: Andrew Jones

lib: utils/timer: Use scratch space to save per-HART MTIMER pointer

2023-06-05T11:16:50Z

Instead of using a global array indexed by hartid, we should use scratch space to save per-HART MTIMER pointer. Signed-off-by: Anup Patel Reviewed-by: Andrew Jones

lib: utils/ipi: Use scratch space to save per-HART MSWI pointer

2023-06-05T10:32:59Z

Instead of using a global array indexed by hartid, we should use scratch space to save per-HART MSWI pointer. Signed-off-by: Anup Patel Reviewed-by: Andrew Jones

lib: utils/fdt: Use heap in FDT domain parsing

2023-06-05T10:29:35Z

Let's use heap allocation in FDT domain parsing instead of using a fixed size global array. Signed-off-by: Anup Patel Reviewed-by: Andrew Jones

lib: utils/timer: Use heap in ACLINT MTIMER driver

2023-06-05T10:28:42Z

Let's use heap allocation in ACLINT MTIMER driver instead of using a fixed size global array. Signed-off-by: Anup Patel Reviewed-by: Andrew Jones

lib: utils/irqchip: Use heap in PLIC, APLIC and IMSIC drivers

2023-06-05T10:27:58Z

Let's use heap allocation in PLIC, APLIC, and IMSIC irqchip drivers instead of using a fixed size global array. Signed-off-by: Anup Patel Reviewed-by: Andrew Jones

lib: utils/ipi: Use heap in ACLINT MSWI driver

2023-06-05T10:25:56Z

Let's use heap allocation in ACLINT MSWI driver instead of using a fixed size global array. Signed-off-by: Anup Patel Reviewed-by: Andrew Jones