opensbi.git/lib, branch release-1.5.x

lib: sbi: check result of pmp_get() in is_pmp_entry_mapped()

2024-08-02T03:23:22Z

pmp_get() may return an error if the given entry, given by the caller of is_pmp_entry_mapped(), is invalid. This results in the output parameters for pmp_get() being uninitialized. To avoid using garbage values, check the result and return early if necessary. This issue is not being hit because at the moment is_pmp_entry_mapped() is only being called from a single site with a valid hardcoded value. Signed-off-by: Carlos López Reviewed-by: Anup Patel

lib: sbi: fwft: fix incorrect size passed to sbi_zalloc()

2024-08-02T03:23:20Z

The fwt_hart_state struct inciludes a flexible array member, so its allocation size will be that of the struct itself, plus that of each of the members in the array. When calculating this size, instead of taking the size of the struct, the size of a pointer to it was taken, which is incorrect. Luckily, this happenned to not produce memory corruption because the size of the non-flexible members of the struct is the same as the size of a pointer. Signed-off-by: Carlos López Reviewed-by: Anup Patel

lib: sbi: dbtr: fix potential NULL pointer dereferences

2024-08-02T03:23:19Z

In several dbtr functions, we first check that the dbtr trigger is not NULL and that its state is what we expect. However, it only makes sense to perform the second check if the dbtr trigger is not NULL. Othwerwise we will dereference a NULL pointer. Thus, change the condition so that it shortcuts to the first check if necessary. Signed-off-by: Carlos López Reviewed-By: Anup Patel

lib: sbi_hsm: Save/restore menvcfg only when it exists

2024-07-29T06:04:18Z

Attempting to access the menvcfg CSR raises an illegal instruction exception on hardware which implements Sm1p11 or older. Fixes: e9ee9678ba50 ("lib: sbi: fwft: add support for SBI_FWFT_PTE_AD_HW_UPDATING") Signed-off-by: Samuel Holland Reviewed-by: Anup Patel

lib: sbi: check incoming dbtr shmem address

2024-06-28T03:06:46Z

Current Debug Trigger SBI extension proposal suggests to activate shmem area and obtain its physical address from S-mode software in the following way: : If both `shmem_phys_lo` and `shmem_phys_hi` parameters are not : all-ones bitwise then `shmem_phys_lo` specifies the lower XLEN : bits and `shmem_phys_hi` specifies the upper XLEN bits of the : shared memory physical base address. The `shmem_phys_lo` MUST : be `(XLEN / 8)` byte aligned and the size of shared memory is : assumed to be `trig_max * (XLEN / 2)` bytes. For more details see the current version of the proposal: - https://lists.riscv.org/g/tech-debug/message/1302 On the other hand, on RV32, the M-mode can only access the first 4GB of the physical address space because M-mode does not have MMU to access full 34-bit physical address space. Similarly, on RV64, the M-mode can only access memory addressed by 64 bits. This commit checks shmem address in function sbi_dbtr_setup_shmem to make sure that shmem_phys_hi part of the valid address is zero. Besides, the macro DBTR_SHMEM_MAKE_PHYS is updated to take into account only low XLEN part. Signed-off-by: Sergey Matyukevich Reviewed-by: Himanshu Chauhan

lib: sbi: fwft: return SBI_EINVAL rather than SBI_ERR_INVALID_PARAM

2024-06-26T12:44:49Z

Error code returned by the ecall handles should use the defines from sbi_ecall_interface.h rather than sbi_error.h. Signed-off-by: Clément Léger Reviewed-by: Andrew Jones Reviewed-by: Anup Patel

lib: sbi: fwft: check feature value to be exactly 1 or 0

2024-06-26T12:43:54Z

As stated by the spec and pointed out by Andrew Jones, the value passed for MISALIGNED_EXC_DELEG and PTE_AD_HW_UPDATING should be either 0 or 1. Add check for these values and return SBI_EINVAL if not. Signed-off-by: Clément Léger Reviewed-by: Andrew Jones Reviewed-by: Anup Patel

lib: sbi: implement SBI FWFT extension

2024-06-19T12:45:28Z

The SBI FWFT extension defines a set of function that can be called to control the configuration of some platform features (misaligned trap delegation, etc). This patch implements sbi_fwft_set() and sbi_fwft_get() as defined in the specification [1]. Link: https://lists.riscv.org/g/tech-prs/message/924 [1] Signed-off-by: Clément Léger Reviewed-by: Anup Patel

lib: sbi: fwft: add support for SBI_FWFT_PTE_AD_HW_UPDATING

2024-06-19T12:41:26Z

Add support for SBI_FWFT_PTE_AD_HW_UPDATING based on SVADU presence. Signed-off-by: Clément Léger Reviewed-by: Anup Patel

lib: sbi: fwft: add support for SBI_FWFT_MISALIGNED_EXC_DELEG

2024-06-19T12:40:36Z

Add support for SBI_FWFT_MISALIGNED_EXC_DELEG withing FWFT support. This support allows to delegate misaligned accesses traps. Signed-off-by: Clément Léger Reviewed-by: Anup Patel