From dc38929dfb441cbecb4e31a299b463bac11d02cf Mon Sep 17 00:00:00 2001 From: Anup Patel Date: Tue, 5 May 2020 11:46:25 +0530 Subject: lib: sbi: Improve misa_string() implementation The RISC-V ISA string does not follow alphabetical order. Instead, we have a RISC-V specific ordering of extensions in the RISC-V ISA string. This patch improves misa_string() implementation to return a valid RISC-V ISA string. Signed-off-by: Anup Patel Reviewed-by: Atish Patra --- include/sbi/riscv_asm.h | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) (limited to 'include') diff --git a/include/sbi/riscv_asm.h b/include/sbi/riscv_asm.h index 6c5c7299..6e093ca3 100644 --- a/include/sbi/riscv_asm.h +++ b/include/sbi/riscv_asm.h @@ -173,19 +173,8 @@ int misa_extension_imp(char ext); /* Get MXL field of misa, return -1 on error */ int misa_xlen(void); -static inline void misa_string(char *out, unsigned int out_sz) -{ - unsigned long i; - - for (i = 0; i < 26; i++) { - if (misa_extension_imp('A' + i)) { - *out = 'A' + i; - out++; - } - } - *out = '\0'; - out++; -} +/* Get RISC-V ISA string representation */ +void misa_string(int xlen, char *out, unsigned int out_sz); int pmp_set(unsigned int n, unsigned long prot, unsigned long addr, unsigned long log2len); -- cgit v1.3.1