From 18ec89e46e3cf8011b30deded6ea8d77720bdb3c Mon Sep 17 00:00:00 2001 From: Anup patel Date: Tue, 22 Jan 2019 14:20:59 +0530 Subject: lib: Remove source_hart and hartid parameter from IPI callbacks The source_hart and hartid parameter is really not required in IPI callbacks of sbi_platform because current hartid can always be obtained by calling sbi_current_hartid() API. Signed-off-by: Anup Patel --- platform/common/sys/clint.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) (limited to 'platform/common/sys') diff --git a/platform/common/sys/clint.c b/platform/common/sys/clint.c index e84c3829..fc95fd3e 100644 --- a/platform/common/sys/clint.c +++ b/platform/common/sys/clint.c @@ -9,28 +9,28 @@ #include #include +#include #include static u32 clint_ipi_hart_count; static volatile void *clint_ipi_base; static volatile u32 *clint_ipi; -void clint_ipi_inject(u32 target_hart, u32 source_hart) +void clint_ipi_inject(u32 target_hart) { - if ((clint_ipi_hart_count <= target_hart) || - (clint_ipi_hart_count <= source_hart)) + if (clint_ipi_hart_count <= target_hart) return; /* Set CLINT IPI */ writel(1, &clint_ipi[target_hart]); } -void clint_ipi_sync(u32 target_hart, u32 source_hart) +void clint_ipi_sync(u32 target_hart) { u32 target_ipi, incoming_ipi; + u32 source_hart = sbi_current_hartid(); - if ((clint_ipi_hart_count <= target_hart) || - (clint_ipi_hart_count <= source_hart)) + if (clint_ipi_hart_count <= target_hart) return; /* Wait until target HART has handled IPI */ @@ -57,14 +57,15 @@ void clint_ipi_clear(u32 target_hart) writel(0, &clint_ipi[target_hart]); } -int clint_warm_ipi_init(u32 target_hart) +int clint_warm_ipi_init(void) { - if (clint_ipi_hart_count <= target_hart || - !clint_ipi_base) + u32 hartid = sbi_current_hartid(); + + if (!clint_ipi_base) return -1; /* Clear CLINT IPI */ - clint_ipi_clear(target_hart); + clint_ipi_clear(hartid); return 0; } -- cgit v1.3.1