summaryrefslogtreecommitdiff
path: root/.github
diff options
context:
space:
mode:
authorpanrunyu <[email protected]>2019-01-01 22:11:20 -0500
committerpanrunyu <[email protected]>2019-01-01 22:11:20 -0500
commit2601a107b7b7e797571bd60784664b627fb6b212 (patch)
treea43a969a6b72537f303c50f048d76d37c64d34be /.github
parentf5770682f94e972c7603f1c9aa6b5b7875853062 (diff)
add pr template
Diffstat (limited to '.github')
-rw-r--r--.github/PULL_REQUEST_TEMPLATE.md32
1 files changed, 32 insertions, 0 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
new file mode 100644
index 0000000000..cd2179ca59
--- /dev/null
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -0,0 +1,32 @@
+### Summary of this Pull Request (PR) 拉取请求的简述
+
+**Add description here.**
+
+### Intent for your PR 拉取请求的目的
+
+Choose one (Mandatory):
+
+- [ ] This PR is for a code-review and is intended to get feedback 本拉取请求是一个草稿版本
+- [ ] This PR is mature, and ready to be integrated into the repo 本拉取请求是一个成熟版本
+
+### Reviewers (Mandatory): 代码审阅者(必须指定)
+(@<github.com username(s)> Ex: @user1, @user2)
+
+
+### Code Quality: 代码质量
+As part of this pull request, I've considered the following:
+我在这个拉取请求中考虑了:
+- [ ] Style guide is adhered to, including spacing, naming and other style 代码的格式正确
+- [ ] All redundant code is removed and cleaned up 没有垃圾代码
+- [ ] All modifications are justified 所有变更均有原因
+- [ ] I've commented appropriately where code is tricky 难懂代码均被注释
+- [ ] Code in this PR is of high quality 本拉取请求高质量
+
+### Testing:代码测试
+
+I've tested the code using the following test programs (provide list here):
+我已经在如下用例上跑过测试:
+
+- [ ] application 1
+- [ ] application 2
+- [ ] ...(add others here)