summaryrefslogtreecommitdiff
path: root/tools
diff options
context:
space:
mode:
authorGrissiom <[email protected]>2014-08-28 12:27:47 +0800
committerGrissiom <[email protected]>2014-09-01 10:11:10 +0800
commit51c4a3aeaea9947701e03abd085afc3eb07df6a8 (patch)
tree2ad2012a4ef29a883d46b39061d51f155a77480c /tools
parent46d01d34062a94fd094cb07c4eae0236323b42b8 (diff)
tools/building: remove the use of startupinfo
The startupinfo does not have any visible effects on the building process and some old Python version does not have it at all. So remove it for the seek of simple. Tested `scons -j4` in a dual core virtual machine.
Diffstat (limited to 'tools')
-rw-r--r--tools/building.py5
1 files changed, 1 insertions, 4 deletions
diff --git a/tools/building.py b/tools/building.py
index 3572daabbe..ad5df12bcc 100644
--- a/tools/building.py
+++ b/tools/building.py
@@ -27,8 +27,6 @@ class Win32Spawn:
newargs = string.join(args[1:], ' ')
cmdline = cmd + " " + newargs
- startupinfo = subprocess.STARTUPINFO()
- startupinfo.dwFlags |= subprocess.STARTF_USESHOWWINDOW
# Make sure the env is constructed by strings
_e = {k: str(v) for k, v in env.items()}
@@ -40,8 +38,7 @@ class Win32Spawn:
os.environ['PATH'] = _e['PATH']
try:
- proc = subprocess.Popen(cmdline, env=_e,
- startupinfo=startupinfo, shell=False)
+ proc = subprocess.Popen(cmdline, env=_e, shell=False)
except Exception as e:
print 'Error in calling:\n%s' % cmdline
print 'Exception: %s: %s' % (e, os.strerror(e.errno))