From c7ad493b9ac3e2a6085ddfee0a33717de60845f2 Mon Sep 17 00:00:00 2001 From: Mingjie Shen Date: Tue, 13 Jun 2023 18:10:03 -0400 Subject: [libc][ctime] move null pointer check before dereference This null check was redundant because the pointer timep was dereferenced in any case. --- components/libc/compilers/common/ctime.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'components/libc/compilers') diff --git a/components/libc/compilers/common/ctime.c b/components/libc/compilers/common/ctime.c index dff9ac188e..f3e7de2229 100644 --- a/components/libc/compilers/common/ctime.c +++ b/components/libc/compilers/common/ctime.c @@ -177,7 +177,7 @@ static int set_timeval(struct timeval *tv) struct tm *gmtime_r(const time_t *timep, struct tm *r) { int i; - int work = *timep % (SPD); + int work; if(timep == RT_NULL || r == RT_NULL) { @@ -187,6 +187,7 @@ struct tm *gmtime_r(const time_t *timep, struct tm *r) rt_memset(r, RT_NULL, sizeof(struct tm)); + work = *timep % (SPD); r->tm_sec = work % 60; work /= 60; r->tm_min = work % 60; -- cgit v1.3.1