tinyusb.git, branch claude/pr-babysit-split-triageUnnamed repository; edit this file 'description' to name the repository.http://cgit.235523.xyz/tinyusb.git/atom/?h=claude%2Fpr-babysit-split-triage2026-08-27T02:52:06Zpr-babysit: scope file-less CI fix groups with a dedicated agent before dispatch2026-08-27T02:52:06Zhathachthach@tinyusb.org2026-08-27T02:52:06Zurn:sha1:22323debb3c9c1cc07cc4deeef096a647b4b67ac
code-writer's contract needs an explicit file set; a bare CI check name is not
a scope. Undeterminable groups are withheld (ok=false) instead of dispatched.
pr-babysit: name a file-less scope as a CI check so the fixer doesn't treat it as a path2026-08-27T02:49:15Zhathachthach@tinyusb.org2026-08-27T02:49:15Zurn:sha1:5a8abe788559df7e79177f40669a53a195bb3600pr-babysit: describe an empty fix/verify scope as the whole working tree2026-08-27T02:42:38Zhathachthach@tinyusb.org2026-08-27T02:42:38Zurn:sha1:08e151678bd866b6766987561fd73d150460d5db
A note with no files (e.g. a CI failure whose log yielded no paths) left the
scope string empty and told the verifier to run an unconstrained 'git diff --',
which silently diffs the whole tree instead of nothing.
validate: enforce the review gate in-script and keep findings structured2026-08-27T02:34:41Zhathachthach@tinyusb.org2026-08-27T02:34:41Zurn:sha1:05b6502c5d3a143938cdb8cc7e90d50d0988dd1a
pass was trusted from the agent and findings lived only in a clip()-truncated
detail string, so a CONFIRMED bug could ride through on pass=true or be lost
to truncation.
validate: review stage covers all code-review dimensions, reports PLAUSIBLE findings2026-08-27T02:31:55Zhathachthach@tinyusb.org2026-08-27T02:31:55Zurn:sha1:4d9006e7d7f71c0037d0a618b939b894a9b76550validate: review stage runs the diff review directly - the code-review skill is a CLI built-in, unavailable to workflow subagents2026-08-27T02:27:15Zhathachthach@tinyusb.org2026-08-27T02:27:15Zurn:sha1:50c46fc6a543ace76a6c00b119599c6b7eed21b5validate: add claude + codex diff-review stages (opus/high, sol/high)2026-08-27T02:22:59Zhathachthach@tinyusb.org2026-08-27T02:22:59Zurn:sha1:64fa5fb821a9c31d5461f3f7d0f66003662f2c5apr-babysit: drop the @codex mention - the GitHub connector auto-reviews pushes2026-08-26T18:16:44Zhathachthach@tinyusb.org2026-08-26T18:16:44Zurn:sha1:17327876f1f6213bbbeb240bcf7f384bb9aa1387pr-babysit: summon Codex after fix pushes; settle the CI lane on every exit2026-08-26T18:14:16Zhathachthach@tinyusb.org2026-08-26T18:12:04Zurn:sha1:179e5ae9c7ac1a80b40f75d1849accb9bcec5416
Copilot re-reviews pushes automatically (repo setting); Codex only
reviews when mentioned, so the push step now posts '@codex review'.
Also fixes Copilot's finding on this PR: ciPromise carried four early
returns before its await (validator died, dry run, verification failed,
push failed), so a rejection was unhandled and a detached pr-ci-watcher
could outlive the workflow (even re-running CI jobs after a dry run).
The lane now resolves to null on error at creation, and stopWith()
awaits it on every early exit.
pr-babysit: checkoutDir arg decouples the PR checkout from the session cwd2026-08-26T18:04:43Zhathachthach@tinyusb.org2026-08-26T18:04:43Zurn:sha1:ec773c14696312894652e20119a0e9f300158a77
Agents inherit the session working directory, so babysitting a PR whose
checkout is a sub-worktree pointed the fix/push lane at the wrong tree.
Optional checkoutDir is threaded into the validator, fix, verify and
push prompts; default keeps the old the-session-IS-the-checkout shape.