tinyusb.git/src/class/mtp/mtp_device.h, branch claude/mtp-data-phase-fixesUnnamed repository; edit this file 'description' to name the repository.http://cgit.235523.xyz/tinyusb.git/atom/src/class/mtp/mtp_device.h?h=claude%2Fmtp-data-phase-fixes2026-08-17T05:11:53Zclass/mtp: correct data phase completion and transaction recovery2026-08-17T05:11:53Zhathachthach@tinyusb.org2026-08-13T07:34:58Zurn:sha1:5a9803555f362a0efeeb549093a3338c5b151e9c
The data-out phase ended before its terminating ZLP and before the
application had seen the final payload, and several transaction states
had no way back to idle. Reworked as one state machine:
- Add MTP_PHASE_DATA_COMPLETE, entered once the data phase has fully
finished - for an exact buffer-multiple data-out, only after the
host's terminating ZLP - and deliver tud_mtp_data_complete_cb() from
there. tud_mtp_response_send() now refuses while the phase is still
MTP_PHASE_DATA: ep_out still owes the host a read at that point and
re-arming it for a new command would race that read.
- Arm the terminating-ZLP read before handing the final payload to the
application, as the IN path already does. The 0-length read passes a
NULL buffer so the payload is untouched, and claiming ep_out first
means a late tud_mtp_data_receive() fails its own claim instead of
breaking the driver's next step.
- Honor the documented negative return of tud_mtp_data_xfer_cb() and
tud_mtp_data_complete_cb() by entering MTP_PHASE_ERROR, which stalls
both endpoints. This is the application's way out of a data phase now
that a response cannot be sent from one. Their weak stubs return 0 so
an application that does not implement them is unaffected.
- Take total_len from the container header the host sends on the first
OUT packet. The application can only set it up front when it knows
the size (SendObject); SendObjectInfo cannot, so total_len kept the
12-byte header default and the phase ended on the first packet.
- Reject a runt or misdirected container in both the command and data
phases: a short packet was matched against stale buffer contents, and
the failed TU_VERIFY left ep_out neither armed nor stalled. The
first data-out packet previously underflowed payload_bytes instead.
- Restore the previous phase when tud_mtp_data_send()/_receive() cannot
claim their endpoint, so the application's fallback response is not
refused by a phase the driver never actually entered.
- Re-arm ep_out after MTP_REQ_CANCEL of a data phase, and defer the
new-command read when ep_out is still busy with the ZLP read of an
abandoned transaction: usbd_edpt_xfer() asserts on a busy endpoint,
so MTP_REQ_RESET could not recover.
The MTP example follows the same contract: a handler error raised mid
data phase (fs_send_object_info validates the received ObjectInfo, so
STORE_FULL and INVALID_PARENT_OBJECT can only be raised there) is kept
and answered from tud_mtp_data_complete_cb() once the phase completes.
license: use SPDX identifiers for src/ headers (#3749)2026-07-02T14:55:45ZHa Thachthach@tinyusb.org2026-07-02T14:55:45Zurn:sha1:7a4111b96ef6279e75579f9a18443834f6a0871d
* license: use SPDX identifiers for src/ headers
Replace the full ~20-line MIT license boilerplate on every src/ file with a
two-line SPDX tag (SPDX-FileCopyrightText + SPDX-License-Identifier), following
the REUSE convention used by CircuitPython and the Linux kernel. Removes ~3500
lines of duplicated boilerplate.mtp: fix adding empty cstring to mtp_container_info2026-03-25T08:43:48Zstepan chepushtanovs.chepushtanov@is.local2026-03-05T06:43:37Zurn:sha1:a64a8579c5bc25ffbe73da55f8431fab6835f3deminor update2026-02-07T11:01:23Zhathachthach@tinyusb.org2026-02-07T11:01:23Zurn:sha1:25de49f8f6e8590eb548d4016e030d19166b9fb3added .clang-format2025-11-05T10:34:27Zhathachthach@tinyusb.org2025-11-05T08:31:02Zurn:sha1:1f04fe7924e8777c1583323171c0e1cabcb29062
fix more alerts
disable IAR CStat since pvs-studio check is better integrated with clion
refactor mtp examples, add phase and session id to callback data2025-09-29T08:08:12Zhathachthach@tinyusb.org2025-09-29T08:02:51Zurn:sha1:4f3a5f92fa21307b1f1c9700cd041e945a627f63implement control request2025-09-27T10:08:21Zhathachthach@tinyusb.org2025-09-27T09:15:04Zurn:sha1:cb21ca1b0cb3221341dca2559109c0bb4dc18e6fimplement tud_mtp_mounted() and tud_mtp_event_send()2025-09-26T08:52:37Zhathachthach@tinyusb.org2025-09-26T08:52:37Zurn:sha1:f9d4bc798177e63532cd5a2ef058400d6f0ef5e4
refactor phase state
fix more ci build2025-09-26T04:51:09Zhathachthach@tinyusb.org2025-09-26T04:51:09Zurn:sha1:e92262eb5cdc35dfc6019c97d1b9166be0f5e62fimplement send object command, able to create new file2025-09-25T10:47:50Zhathachthach@tinyusb.org2025-09-25T10:43:25Zurn:sha1:c9a8330081b59c05b901889d405ed7b9648c0947