tinyusb.git/src/tusb.c, branch claude/adoring-pasteur-kbaFa

clean up PVS-Studio static-analysis findings for raspberry_pi_pico

2026-06-11T23:34:30Z

Resolves all TinyUSB-owned alerts reported by the CI PVS-Studio job (static_analysis.yml, run with --security-related-issues) on the raspberry_pi_pico board: 0 remaining in src/ and examples/. Genuine fixes: - ncm_device: validate wNdpIndex against sizeof(nth16_t), not the pointer size sizeof(nth16) (4 bytes) — the latter under-checks the NTB header (V568). - tusb: drop the redundant `ff_buf != NULL && ff_bufsize > 0` guard in tu_edpt_stream_init(); the early return already guarantees it (V560). - midi_host: bounds-check idx in tuh_midi_itf_get_info() instead of the always-true `&_midi_host[idx]` pointer (V560). - examples: fully initialize resolutions_per_format / frame_num / interval_ms arrays instead of leaving trailing elements implicitly zero (V1009). False positives suppressed at the cause: - usbd/usbh: hide the weak dcd_deinit()/hcd_deinit() stubs from the analyzer with #ifndef PVS_STUDIO. PVS analyzes one TU at a time and binds the call to the always-false weak stub (it cannot model the linker selecting the port's strong definition), then reports the cleanup loop after TU_ASSERT(...deinit()) as unreachable (V779). False positives suppressed locally (inline //-V or .pvsconfig): - .pvsconfig: V501 (HID descriptor macros), V763 (rhport override), V785 (audio function-index switch), V1044 (hardware poll loops). - inline //-V for config-dependent or intentional constructs: V512, V514-style contiguous clears, V547, V557, V560, V614, V619, V641, V1008, V1037, V1048, V1086. Verified: all examples build for raspberry_pi_pico; ceedling test:all passes (60/60); re-run of the CI-exact PVS invocation reports zero TinyUSB-owned findings.

ultrareview nits: keep xfer_result table in sync, hoist blinky loop

2026-06-01T03:05:17Z

- src/tusb.c: extend tu_str_xfer_result[] with "ABORTED" and "INVALID" to match the new enum size. Not reachable today (no HCD posts those values through hcd_event_xfer_complete), but keeps the enum/table invariant intact so future HCDs that surface ABORTED don't index OOB. - examples/dual/dynamic_switch/src/main.c: apply the same while(1) hoist already done for cdc_task / print_devinfo_task to led_blinking_task. On OS_NONE the loop returned mid-iteration, which on first call could fire multiple back-to-back toggles while start_ms (initially 0) caught up to uptime. Co-Authored-By: Claude Opus 4.7

refactor: replace `tu_edpt_state_t` struct with `uint8_t` and update all endpoint state handling methods and accesses

2026-05-04T05:11:03Z

Merge branch 'master' into zlp-hs-on-fs

2026-03-11T09:20:14Z

usbh device descriptor validation, also check ep size > 0

2026-03-09T07:15:20Z

Merge branch 'master' into dwc2_deinit

2026-03-04T10:34:10Z

replace board_millis() with tusb_time_millis_api()

2026-02-27T17:01:40Z

add osal_time_millis() to osal requirement

2026-02-27T16:42:40Z

implement tusb_time_millis_api() with osal_time_millis() when OS is not NONE

Merge remote-tracking branch 'tinyusb/master' into dwc2_deinit

2026-02-27T10:47:58Z

Signed-off-by: HiFiPhile

Fix IAR warnings

2026-02-27T10:46:54Z

Signed-off-by: HiFiPhile