From 31bd4fc169eb002ded3f23e8a6a0b95f3f591efb Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Wed, 22 Oct 2025 05:28:31 +0000
Subject: Add is_isr parameter to dcd_edpt_xfer and dcd_edpt_xfer_fifo

Co-authored-by: HiFiPhile <4375114+HiFiPhile@users.noreply.github.com>
---
 src/portable/synopsys/dwc2/dcd_dwc2.c | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

(limited to 'src/portable/synopsys')

diff --git a/src/portable/synopsys/dwc2/dcd_dwc2.c b/src/portable/synopsys/dwc2/dcd_dwc2.c
index f1e4dbd77..f3a0ee7fc 100644
--- a/src/portable/synopsys/dwc2/dcd_dwc2.c
+++ b/src/portable/synopsys/dwc2/dcd_dwc2.c
@@ -1,3 +1,4 @@
+
 /*
  * The MIT License (MIT)
  *
@@ -456,7 +457,7 @@ void dcd_set_address(uint8_t rhport, uint8_t dev_addr) {
   dwc2->dcfg = (dwc2->dcfg & ~DCFG_DAD_Msk) | (dev_addr << DCFG_DAD_Pos);
 
   // Response with status after changing device address
-  dcd_edpt_xfer(rhport, tu_edpt_addr(0, TUSB_DIR_IN), NULL, 0);
+  dcd_edpt_xfer(rhport, tu_edpt_addr(0, TUSB_DIR_IN), NULL, 0, false, false);
 }
 
 void dcd_remote_wakeup(uint8_t rhport) {
@@ -577,13 +578,14 @@ bool dcd_edpt_iso_activate(uint8_t rhport,  tusb_desc_endpoint_t const * p_endpo
   return true;
 }
 
-bool dcd_edpt_xfer(uint8_t rhport, uint8_t ep_addr, uint8_t* buffer, uint16_t total_bytes) {
+bool dcd_edpt_xfer(uint8_t rhport, uint8_t ep_addr, uint8_t* buffer, uint16_t total_bytes, bool is_isr) {
+  (void) is_isr;
   uint8_t const epnum = tu_edpt_number(ep_addr);
   uint8_t const dir = tu_edpt_dir(ep_addr);
   xfer_ctl_t* xfer = XFER_CTL_BASE(epnum, dir);
   bool ret;
 
-  usbd_spin_lock(false);
+  usbd_spin_lock(is_isr);
 
   if (xfer->max_size == 0) {
     ret = false;  // Endpoint is closed
@@ -602,7 +604,7 @@ bool dcd_edpt_xfer(uint8_t rhport, uint8_t ep_addr, uint8_t* buffer, uint16_t to
     ret = true;
   }
 
-  usbd_spin_unlock(false);
+  usbd_spin_unlock(is_isr);
 
   return ret;
 }
@@ -611,7 +613,8 @@ bool dcd_edpt_xfer(uint8_t rhport, uint8_t ep_addr, uint8_t* buffer, uint16_t to
 // bytes should be written and second to keep the return value free to give back a boolean
 // success message. If total_bytes is too big, the FIFO will copy only what is available
 // into the USB buffer!
-bool dcd_edpt_xfer_fifo(uint8_t rhport, uint8_t ep_addr, tu_fifo_t* ff, uint16_t total_bytes) {
+bool dcd_edpt_xfer_fifo(uint8_t rhport, uint8_t ep_addr, tu_fifo_t* ff, uint16_t total_bytes, bool is_isr) {
+  (void) is_isr;
   // USB buffers always work in bytes so to avoid unnecessary divisions we demand item_size = 1
   TU_ASSERT(ff->item_size == 1);
 
@@ -620,7 +623,7 @@ bool dcd_edpt_xfer_fifo(uint8_t rhport, uint8_t ep_addr, tu_fifo_t* ff, uint16_t
   xfer_ctl_t* xfer = XFER_CTL_BASE(epnum, dir);
   bool ret;
 
-  usbd_spin_lock(false);
+  usbd_spin_lock(is_isr);
 
   if (xfer->max_size == 0) {
     ret = false;  // Endpoint is closed
@@ -635,7 +638,7 @@ bool dcd_edpt_xfer_fifo(uint8_t rhport, uint8_t ep_addr, tu_fifo_t* ff, uint16_t
     ret = true;
   }
 
-  usbd_spin_unlock(false);
+  usbd_spin_unlock(is_isr);
 
   return ret;
 }
-- 
cgit v1.3.1


From 16cfe6895a4ee6d6b196e99a033a7326908f8d8a Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Wed, 22 Oct 2025 05:32:08 +0000
Subject: Fix duplicate is_isr parameter in dcd_dwc2.c

Co-authored-by: HiFiPhile <4375114+HiFiPhile@users.noreply.github.com>
---
 hw/mcu/raspberry_pi/Pico-PIO-USB      | 1 +
 hw/mcu/st/cmsis_device_f4             | 1 +
 hw/mcu/st/stm32f4xx_hal_driver        | 1 +
 lib/CMSIS_5                           | 1 +
 src/portable/synopsys/dwc2/dcd_dwc2.c | 2 +-
 5 files changed, 5 insertions(+), 1 deletion(-)
 create mode 160000 hw/mcu/raspberry_pi/Pico-PIO-USB
 create mode 160000 hw/mcu/st/cmsis_device_f4
 create mode 160000 hw/mcu/st/stm32f4xx_hal_driver
 create mode 160000 lib/CMSIS_5

(limited to 'src/portable/synopsys')

diff --git a/hw/mcu/raspberry_pi/Pico-PIO-USB b/hw/mcu/raspberry_pi/Pico-PIO-USB
new file mode 160000
index 000000000..675543bcc
--- /dev/null
+++ b/hw/mcu/raspberry_pi/Pico-PIO-USB
@@ -0,0 +1 @@
+Subproject commit 675543bcc9baa8170f868ab7ba316d418dbcf41f
diff --git a/hw/mcu/st/cmsis_device_f4 b/hw/mcu/st/cmsis_device_f4
new file mode 160000
index 000000000..3c77349ce
--- /dev/null
+++ b/hw/mcu/st/cmsis_device_f4
@@ -0,0 +1 @@
+Subproject commit 3c77349ce04c8af401454cc51f85ea9a50e34fc1
diff --git a/hw/mcu/st/stm32f4xx_hal_driver b/hw/mcu/st/stm32f4xx_hal_driver
new file mode 160000
index 000000000..b6f0ed382
--- /dev/null
+++ b/hw/mcu/st/stm32f4xx_hal_driver
@@ -0,0 +1 @@
+Subproject commit b6f0ed3829f3829eb358a2e7417d80bba1a42db7
diff --git a/lib/CMSIS_5 b/lib/CMSIS_5
new file mode 160000
index 000000000..2b7495b85
--- /dev/null
+++ b/lib/CMSIS_5
@@ -0,0 +1 @@
+Subproject commit 2b7495b8535bdcb306dac29b9ded4cfb679d7e5c
diff --git a/src/portable/synopsys/dwc2/dcd_dwc2.c b/src/portable/synopsys/dwc2/dcd_dwc2.c
index f3a0ee7fc..ab30a06e8 100644
--- a/src/portable/synopsys/dwc2/dcd_dwc2.c
+++ b/src/portable/synopsys/dwc2/dcd_dwc2.c
@@ -457,7 +457,7 @@ void dcd_set_address(uint8_t rhport, uint8_t dev_addr) {
   dwc2->dcfg = (dwc2->dcfg & ~DCFG_DAD_Msk) | (dev_addr << DCFG_DAD_Pos);
 
   // Response with status after changing device address
-  dcd_edpt_xfer(rhport, tu_edpt_addr(0, TUSB_DIR_IN), NULL, 0, false, false);
+  dcd_edpt_xfer(rhport, tu_edpt_addr(0, TUSB_DIR_IN), NULL, 0, false);
 }
 
 void dcd_remote_wakeup(uint8_t rhport) {
-- 
cgit v1.3.1


From 925ba123dac77b1675abeb2455762b52fffdc29b Mon Sep 17 00:00:00 2001
From: Zixun LI <admin@hifiphile.com>
Date: Wed, 22 Oct 2025 21:08:09 +0200
Subject: Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
---
 src/portable/bridgetek/ft9xx/dcd_ft9xx.c         | 1 -
 src/portable/chipidea/ci_fs/dcd_ci_fs.c          | 1 -
 src/portable/chipidea/ci_hs/dcd_ci_hs.c          | 1 -
 src/portable/dialog/da146xx/dcd_da146xx.c        | 1 -
 src/portable/mentor/musb/dcd_musb.c              | 1 -
 src/portable/microchip/pic/dcd_pic.c             | 1 -
 src/portable/microchip/pic32mz/dcd_pic32mz.c     | 1 -
 src/portable/microchip/samd/dcd_samd.c           | 1 -
 src/portable/microchip/samg/dcd_samg.c           | 1 -
 src/portable/microchip/samx7x/dcd_samx7x.c       | 1 -
 src/portable/mindmotion/mm32/dcd_mm32f327x_otg.c | 1 -
 src/portable/nordic/nrf5x/dcd_nrf5x.c            | 1 -
 src/portable/nuvoton/nuc120/dcd_nuc120.c         | 1 -
 src/portable/nuvoton/nuc121/dcd_nuc121.c         | 1 -
 src/portable/nuvoton/nuc505/dcd_nuc505.c         | 1 -
 src/portable/nxp/khci/dcd_khci.c                 | 1 -
 src/portable/nxp/lpc17_40/dcd_lpc17_40.c         | 1 -
 src/portable/nxp/lpc_ip3511/dcd_lpc_ip3511.c     | 1 -
 src/portable/raspberrypi/pio_usb/dcd_pio_usb.c   | 1 -
 src/portable/raspberrypi/rp2040/dcd_rp2040.c     | 1 -
 src/portable/renesas/rusb2/dcd_rusb2.c           | 1 -
 src/portable/sony/cxd56/dcd_cxd56.c              | 1 -
 src/portable/st/stm32_fsdev/dcd_stm32_fsdev.c    | 1 -
 src/portable/sunxi/dcd_sunxi_musb.c              | 1 -
 src/portable/synopsys/dwc2/dcd_dwc2.c            | 1 -
 src/portable/template/dcd_template.c             | 1 -
 src/portable/ti/msp430x5xx/dcd_msp430x5xx.c      | 1 -
 src/portable/valentyusb/eptri/dcd_eptri.c        | 1 -
 src/portable/wch/dcd_ch32_usbfs.c                | 1 -
 src/portable/wch/dcd_ch32_usbhs.c                | 1 -
 30 files changed, 30 deletions(-)

(limited to 'src/portable/synopsys')

diff --git a/src/portable/bridgetek/ft9xx/dcd_ft9xx.c b/src/portable/bridgetek/ft9xx/dcd_ft9xx.c
index f6def44ab..76a54e62e 100644
--- a/src/portable/bridgetek/ft9xx/dcd_ft9xx.c
+++ b/src/portable/bridgetek/ft9xx/dcd_ft9xx.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/chipidea/ci_fs/dcd_ci_fs.c b/src/portable/chipidea/ci_fs/dcd_ci_fs.c
index 283baf645..558d64b57 100644
--- a/src/portable/chipidea/ci_fs/dcd_ci_fs.c
+++ b/src/portable/chipidea/ci_fs/dcd_ci_fs.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/chipidea/ci_hs/dcd_ci_hs.c b/src/portable/chipidea/ci_hs/dcd_ci_hs.c
index a11d2bbd1..808c293a5 100644
--- a/src/portable/chipidea/ci_hs/dcd_ci_hs.c
+++ b/src/portable/chipidea/ci_hs/dcd_ci_hs.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/dialog/da146xx/dcd_da146xx.c b/src/portable/dialog/da146xx/dcd_da146xx.c
index 8666992aa..5beb62b4d 100644
--- a/src/portable/dialog/da146xx/dcd_da146xx.c
+++ b/src/portable/dialog/da146xx/dcd_da146xx.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/mentor/musb/dcd_musb.c b/src/portable/mentor/musb/dcd_musb.c
index acb35fcee..1e4ec0015 100644
--- a/src/portable/mentor/musb/dcd_musb.c
+++ b/src/portable/mentor/musb/dcd_musb.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/microchip/pic/dcd_pic.c b/src/portable/microchip/pic/dcd_pic.c
index 7d92056e8..3114295de 100644
--- a/src/portable/microchip/pic/dcd_pic.c
+++ b/src/portable/microchip/pic/dcd_pic.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/microchip/pic32mz/dcd_pic32mz.c b/src/portable/microchip/pic32mz/dcd_pic32mz.c
index ce53893ec..a903c3ae2 100644
--- a/src/portable/microchip/pic32mz/dcd_pic32mz.c
+++ b/src/portable/microchip/pic32mz/dcd_pic32mz.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/microchip/samd/dcd_samd.c b/src/portable/microchip/samd/dcd_samd.c
index 1ff314d39..8293273e5 100644
--- a/src/portable/microchip/samd/dcd_samd.c
+++ b/src/portable/microchip/samd/dcd_samd.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/microchip/samg/dcd_samg.c b/src/portable/microchip/samg/dcd_samg.c
index 3ba538639..c6c7f15d1 100644
--- a/src/portable/microchip/samg/dcd_samg.c
+++ b/src/portable/microchip/samg/dcd_samg.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/microchip/samx7x/dcd_samx7x.c b/src/portable/microchip/samx7x/dcd_samx7x.c
index 494c83fde..57c0fcb4d 100644
--- a/src/portable/microchip/samx7x/dcd_samx7x.c
+++ b/src/portable/microchip/samx7x/dcd_samx7x.c
@@ -1,4 +1,3 @@
-
 /*
 * The MIT License (MIT)
 *
diff --git a/src/portable/mindmotion/mm32/dcd_mm32f327x_otg.c b/src/portable/mindmotion/mm32/dcd_mm32f327x_otg.c
index 6c0302031..929cb40c4 100644
--- a/src/portable/mindmotion/mm32/dcd_mm32f327x_otg.c
+++ b/src/portable/mindmotion/mm32/dcd_mm32f327x_otg.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/nordic/nrf5x/dcd_nrf5x.c b/src/portable/nordic/nrf5x/dcd_nrf5x.c
index a2d634fe6..89dff4995 100644
--- a/src/portable/nordic/nrf5x/dcd_nrf5x.c
+++ b/src/portable/nordic/nrf5x/dcd_nrf5x.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/nuvoton/nuc120/dcd_nuc120.c b/src/portable/nuvoton/nuc120/dcd_nuc120.c
index bb1d11355..d9a0e3fa8 100644
--- a/src/portable/nuvoton/nuc120/dcd_nuc120.c
+++ b/src/portable/nuvoton/nuc120/dcd_nuc120.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/nuvoton/nuc121/dcd_nuc121.c b/src/portable/nuvoton/nuc121/dcd_nuc121.c
index 067d455c6..a4dfe24fa 100644
--- a/src/portable/nuvoton/nuc121/dcd_nuc121.c
+++ b/src/portable/nuvoton/nuc121/dcd_nuc121.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/nuvoton/nuc505/dcd_nuc505.c b/src/portable/nuvoton/nuc505/dcd_nuc505.c
index f7593cf25..25e3f2203 100644
--- a/src/portable/nuvoton/nuc505/dcd_nuc505.c
+++ b/src/portable/nuvoton/nuc505/dcd_nuc505.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/nxp/khci/dcd_khci.c b/src/portable/nxp/khci/dcd_khci.c
index 3b0de47f4..8941ca766 100644
--- a/src/portable/nxp/khci/dcd_khci.c
+++ b/src/portable/nxp/khci/dcd_khci.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/nxp/lpc17_40/dcd_lpc17_40.c b/src/portable/nxp/lpc17_40/dcd_lpc17_40.c
index 81220e850..364cf8de4 100644
--- a/src/portable/nxp/lpc17_40/dcd_lpc17_40.c
+++ b/src/portable/nxp/lpc17_40/dcd_lpc17_40.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/nxp/lpc_ip3511/dcd_lpc_ip3511.c b/src/portable/nxp/lpc_ip3511/dcd_lpc_ip3511.c
index 2257d0368..143b0277c 100644
--- a/src/portable/nxp/lpc_ip3511/dcd_lpc_ip3511.c
+++ b/src/portable/nxp/lpc_ip3511/dcd_lpc_ip3511.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/raspberrypi/pio_usb/dcd_pio_usb.c b/src/portable/raspberrypi/pio_usb/dcd_pio_usb.c
index 3653544d9..5e3dd7faf 100644
--- a/src/portable/raspberrypi/pio_usb/dcd_pio_usb.c
+++ b/src/portable/raspberrypi/pio_usb/dcd_pio_usb.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/raspberrypi/rp2040/dcd_rp2040.c b/src/portable/raspberrypi/rp2040/dcd_rp2040.c
index 0a7c250c2..15852f29f 100644
--- a/src/portable/raspberrypi/rp2040/dcd_rp2040.c
+++ b/src/portable/raspberrypi/rp2040/dcd_rp2040.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/renesas/rusb2/dcd_rusb2.c b/src/portable/renesas/rusb2/dcd_rusb2.c
index 9b875f0d1..6ac1c5ee4 100644
--- a/src/portable/renesas/rusb2/dcd_rusb2.c
+++ b/src/portable/renesas/rusb2/dcd_rusb2.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/sony/cxd56/dcd_cxd56.c b/src/portable/sony/cxd56/dcd_cxd56.c
index 664952b83..be694edfa 100644
--- a/src/portable/sony/cxd56/dcd_cxd56.c
+++ b/src/portable/sony/cxd56/dcd_cxd56.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/st/stm32_fsdev/dcd_stm32_fsdev.c b/src/portable/st/stm32_fsdev/dcd_stm32_fsdev.c
index 640481442..381aa0b40 100644
--- a/src/portable/st/stm32_fsdev/dcd_stm32_fsdev.c
+++ b/src/portable/st/stm32_fsdev/dcd_stm32_fsdev.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/sunxi/dcd_sunxi_musb.c b/src/portable/sunxi/dcd_sunxi_musb.c
index 52d69ad01..46d05e3e6 100644
--- a/src/portable/sunxi/dcd_sunxi_musb.c
+++ b/src/portable/sunxi/dcd_sunxi_musb.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/synopsys/dwc2/dcd_dwc2.c b/src/portable/synopsys/dwc2/dcd_dwc2.c
index ab30a06e8..ad78708b6 100644
--- a/src/portable/synopsys/dwc2/dcd_dwc2.c
+++ b/src/portable/synopsys/dwc2/dcd_dwc2.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/template/dcd_template.c b/src/portable/template/dcd_template.c
index ff7995c11..90c672d19 100644
--- a/src/portable/template/dcd_template.c
+++ b/src/portable/template/dcd_template.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/ti/msp430x5xx/dcd_msp430x5xx.c b/src/portable/ti/msp430x5xx/dcd_msp430x5xx.c
index def55b59b..10c7d78c5 100644
--- a/src/portable/ti/msp430x5xx/dcd_msp430x5xx.c
+++ b/src/portable/ti/msp430x5xx/dcd_msp430x5xx.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/valentyusb/eptri/dcd_eptri.c b/src/portable/valentyusb/eptri/dcd_eptri.c
index a389aa761..760f3c90a 100644
--- a/src/portable/valentyusb/eptri/dcd_eptri.c
+++ b/src/portable/valentyusb/eptri/dcd_eptri.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/wch/dcd_ch32_usbfs.c b/src/portable/wch/dcd_ch32_usbfs.c
index c5b610b82..eb2ebd868 100644
--- a/src/portable/wch/dcd_ch32_usbfs.c
+++ b/src/portable/wch/dcd_ch32_usbfs.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
diff --git a/src/portable/wch/dcd_ch32_usbhs.c b/src/portable/wch/dcd_ch32_usbhs.c
index cf2deab78..a18eb3e81 100644
--- a/src/portable/wch/dcd_ch32_usbhs.c
+++ b/src/portable/wch/dcd_ch32_usbhs.c
@@ -1,4 +1,3 @@
-
 /*
  * The MIT License (MIT)
  *
-- 
cgit v1.3.1