From 21d7332d5884e0abbf9e3f3762deefa589564783 Mon Sep 17 00:00:00 2001 From: hathach Date: Thu, 20 Aug 2026 17:43:44 +0700 Subject: hil, docs: reference toolchains by their official env vars, not one rig's paths ~/code/pico/pico-sdk and $HOME/code/esp-idf/export.sh are the ci rig's private layout; written into instructions they silently stop being true on tusb, a dev PC, or any future rig. The docs now use the variables the vendors define -- PICO_SDK_PATH for the Pico SDK and IDF_PATH for ESP-IDF, activated explicitly as `. "$IDF_PATH/export.sh"` -- and leave where the checkouts live to each host's profile. The variables are only useful if the shells that agents actually get can see them, and `ssh 'cmd'` is non-interactive AND non-login: it reads no profile, and Debian's sshd-sourced ~/.bashrc returns at the interactive guard before most of the file. The ci rig already keeps its exports in the section ABOVE that early-return; IDF_PATH now sits there beside PICO_SDK_PATH, and the whole chain is verified from a plain non-interactive ssh: both variables visible, `. "$IDF_PATH/export.sh"` activates ESP-IDF v5.5.3 with idf.py on PATH -- no login shell, no alias, no hard-coded path. hil-pool-check documents that placement so the next rig is set up the same way. --- test/hil/helper/hil_pool_check.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'test') diff --git a/test/hil/helper/hil_pool_check.py b/test/hil/helper/hil_pool_check.py index 8ad68bc6d..d926bbe3d 100644 --- a/test/hil/helper/hil_pool_check.py +++ b/test/hil/helper/hil_pool_check.py @@ -329,7 +329,7 @@ def flash(board: dict, fw, allow_recovery: bool, probe_port: str, note: list) -> return True if rc == 127: # flasher binary missing: retries/probe recovery can't fix env note.append(f'flasher tool missing ({err}) — esptool needs the ESP-IDF env ' - f'(. $HOME/code/esp-idf/export.sh)' + f'(. "$IDF_PATH/export.sh")' if board['flasher']['name'].lower() == 'esptool' else f'flasher tool missing: {err}') return False @@ -489,7 +489,7 @@ def ensure_fw(board: dict, variant: str, example: str, note: list): if rc == 127 and board['flasher']['name'].lower() == 'esptool': _builds[key] = (None, 'no-env') note.append(f'cannot build {base}: ESP-IDF env missing ' - f'(source $HOME/code/esp-idf/export.sh)') + f'(. "$IDF_PATH/export.sh")') return None if rc == 124: # hung build: a deps/cache retry cannot cure it, don't double the stall _builds[key] = (None, 'timeout') -- cgit v1.3.1