u-boot.git/api/api_storage.c, branch v2017.05-rc3

Apparent conflict between CONFIG_BLK and CONFIG_API

2017-04-08T13:26:48+00:00

Good evening,

I am trying to port FreeBSD to the ASUS Tinker Board, a computer based
on the Rockchip 3288 SoC. FreeBSD's boot loader (named loader(8)) needs
CONFIG_API to be enabled, but trying to build an U-Boot from trunk with
both CONFIG_API and CONFIG_BLK (as required for Rockchip SoC's?) leads
to the following build failure:

$ CROSS_COMPILE=arm-none-eabi- gmake tinker-rk3288_defconfig all
...
  CC      api/api_storage.o
api/api_storage.c: In function 'dev_read_stor':
api/api_storage.c:334:9: error: 'struct blk_desc' has no member named 'block_read'
  if ((dd->block_read) == NULL) {
         ^~
api/api_storage.c:339:11: error: 'struct blk_desc' has no member named 'block_read'
  return dd->block_read(dd, start, len, buf);
           ^~
api/api_storage.c:340:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
gmake[2]: *** [scripts/Makefile.build:281: api/api_storage.o] Fehler 1
gmake[1]: *** [Makefile:1229: api] Fehler 2
gmake: *** [Makefile:460: __build_one_by_one] Error 2

I applied the following fix, but the product doesn't boot. Perhaps
that's not a property of the fix though:

Yours,
Robert Clausecker

api: storage: Test all block device in dev_stor_get

2017-01-20T20:37:58+00:00

In a config with one MMC at device id '1' and no MMC at device id '0'
(a BeagleBone Black with no sd inserted for example), the current code
will first test to access the MMC 0 (sd port), seeing that no device is
present it will simply return that no more device are present for this
class.
This patch fixes this by testing all devices for each class.

Signed-off-by: Emmanuel Vadot

Cosmetic api: api_storage.c Spelling correction

2016-12-04T18:54:58+00:00

Make spelling correction for 'from'

Signed-off-by: Walt Feasel

Cosmetic api: api_storage.c Comment style

2016-12-04T18:54:58+00:00

Make comment style modifications

Signed-off-by: Walt Feasel

Cosmetic api: api_storage.c Line over 80 char

2016-12-04T18:54:57+00:00

Make checkpatch style modification for
WARNING: line over 80 characters

Signed-off-by: Walt Feasel

Cosmetic api: api_storage.c Blank line after {

2016-12-04T18:54:57+00:00

Make checkpatch style modification for
CHECK: Blank lines aren't necessary after
an open brace '{'

Signed-off-by: Walt Feasel

Cosmetic api: api_storage.c Align parenthesis

2016-12-04T18:54:57+00:00

Make checkpatch style modification for
CHECK: Alignment should match open parenthesis

Signed-off-by: Walt Feasel

api: storage: Avoid enumeration for non-configured subsystem

2016-10-24T12:04:43+00:00

If a subsystem wasn't configured, avoid enumeration.

Signed-off-by: Emmanuel Vadot

dm: scsi: Rename CONFIG_CMD_SCSI to CONFIG_SCSI

2016-05-17T15:54:43+00:00

This option currently enables both the command and the SCSI functionality.
Rename the existing option to CONFIG_SCSI since most of the code relates
to the feature.

Signed-off-by: Simon Glass

dm: blk: Rename get_dev() to blk_get_dev()

2016-03-14T21:34:50+00:00

The current name is too generic. Add a 'blk_' prefix to aid searching and
make its purpose clearer.

Signed-off-by: Simon Glass 
Reviewed-by: Bin Meng 
Tested-by: Stephen Warren