u-boot.git/board/digsy_mtc/cmd_mtc.c, branch v2011.06

cmd_usage(): simplify return code handling

2010-07-24T18:43:57Z

Lots of code use this construct: cmd_usage(cmdtp); return 1; Change cmd_usage() let it return 1 - then we can replace all these ocurrances by return cmd_usage(cmdtp); This fixes a few places with incorrect return code handling, too. Signed-off-by: Wolfgang Denk

Make sure that argv[] argument pointers are not modified.

2010-07-04T21:55:42Z

The hush shell dynamically allocates (and re-allocates) memory for the argument strings in the "char *argv[]" argument vector passed to commands. Any code that modifies these pointers will cause serious corruption of the malloc data structures and crash U-Boot, so make sure the compiler can check that no such modifications are being done by changing the code into "char * const argv[]". This modification is the result of debugging a strange crash caused after adding a new command, which used the following argument processing code which has been working perfectly fine in all Unix systems since version 6 - but not so in U-Boot: int main (int argc, char **argv) { while (--argc > 0 && **++argv == '-') { /* ====> */ while (*++*argv) { switch (**argv) { case 'd': debug++; break; ... default: usage (); } } } ... } The line marked "====>" will corrupt the malloc data structures and usually cause U-Boot to crash when the next command gets executed by the shell. With the modification, the compiler will prevent this with an error: increment of read-only location '*argv' N.B.: The code above can be trivially rewritten like this: while (--argc > 0 && **++argv == '-') { char *arg = *argv; while (*++arg) { switch (*arg) { ... Signed-off-by: Wolfgang Denk Acked-by: Mike Frysinger

ppc: Remove board-specific command table relocation fixups

2009-10-03T08:17:56Z

Signed-off-by: Peter Tyser

digsy_mtc: Add delay in SPI transfers to the companion controller.

2009-08-09T21:01:07Z

While at it, remove initialization of variables which will be set before usage in all cases. Signed-off-by: Detlev Zundel

digsy_mtc: minor fixes for mtc command help

2009-08-09T21:00:08Z

Add mtc state subcommand description to the help of mtc command. Remove some newlines in description of commands for proper help formating. Signed-off-by: Anatolij Gustschin

digsy_mtc: Add mtc state command.

2009-08-09T20:59:27Z

Signed-off-by: Grzegorz Bernacki

Coding style cleanup; update CHANGELOG

2009-07-07T20:35:02Z

Signed-off-by: Wolfgang Denk

digsy MTC: Add 'mtc' command.

2009-06-14T21:04:37Z

New command allows to: o check FW version o set LED status o set digital output status o get digital input status Signed-off-by: Grzegorz Bernacki