u-boot.git/boot/bootflow.c, branch v2024.01

bootstd: Avoid freeing a non-allocated buffer

2023-11-17T16:58:26+00:00

EFI applications can be very large and thus used to cause boot failures
when malloc() space was exhausted.

A recent changed fixed this by using the kernel_addr_r environment var
as the address of the buffer. However, it still frees the buffer when
the bootflow is discarded.

Fix this by introducing a flag to indicate whether the buffer was
allocated, or not.

Note that kernel_addr_r is not the last word here. It might be better
to use lmb to place images. But there is a lot of refactoring to do
before we can remove the environment variables. The distro scripts rely
on them so it is safe for bootstd to do so too.

Fixes: 6a8c2f9781c bootstd: Avoid allocating memory for the EFI file

Signed-off-by: Simon Glass 
Reported by: Simon Glass 
Reported by: Shantur Rathore 
Reviewed-by: Heinrich Schuchardt 
Tested-by: Shantur Rathore

bootstd: Handle a few special cases in cmdline_set_arg()

2023-11-01T16:26:44+00:00

Two bugs have appeared:

- arguments can have an equals sign embedded in them, which must be
  considered part of the value
- arguments must fully match the name; partial matches should be
  ignored

Fix these and add a test to cover both.

Signed-off-by: Simon Glass

bootstd: Scan all bootdevs in a boot_targets entry (take 2)

2023-10-23T17:05:13+00:00

When the boot_targets environment variable is used with the distro-boot
scripts, each device is included individually. For example, if there
are three mmc devices, then we will have something like:

   boot_targets="mmc0 mmc1 mmc2"

In contrast, standard boot supports specifying just the uclass, i.e.:

   boot_targets="mmc"

The intention is that this should scan all MMC devices, but in fact it
currently only scans the first.

Update the logic to handle this case, without required BOOTSTD_FULL to
be enabled.

Signed-off-by: Simon Glass 
Reported-by: Date Huang 
Reported-by: Vincent Stehlé 
Reported-by: Ivan Ivanov 
Tested-by: Ivan T.Ivanov

bootstd: Correct logic for single uclass

2023-10-23T17:05:13+00:00

The current logic for "bootflow mmc" is flawed since it checks the
uclass of the bootdev instead of its parent, the media device. Correct
this and add a test that covers this scenario.

Signed-off-by: Simon Glass 
Tested-by: Ivan T.Ivanov

Revert "bootstd: Scan all bootdevs in a boot_targets entry"

2023-10-23T17:05:13+00:00

This commit was intended to allow all bootdevs in each boot_targets
entry to be scanned. However it causes bad ordering with bootdevs, e.g.
scanning Ethernet bootdevs when it should be keeping to mmc.

Revert it so we can try another approach.

This reverts commit e824d0d0c219bc6da767f13f90c5b00eefe929f0.

Signed-off-by: Simon Glass 
Tested-by: Ivan T.Ivanov

bootstd: Scan all bootdevs in a boot_targets entry

2023-10-13T17:15:41+00:00

When the boot_targets environment variable is used with the distro-boot
scripts, each device is included individually. For example, if there
are three mmc devices, then we will have something like:

   boot_targets="mmc0 mmc1 mmc2"

In contrast, standard boot supports specifying just the uclass, i.e.:

   boot_targets="mmc"

The intention is that this should scan all MMC devices, but in fact it
currently only scans the first.

Update the logic to handle this case, without required BOOTSTD_FULL to
be enabled.

I believe at least three people reported this, but I found two.

Signed-off-by: Simon Glass 
Reported-by: Date Huang 
Reported-by: Vincent Stehlé

bootstd: Add a command to read all files for a bootflow

2023-08-11T13:33:38+00:00

Some bootflows (such as EFI and ChromiumOS) delay reading the kernel until
it is needed to boot. This saves time when scanning and avoids needing to
allocate memory for something that may never be used.

To permit reading of these files, add a new 'bootflow read' command.

Signed-off-by: Simon Glass

bootstd: Add private bootmeth data to the bootflow

2023-08-11T00:34:54+00:00

Some bootmeths need to store their own information related to the
bootflow, in addition to the generic information in struct bootflow.
Add a pointer for this.

Signed-off-by: Simon Glass

bootstd: Support automatically setting Linux parameters

2023-07-17T05:38:35+00:00

Some Linux parameters can be set automatically by U-Boot, if it knows the
device being used. For example, since U-Boot knows the serial console
being used, it can add parameters for earlycon and console.

Add support for this.

Note that this is an experimental feature and we will see how useful it
turns out to be. It is very handy for ChromeOS, since otherwise it is very
difficult to manually determine the UART address or port number,
particularly in a script.

Provide an example of how this is used with ChromeOS.

Signed-off-by: Simon Glass 
Reviewed-by: Bin Meng

bootstd: Add support for updating elements of the cmdline

2023-07-17T05:38:35+00:00

Add a bootflow command to update the command line more easily. This allows
changing a particular parameter rather than editing a very long strings.
It is also easier to handle with scripting.

The new 'bootflow cmdline' command allows getting and setting single
parameters.

Fix up the example output while we are here, since there are a few new
items.

Signed-off-by: Simon Glass 
Reviewed-by: Bin Meng