u-boot.git/cmd/bcb.c, branch next

global: Avoid indirect inclusion of from

2025-05-29T14:29:16+00:00

The include file  does not need anything from .
Furthermore, include/env.h itself includes other headers which can lead
to longer indirect inclusion paths. To prepare to remove  from
 fix all of the places which had relied on this indirect
inclusion to instead include  directly.

Reviewed-by: Mattijs Korpershoek  # android, bcb
Reviewed-by: Jerome Forissier  # spawn
Signed-off-by: Tom Rini

cmd: bcb: introduce 'ab_dump' command to print BCB block content

2024-10-24T07:45:55+00:00

It's really helpful to have the ability to dump BCB block for debugging
A/B logic on the board supported this partition schema.

Command 'bcb ab_dump' prints all fields of bootloader_control struct
including slot_metadata for all presented slots.

Output example:
=====
> board# bcb ab_dump ubi 0#misc
> Read 512 bytes from volume misc to 000000000bf07580
> Read 512 bytes from volume misc to 000000000bf42f40
> Bootloader Control:       [misc]
> Active Slot:              _a
> Magic Number:             0x42414342
> Version:                  1
> Number of Slots:          2
> Recovery Tries Remaining: 0
> CRC:                      0x2c8b50bc (Valid)
>
> Slot[0] Metadata:
> 	- Priority:         15
> 	- Tries Remaining:  0
> 	- Successful Boot:  1
> 	- Verity Corrupted: 0
>
> Slot[1] Metadata:
> 	- Priority:         14
> 	- Tries Remaining:  7
> 	- Successful Boot:  0
> 	- Verity Corrupted: 0
====

The ab_dump command allows you to display ABC data directly on the
U-Boot console. During an A/B test execution, this test verifies the
accuracy of each field within the ABC data.

Signed-off-by: Dmitry Rokosov 
Reviewed-by: Mattijs Korpershoek 
Tested-by: Mattijs Korpershoek  # vim3_android
Link: https://lore.kernel.org/r/20241017-android_ab_master-v5-5-43bfcc096d95@salutedevices.com
Signed-off-by: Mattijs Korpershoek

cmd: bcb: change strcmp() usage style in the do_bcb_ab_select()

2024-10-24T07:45:55+00:00

In the entire cmd/bcb.c file, the return value of strcmp() is not
directly compared to 0. Therefore, it would be better to maintain this
style in the new do_bcb_ab_select() function as well.

Reviewed-by: Mattijs Korpershoek 
Reviewed-by: Simon Glass 
Tested-by: Guillaume La Roque 
Signed-off-by: Dmitry Rokosov 
Tested-by: Mattijs Korpershoek  # vim3_android
Link: https://lore.kernel.org/r/20241017-android_ab_master-v5-4-43bfcc096d95@salutedevices.com
Signed-off-by: Mattijs Korpershoek

treewide: bcb: move ab_select command to bcb subcommands

2024-10-24T07:45:55+00:00

To enhance code organization, it is beneficial to consolidate all A/B
BCB management routines into a single super-command.
The 'bcb' command is an excellent candidate for this purpose.

This patch integrates the separate 'ab_select' command into the 'bcb'
group as the 'ab_select' subcommand, maintaining the same parameter list
for consistency.

Signed-off-by: Dmitry Rokosov 
Reviewed-by: Mattijs Korpershoek 
Tested-by: Mattijs Korpershoek  # vim3_android
Link: https://lore.kernel.org/r/20241017-android_ab_master-v5-3-43bfcc096d95@salutedevices.com
Signed-off-by: Mattijs Korpershoek

cmd: bcb: rework the command to U_BOOT_LONGHELP approach

2024-10-24T07:45:55+00:00

U_BOOT_LONGHELP and U_BOOT_CMD_WITH_SUBCMDS offer numerous advantages,
including:
- common argument restrictions checking
- automatic subcommand matching
- improved usage and help handling

By utilizing the U_BOOT_LONGHELP approach, we can reduce the amount of
command management code and describe commands more succinctly.

Signed-off-by: Dmitry Rokosov 
Reviewed-by: Mattijs Korpershoek 
Tested-by: Mattijs Korpershoek  # vim3_android
Link: https://lore.kernel.org/r/20241017-android_ab_master-v5-2-43bfcc096d95@salutedevices.com
Signed-off-by: Mattijs Korpershoek

cmd: bcb: Fix segfault on invalid block device

2024-08-22T07:23:33+00:00

When blk_get_dev() fails, block NULL and gets de-referenced in
the error path by a printf(), resulting in a crash.

This can be reproduced on sandbox with:

$ ./u-boot --command "bcb load mmc 0 0"

Fix the message by using the functions arguments (iface, devnum)
instead.

Note: partition (being a global static initialized) can be used safely.

This issue has been reported by coverity [1]

[1] https://lore.kernel.org/all/20240723141844.GF989285@bill-the-cat/

Fixes: dfeb4f0d7935 ("cmd: bcb: extend BCB C API to allow read/write the fields")
Reviewed-by: Dmitrii Merkurev 
Link: https://lore.kernel.org/r/20240724-bcb-crash-v1-1-44caff15bce4@baylibre.com
Signed-off-by: Mattijs Korpershoek

Restore patch series "arm: dts: am62-beagleplay: Fix Beagleplay Ethernet"

2024-05-20T19:35:03+00:00

As part of bringing the master branch back in to next, we need to allow
for all of these changes to exist here.

Reported-by: Jonas Karlman 
Signed-off-by: Tom Rini

Revert "Merge patch series "arm: dts: am62-beagleplay: Fix Beagleplay Ethernet""

2024-05-19T14:16:36+00:00

When bringing in the series 'arm: dts: am62-beagleplay: Fix Beagleplay
Ethernet"' I failed to notice that b4 noticed it was based on next and
so took that as the base commit and merged that part of next to master.

This reverts commit c8ffd1356d42223cbb8c86280a083cc3c93e6426, reversing
changes made to 2ee6f3a5f7550de3599faef9704e166e5dcace35.

Reported-by: Jonas Karlman 
Signed-off-by: Tom Rini

cmd: Remove and add needed includes

2024-05-06T21:05:04+00:00

Remove  from all "cmd/" files and when needed add
missing include files directly.

Signed-off-by: Tom Rini

cmd: bcb: extend BCB C API to allow read/write the fields

2023-11-16T23:59:58+00:00

Currently BCB C API only allows to modify 'command' BCB field.
Extend it so that we can also read and modify all the available
BCB fields (command, status, recovery, stage).

Co-developed-by: Cody Schuffelen 
Signed-off-by: Cody Schuffelen 
Signed-off-by: Dmitrii Merkurev 
Cc: Eugeniu Rosca 
Cc: Ying-Chun Liu (PaulLiu) 
Cc: Simon Glass 
Cc: Mattijs Korpershoek 
Cc: Sean Anderson 
Cc: Cody Schuffelen 
Tested-by: Mattijs Korpershoek  # on vim3
Reviewed-by: Mattijs Korpershoek