u-boot.git/cmd/bcb.c, branch v2024.10

cmd: bcb: Fix segfault on invalid block device

2024-08-22T07:23:33+00:00

When blk_get_dev() fails, block NULL and gets de-referenced in
the error path by a printf(), resulting in a crash.

This can be reproduced on sandbox with:

$ ./u-boot --command "bcb load mmc 0 0"

Fix the message by using the functions arguments (iface, devnum)
instead.

Note: partition (being a global static initialized) can be used safely.

This issue has been reported by coverity [1]

[1] https://lore.kernel.org/all/20240723141844.GF989285@bill-the-cat/

Fixes: dfeb4f0d7935 ("cmd: bcb: extend BCB C API to allow read/write the fields")
Reviewed-by: Dmitrii Merkurev 
Link: https://lore.kernel.org/r/20240724-bcb-crash-v1-1-44caff15bce4@baylibre.com
Signed-off-by: Mattijs Korpershoek

Restore patch series "arm: dts: am62-beagleplay: Fix Beagleplay Ethernet"

2024-05-20T19:35:03+00:00

As part of bringing the master branch back in to next, we need to allow
for all of these changes to exist here.

Reported-by: Jonas Karlman 
Signed-off-by: Tom Rini

Revert "Merge patch series "arm: dts: am62-beagleplay: Fix Beagleplay Ethernet""

2024-05-19T14:16:36+00:00

When bringing in the series 'arm: dts: am62-beagleplay: Fix Beagleplay
Ethernet"' I failed to notice that b4 noticed it was based on next and
so took that as the base commit and merged that part of next to master.

This reverts commit c8ffd1356d42223cbb8c86280a083cc3c93e6426, reversing
changes made to 2ee6f3a5f7550de3599faef9704e166e5dcace35.

Reported-by: Jonas Karlman 
Signed-off-by: Tom Rini

cmd: Remove and add needed includes

2024-05-06T21:05:04+00:00

Remove  from all "cmd/" files and when needed add
missing include files directly.

Signed-off-by: Tom Rini

cmd: bcb: extend BCB C API to allow read/write the fields

2023-11-16T23:59:58+00:00

Currently BCB C API only allows to modify 'command' BCB field.
Extend it so that we can also read and modify all the available
BCB fields (command, status, recovery, stage).

Co-developed-by: Cody Schuffelen 
Signed-off-by: Cody Schuffelen 
Signed-off-by: Dmitrii Merkurev 
Cc: Eugeniu Rosca 
Cc: Ying-Chun Liu (PaulLiu) 
Cc: Simon Glass 
Cc: Mattijs Korpershoek 
Cc: Sean Anderson 
Cc: Cody Schuffelen 
Tested-by: Mattijs Korpershoek  # on vim3
Reviewed-by: Mattijs Korpershoek

cmd: bcb: support various block device interfaces for BCB command

2023-11-16T23:59:58+00:00

Currently BCB command-line, C APIs and implementation only
support MMC interface. Extend it to allow various block
device interfaces.

Signed-off-by: Dmitrii Merkurev 
Cc: Eugeniu Rosca 
Cc: Ying-Chun Liu (PaulLiu) 
Cc: Simon Glass 
Cc: Mattijs Korpershoek 
Cc: Sean Anderson 
Cc: Cody Schuffelen 
Tested-by: Mattijs Korpershoek  # on vim3
Reviewed-by: Mattijs Korpershoek

cmd: bcb: select user(0) hwpart in __bcb_load()

2022-10-22T01:37:47+00:00

For some blk operations, it's possible that a different hw partition
gets selected via blk_dselect_hwpart().
In that case, only the region of the device covered by that partition
is accessible.

This breaks "bcb load" which attempts to read the gpt and assumes it's
on the user(0) hw partition:

=> bcb load 2 misc
GUID Partition Table Header signature is wrong: 0xDE7B17AD07D9E5D6 != 0x5452415020494645
find_valid_gpt: *** ERROR: Invalid GPT ***
GUID Partition Table Header signature is wrong: 0x0 != 0x5452415020494645
find_valid_gpt: *** ERROR: Invalid Backup GPT ***
Error: mmc 2:misc read failed (-2)

Add a fail-safe in __bcb_load() to ensure we will always read from the
user(0) hwpartition.

This fixes the following fastboot sequence:

$ fastboot erase mmc2boot1    # switch to hwpart1
$ fastboot reboot bootloader  # switch to hwpart0, then reads GPT

Signed-off-by: Mattijs Korpershoek 
Reviewed-by: Sean Anderson

blk: Rename if_type to uclass_id

2022-09-25T14:30:05+00:00

Use the word 'uclass' instead of 'if_type' to complete the conversion.

Signed-off-by: Simon Glass

blk: Switch over to using uclass IDs

2022-09-16T15:05:16+00:00

We currently have an if_type (interface type) and a uclass id. These are
closely related and we don't need to have both.

Drop the if_type values and use the uclass ones instead.

Maintain the existing, subtle, one-way conversion between UCLASS_USB and
UCLASS_MASS_STORAGE for now, and add a comment.

Signed-off-by: Simon Glass

common: Drop display_options.h from common header

2022-08-10T17:46:55+00:00

Move this out of the common header and include it only where needed.

Signed-off-by: Simon Glass