u-boot.git/cmd/bootefi.c, branch v2018.03-rc2

efi_loader: fix the online help for bootefi bootmgr

2018-02-09T23:24:00Z

The bootefi command is missing in the online help for bootefi bootmgr. Signed-off-by: Heinrich Schuchardt Signed-off-by: Alexander Graf

efi_loader: catch misspelled bootefi subcommand

2018-01-28T20:37:13Z

If 'bootefi hello' or 'bootefi selftest' can be executed depends on the configuration. If an invalid non-numeric 1st argument is passed to bootefi, e.g. 'bootefi hola', this string is converted to 0 and U-Boot jumps to this typically invalid address. With the patch the online help is shown instead. Signed-off-by: Heinrich Schuchardt Signed-off-by: Alexander Graf

efi_loader: Always use EFIAPI instead of asmlinkage

2018-01-28T20:37:13Z

EFI calls are usually defined as asmlinkage. That means we pass all parameters to functions via the stack x86_32. On x86_64 however, we need to also stick to the MS ABI calling conventions, which the EFIAPI define conveniently handles for us. Most EFI functions were also marked with EFIAPI, except for the entry call. So this patch adjusts all entry calls to use EFIAPI instead of the manual asmlinkage attribute. While at it, we also change the prototype of the entry point to return efi_status_t instead of ulong, as this is the correct prototype definition. Signed-off-by: Alexander Graf --- v1 -> v2: - Use efi_status_t in all occurences

efi_driver: EFI block driver

2018-01-22T22:09:14Z

This patch provides * a uclass for EFI drivers * a EFI driver for block devices For each EFI driver the uclass * creates a handle * adds the driver binding protocol The uclass provides the bind, start, and stop entry points for the driver binding protocol. In bind() and stop() it checks if the controller implements the protocol supported by the EFI driver. In the start() function it calls the bind() function of the EFI driver. In the stop() function it destroys the child controllers. The EFI block driver binds to controllers implementing the block io protocol. When the bind function of the EFI block driver is called it creates a new U-Boot block device. It installs child handles for all partitions and installs the simple file protocol on these. The read and write functions of the EFI block driver delegate calls to the controller that it is bound to. A usage example is as following: U-Boot loads the iPXE snp.efi executable. iPXE connects an iSCSI drive and exposes a handle with the block IO protocol. It calls ConnectController. Now the EFI block driver installs the partitions with the simple file protocol. iPXE uses the simple file protocol to load Grub or the Linux Kernel. Signed-off-by: Heinrich Schuchardt [agraf: add comment on calloc len] Signed-off-by: Alexander Graf

efi_loader: store DT in EFI_RUNTIME_SERVICES_DATA memory

2018-01-22T22:09:14Z

The device tree is needed at runtime. So we have to store it in EFI_RUNTIME_SERVICES_DATA memory. The UEFI spec recommends to store all configuration tables in EFI_RUNTIME_SERVICES_DATA memory. Signed-off-by: Heinrich Schuchardt Signed-off-by: Alexander Graf

efi_loader: consistently use efi_handle_t for handles

2018-01-22T22:09:13Z

We should consistently use the efi_handle_t typedef when referring to handles. Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass Signed-off-by: Alexander Graf

efi_loader: pass handle of loaded image

2017-12-01T12:40:07Z

The handle of a loaded image is the value of the handle member of the loaded image info object and not the address of the loaded image info. Reviewed-by: Simon Glass Signed-off-by: Heinrich Schuchardt Signed-off-by: Alexander Graf

efi_loader: Exit in efi_set_bootdev() upon invalid "desc"

2017-12-01T12:26:10Z

When trying to load an image from a non-existent USB key, U-Boot v2017.11 crashes on my x86 platform: => load usb 0:1 03000000 abc General Protection EIP: 0010:[<7b59030d>] EFLAGS: 00010286 Original EIP :[] ... This used to work in v2017.09. Testing has shown, that this bug was introduced with patch 95c5553e [efi_loader: refactor boot device and loaded_image handling]. This patch now checks if a valid "desc" is returned from blk_get_dev() and only continues when "desc" is available. Resulting in this cmd output (again): => load usb 0:1 03000000 abc ** Bad device usb 0 ** Signed-off-by: Stefan Roese Reviewed-by: Heinrich Schuchardt Signed-off-by: Alexander Graf

efi_loader: use bootargs as load options

2017-12-01T12:22:55Z

Use environment variable bootargs used as load options for bootefi payloads. Signed-off-by: Heinrich Schuchardt Signed-off-by: Alexander Graf

efi_selftest: correctly cleanup after selftest

2017-12-01T12:22:55Z

After executing bootefi selftest * restore GD * unlink the load image handle * return 0 or 1 and not a truncated efi_status_t. Signed-off-by: Heinrich Schuchardt Signed-off-by: Alexander Graf