u-boot.git/cmd/bootefi.c, branch v2019.01

efi_loader: create fdt reservation before copy

2018-12-02T20:59:37+00:00

When copying the device we must ensure that the copy does not fall into a
memory area reserved by the same.

So let's change the sequence: first create memory reservations and then
copy the device tree.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: fix memory mapping for sandbox

2018-12-02T20:59:37+00:00

The sandbox is using a virtual address space which is neither the physical
address space of the operating system nor the virtual address space in
which Linux aplications live. The addresses used insided the flattened
device tree use this sandbox virtual address space. The EFI subsystem uses
the virtual address space of the operating system and this is where the fdt
is stored.

Fix all incorrect addresses for the fdt in cmd/bootefi.cmd.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: macro efi_size_in_pages()

2018-12-02T20:59:37+00:00

When allocating EFI memory pages the size in bytes has to be converted to
pages.

Provide a macro efi_size_in_pages() for this conversion.
Use it in the EFI subsystem and correct related comments.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi: Rename bootefi_test_finish() to bootefi_run_finish()

2018-12-02T20:59:37+00:00

This function can be used from do_bootefi_exec() so that we use mostly the
same code for a normal EFI application and an EFI test.

Rename the function and use it in both places.

Signed-off-by: Simon Glass 
Signed-off-by: Alexander Graf

efi: Create a function to set up for running EFI code

2018-12-02T20:59:37+00:00

There is still duplicated code in efi_loader for tests and normal
operation.

Add a new bootefi_run_prepare() function which holds common code used to
set up U-Boot to run EFI code. Make use of this from the existing
bootefi_test_prepare() function, as well as do_bootefi_exec().

Also shorten a few variable names.

Signed-off-by: Simon Glass 
Signed-off-by: Alexander Graf

efi: Split out test init/uninit into functions

2018-12-02T20:59:37+00:00

The functions in bootefi are very long because they mix high-level code
and control with the low-level implementation. To help with this, create
functions which handle preparing for running the test and cleaning up
afterwards.

Also shorten the awfully long variable names here.

Signed-off-by: Simon Glass 
Signed-off-by: Alexander Graf

efi: Check for failure to create objects in selftest

2018-12-02T20:59:37+00:00

At present a few error conditions are not checked. Before refactoring
this code, add some basic checks. Note that this code still leaks memory
in the event of error. This will be tackled after the refactor.

Signed-off-by: Simon Glass 
Signed-off-by: Alexander Graf

efi_loader: carving out memory reservations

2018-12-02T20:59:37+00:00

The "Devicetree Specification 0.2" does not prescribe that memory
reservations must be EFI page aligned. So let's not make such an
assumption in our code.

Do not carve out the pages for the device tree. This memory area is
already marked as EFI_RUNTIME_SERVICES_DATA.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: memory reservation for fdt

2018-12-02T20:59:37+00:00

In copy_fdt() we allocate EFI pages for the fdt plus extra 12 KiB as
EFI_RUNTIME_SERVICES_DATA. Afterwards in efi_install_fdt() we overwrite
part of this memory allocation by marking it as EFI_BOOT_SERVICES_DATA.

Remove the code marking the fdt as EFI_BOOT_SERVICES_DATA.

Cf. commit 17ff6f02f5ad ("efi_loader: store DT in EFI_RUNTIME_SERVICES_DATA
memory")

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: fix typos

2018-12-02T20:59:37+00:00

Fix typos in EFI subsystem comments.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf