u-boot.git/cmd/bootefi.c, branch v2019.04

efi_loader: clean up bootefi_test_prepare()

2019-02-16T14:42:20+00:00

Free resources upon failure.

Correct the function description.

As there is no need for any special address in the dummy memory device
path passed via the EFI_LOADED_IMAGE_PROTOCOL simply use 0 as address.

Signed-off-by: Heinrich Schuchardt

efi_loader: fix EFI entry counting

2019-02-16T14:42:20+00:00

`bootefi selftest` fails on qemu-x86_defconfig if efi_selftest() is not
invoked using EFI_CALL().

Likewise we call the entry point of EFI payloads with
EFI_CALL(efi_start_image()).

entry_count indicates if we are in U-Boot (1) or in EFI payload code (0).
As we start in U-Boot code the initial value has to be 1.

Signed-off-by: Heinrich Schuchardt

efi_loader: use efi_start_image() for bootefi

2019-02-16T14:42:20+00:00

Remove the duplicate code in efi_do_enter() and use efi_start_image() to
start the image invoked by the bootefi command.

Signed-off-by: Heinrich Schuchardt

efi_loader: set entry point in efi_load_pe()

2019-02-16T14:42:20+00:00

Up to now efi_load_pe() returns the entry point or NULL in case of an
error. This does not allow to return correct error codes from LoadImage().

Let efi_load_pe() return a status code and fill in the entry point in the
corresponding field of the image object.

Signed-off-by: Heinrich Schuchardt

efi_loader: refactor switch to non-secure mode

2019-02-13T08:40:06+00:00

Refactor the switch from supervisor to hypervisor to a new function called
at the beginning of do_bootefi().

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: move efi_init_obj_list() to a new efi_setup.c

2019-02-13T08:40:05+00:00

The function, efi_init_obj_list(), can be shared in different pseudo efi
applications, like bootefi/bootmgr as well as my efishell. Moreover, it
will be utilized to extend efi initialization, for example, my "removable
disk support" patch and "capsule-on-disk support" patch in the future.

So with this patch, it will be moved to a new file, efi_setup.c, under
lib/efi_loader and exported, making no changes in functionality.

Signed-off-by: AKASHI Takahiro 
Remove lines deactivated by #if 1 #else
Reviewed-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: avoid unnecessary pointer to long conversion

2019-02-13T08:40:05+00:00

debug() support supports %p to print pointers.

The debug message is unique. So there is not need to write a possibly
distracting line number.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: use named constant for efi_dp_from_mem()

2019-02-13T08:40:05+00:00

When calling efi_dp_from_mem() use a named constant for the memory type.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: create fdt reservation before copy

2018-12-02T20:59:37+00:00

When copying the device we must ensure that the copy does not fall into a
memory area reserved by the same.

So let's change the sequence: first create memory reservations and then
copy the device tree.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf

efi_loader: fix memory mapping for sandbox

2018-12-02T20:59:37+00:00

The sandbox is using a virtual address space which is neither the physical
address space of the operating system nor the virtual address space in
which Linux aplications live. The addresses used insided the flattened
device tree use this sandbox virtual address space. The EFI subsystem uses
the virtual address space of the operating system and this is where the fdt
is stored.

Fix all incorrect addresses for the fdt in cmd/bootefi.cmd.

Signed-off-by: Heinrich Schuchardt 
Signed-off-by: Alexander Graf