u-boot.git/cmd/bootefi.c, branch v2023.07

efi_loader: fix efi_dp_from_file()

2023-05-13T09:09:51+00:00

* When called from efi_dp_from_name() we miss to append the filename
  for non-block devices.
* expand_media_path() could be simplified by using efi_dp_from_file to
  prepend the device path of the boot device.

This can be avoided by passing a device path to efi_dp_from_file() instead
of a block device descriptor and a partition number.

Signed-off-by: Heinrich Schuchardt

cmd: bootefi: allocate device-tree copy from high memory

2023-03-25T11:04:49+00:00

The bootefi command creates a copy of the device-tree within the first
127 MiB of memory. This may lead to overwriting previously loaded binaries
(e.g. kernel, initrd).

Linux EFI stub itself copies U-Boot's copy of the device-tree. This means
there is not restriction for U-Boot to place the device-tree copy to any
address. (Restrictions existed for 32bit ARM before Linux commit
7a1be318f579 ("ARM: 9012/1: move device tree mapping out of linear region")
for legacy booting.

Reported-by: Alexandre Ghiti 
Signed-off-by: Heinrich Schuchardt 
Tested-by: Alexandre Ghiti

efi_loader: Measure the loaded DTB

2023-02-19T20:15:15+00:00

Measures the DTB passed to the EFI application upon new boolean config
switch CONFIG_EFI_TCG2_PROTOCOL_MEASURE_DTB. For platforms where the
content of the DTB passed to the OS can change across reboots, there is
not point measuring it hence the config switch to allow platform to not
embed this feature.

Co-developed-by: Ilias Apalodimas 
Signed-off-by: Ilias Apalodimas 
Signed-off-by: Etienne Carriere 
Tested-by: Ilias Apalodimas 
Reviewed-by: Ilias Apalodimas

efi_loader: remove efi_delete_handle on loadfile2

2022-10-16T10:23:22+00:00

Loadfile2 code is installing two protocols on it's own handle
and uses efi_delete_handle() to clean it up on failure(s). However
commit 05c4c9e21ae6 ("efi_loader: define internal implementations of
install/uninstallmultiple") prepares the ground for us to clean up
efi_delete_handle() used in favor of Install/UninstallMultipleProtocol.

While at it clean up the non needed void casts to (void *) on the
protolcol installation.

Signed-off-by: Ilias Apalodimas 
Reviewed-by: Heinrich Schuchardt

cmd: replace efi_create_handle/add_protocol with InstallMultipleProtocol

2022-10-06T20:54:58+00:00

In general handles should only be deleted if the last remaining protocol
is removed.  Instead of explicitly calling
efi_create_handle -> efi_add_protocol -> efi_delete_handle which blindly
removes all protocols from a handle before removing it,  use
InstallMultiple/UninstallMultiple which adheres to the EFI spec and only
deletes a handle if there are no additional protocols present

Signed-off-by: Ilias Apalodimas 
Reviewed-by: Heinrich Schuchardt

treewide: Drop bootm_headers_t typedef

2022-09-29T20:07:57+00:00

This is not needed and we should avoid typedefs. Use the struct instead.

Signed-off-by: Simon Glass

efi_loader: memory leak in efi_set_bootdev()

2022-07-13T18:07:07+00:00

efi_dp_str() allocates memory which should be released after use.

Use %pD printf code. Adjust message wording.

Fixes: d837cb1e3b6b ("efi: Add debugging to efi_set_bootdev()")
Signed-off-by: Heinrich Schuchardt

cmd: load: add load command for memory mapped

2022-06-22T15:35:47+00:00

cp.b is used a lot as a way to load binaries to memory and execute
them, however we may need to integrate this with the efi subsystem to
set it up as a bootdev.

So, introduce a loadm command that will be consistent with the other
loadX commands and will call the efi API's.

ex: loadm $kernel_addr $kernel_addr_r $kernel_size

with this a kernel with CONFIG_EFI_STUB enabled will be loaded and
then subsequently booted with bootefi command.

Signed-off-by: Rui Miguel Silva 
Reviewed-by: Tom Rini

cmd/bootefi: correct command syntax

2022-05-28T08:59:27+00:00

For indicating the address and size of a memory region other commands use a
[:] syntax. Do the same for bootefi.

Fixes: 2058983689f0 ("cmd: bootefi: restore ability to boot arbitrary blob")
Signed-off-by: Heinrich Schuchardt

cmd: bootefi: restore ability to boot arbitrary blob

2022-04-23T20:05:33+00:00

Up until commit 5f59518a7b1ae ("efi_loader: setting boot device"), we
could boot an arbitrary blob with bootefi. Indeed, efi_run_image() even
has a special case for missing device paths indicating a payload that
was directly loaded via JTAG, for example.

Restore the ability to inject a UEFI payload into memory and `bootefi`
it. If the address passed isn't the last PE-COFF loaded, then we'll
wipe out the pre-existing DP/Image information and let efi_run_image()
synthesize a memory device path.

An image size is required if we're booting an arbitrary payload, and
the FDT argument has been changed to accept `-`. The size could be
deduced from the image header, but it's required anyways as an explicit
acknowledgment that one's trying to boot an arbitrary payload rather
than accidentally using the wrong address in the single-addr form.

Fixes: 5f59518a7b1a ("efi_loader: setting boot device")
Signed-off-by: Kyle Evans 
Reviewed-by: Heinrich Schuchardt