u-boot.git/cmd/bootefi.c, branch v2025.04

efi_loader: superfluous efi_restore_gd after EFI_CALL

2024-05-01T05:37:32+00:00

EFI_CALL() invokes __efi_entry_check() which executes set_gd(efi_gd).
There is no need to execute set_gd(efi_gd) again via efi_restore_gd().

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Ilias Apalodimas

cmd: bootefi: error handling bootefi selftest

2024-03-21T06:28:43+00:00

If bootefi selftest is executed and a problem with the device-tree
installation occurs, efi_install_fdt() writes sensible error messages.
It never returns EFI_INVALID_PARAMETER. It neither makes sense to check
for EFI_INVALID_PARAMETER nor to show the usage help for the bootefi
command in this case.

Fixes: 296faf4f7ef1 ("cmd: bootefi: re-organize do_bootefi()")
Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Ilias Apalodimas

cmd: bootefi: Don't show usage help if EFI binary fails.

2024-03-21T06:28:43+00:00

If an EFI binary returns an error code EFI_INVALID_PARAMETER, we show the
usage help for the bootefi command:

    Shell> exit 0x8000000000000002
    ## Application failed, r = 2
    bootefi - Boots an EFI payload from memory

    Usage:
    bootefi [:] []
      - boot EFI payload
    bootefi bootmgr [fdt address]
      - load and boot EFI payload based on BootOrder/BootXXXX variables.

        If specified, the device tree located at  gets
        exposed as EFI configuration table.

This makes no sense.

Fixes: 296faf4f7ef1 ("cmd: bootefi: re-organize do_bootefi()")
Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Ilias Apalodimas

cmd: bootefi: move library interfaces under lib/efi_loader

2023-12-17T12:04:54+00:00

In the prior commits, interfaces for executing EFI binary and boot manager
were carved out. Move them under efi_loader directory so that they can
be called from other places without depending on bootefi command.

Only efi_selftest-related code will be left in bootefi.c.

Signed-off-by: AKASHI Takahiro

cmd: bootefi: localize global device paths for efi_selftest

2023-12-17T12:04:54+00:00

Device paths allocated in bootefi_test_prepare() will be immediately
consumed by do_efi_selftest() and there is no need to keep them for later
use. Introduce test-specific varialbles to make it easier to move other
bootmgr functions into library directory in the next commit.

Signed-off-by: AKASHI Takahiro

cmd: bootefi: carve out binary execution interface

2023-12-17T12:04:54+00:00

Carve binary execution code out of do_bootefi_image() in order to move
binary-execution specific code into library directory in the later
commit.

Signed-off-by: AKASHI Takahiro

cmd: bootefi: carve out EFI boot manager interface

2023-12-17T12:04:54+00:00

Carve EFI boot manager related code out of do_bootefi_image() in order
to move boot manager specific code into library directory in the later
commit.

Signed-off-by: AKASHI Takahiro

cmd: bootefi: re-organize do_bootefi()

2023-12-17T12:04:54+00:00

Replicate some code and re-organize do_bootefi() into three cases, which
will be carved out as independent functions in the next two commits.

Signed-off-by: AKASHI Takahiro

cmd: bootefi: unfold do_bootefi_image()

2023-12-17T12:04:53+00:00

Unfold do_bootefi_image() into do_bootefi() in order to make it easier
to re-organize do_bootefi() in the next commit.

Signed-off-by: AKASHI Takahiro

boot: Drop size parameter from image_setup_libfdt()

2023-12-13T23:39:05+00:00

The of_size parameter is not used, so remove it.

Signed-off-by: Simon Glass 
Reviewed-by: Tom Rini