u-boot.git/cmd/efidebug.c, branch v2020.01

cmd: efidebug: fix a build error in show_efi_boot_opt()

2019-12-03T19:54:05+00:00

I detected the following error in sandbox with Clang on Travis CI:
    +cmd/efidebug.c:703:15: error: result of comparison of constant
     9223372036854775822 with expression of type 'int' is always false
     [-Werror,-Wtautological-constant-out-of-range-compare]
    +        else if (ret == EFI_NOT_FOUND)
    +                 ~~~ ^  ~~~~~~~~~~~~~

Simply changing a type of 'ret' to efi_status_t will fix this error.

Signed-off-by: AKASHI Takahiro 
Reviewed-by: Heinrich Schuchardt

env: Drop environment.h header file where not needed

2019-08-11T20:43:41+00:00

This header file is now only used by files that access internal
environment features. Drop it from various places where it is not needed.

Acked-by: Joe Hershberger 
Signed-off-by: Simon Glass

efi_loader: efidebug.c function documentation

2019-07-30T19:36:22+00:00

make htmldocs produces a warning:
./cmd/efidebug.c:733: WARNING: Unexpected indentation.
Correct the indentation.

Remove 'See above for details of sub-commands.' which is not helpful in the
Sphinx generated documentation.

Signed-off-by: Heinrich Schuchardt

efi_loader: function comments cmd/efi_debug.c

2019-07-16T22:17:20+00:00

Adjust comments for Sphinx.

Signed-off-by: Heinrich Schuchardt

efi_loader: consistent error handling in efidebug.c

2019-06-20T22:26:21+00:00

If a variable cannot be set, always show an information message.

Signed-off-by: Heinrich Schuchardt

efi_loader: consistent types in efidebug.c

2019-06-20T22:26:20+00:00

efi_status_t and int are of different size. Use separate variables for
return codes of different type.

Signed-off-by: Heinrich Schuchardt

cmd: efidebug: make some boot variables non-volatile

2019-06-04T21:56:14+00:00

Boot####, BootOrder and BootNext should be non-volatile.

Signed-off-by: AKASHI Takahiro 
Signed-off-by: Heinrich Schuchardt

efi_loader: optional data in load options are binary

2019-05-02T16:17:50+00:00

The field boot OptionalData in structure _EFI_LOAD_OPTIONS is for binary
data.

When we use `efidebug boot add` we should convert the 5th argument from
UTF-8 to UTF-16 before putting it into the BootXXXX variable.

When printing boot variables with `efidebug boot dump` we should support
the OptionalData being arbitrary binary data. So let's dump the data as
hexadecimal values.

Here is an example session protocol:

=> efidebug boot add 00a1 label1 scsi 0:1 doit1 'my option'
=> efidebug boot add 00a2 label2 scsi 0:1 doit2
=> efidebug boot dump
Boot00A0:
  attributes: A-- (0x00000001)
  label: label1
  file_path: .../HD(1,MBR,0xeac4e18b,0x800,0x3fffe)/doit1
  data:
    00000000: 6d 00 79 00 20 00 6f 00 70 00 74 00 69 00 6f 00  m.y. .o.p.t.i.o.
    00000010: 6e 00 00 00                                      n...
Boot00A1:
  attributes: A-- (0x00000001)
  label: label2
  file_path: .../HD(1,MBR,0xeac4e18b,0x800,0x3fffe)/doit2
  data:

Signed-off-by: Heinrich Schuchardt

cmd: efidebug: rework "boot dump" sub-command using GetNextVariableName()

2019-05-02T16:17:50+00:00

Currently in do_efi_boot_dump(), we directly read EFI variables from
related environment variables. To accommodate alternative storage
backends, we should switch to using the UEFI API instead.

Signed-off-by: AKASHI Takahiro 
Reviewed-by: Heinrich Schuchardt

efi_loader: more short texts for protocols in efidebug

2019-04-22T22:37:27+00:00

The `efidebug dh` command shows handles and the installed protocols. For
most of the protocols implemented by U-Boot a short text was shown. But for
some only the GUID was displayed.

Provide the missing short texts for the following protocols: HII String,
HII Database, HII Config Routing, Simple Network, PXE Base Code.

Signed-off-by: Heinrich Schuchardt