u-boot.git/cmd/fdt.c, branch v2017.09

fdt: fix 'prop (...) not found!' error in 'fdt set' command

2017-09-04T08:10:06+00:00

This commit brings things back to the well known working state of the
command.
-
With commit 9620d87259572ef21f0df60988d9a932ca673779
(cmd/fdt: support single value replacement within an array)

there was an error introduced modifying (inserting) a property to a
device-tree node.
fdt_getprop(...) returnes a len with -1 for a non-existing property, but
a memcpy with len -1 isn't a good idea and things went wrong (crash).
-
Some times later Tom did repair this
with commit 99bb38e2cce9d99238458e0f6d1880c6d2e80a4d
(fdt: Check for NULL return from fdt_getprop in 'fdt set')

This repairs the crash but the behaviour of the command isn't like
before, it makes it impossible to insert a property.
-

Signed-off-by: Hannes Schmelzer 
Acked-by: Simon Glass

env: Rename getenv_hex(), getenv_yesno(), getenv_ulong()

2017-08-16T12:30:32+00:00

We are now using an env_ prefix for environment functions. Rename these
for consistency. Also add function comments in common.h.

Suggested-by: Wolfgang Denk 
Signed-off-by: Simon Glass

env: Rename common functions related to setenv()

2017-08-16T12:23:32+00:00

We are now using an env_ prefix for environment functions. Rename these
commonly used functions, for consistency. Also add function comments in
common.h.

Suggested-by: Wolfgang Denk 
Signed-off-by: Simon Glass

env: Rename setenv() to env_set()

2017-08-16T12:22:18+00:00

We are now using an env_ prefix for environment functions. Rename setenv()
for consistency. Also add function comments in common.h.

Suggested-by: Wolfgang Denk 
Signed-off-by: Simon Glass

fdt: Check for NULL return from fdt_getprop in 'fdt set'

2017-07-11T16:08:20+00:00

While the previous pass through fixed one place where we knew that
fdt_getprop would be given a positive len, in the case of 'fdt set' we
do not, so check that we did no get NULL from fdt_getprop().

Cc: Simon Glass 
Reported-by: Coverity (CID: 163249)
Fixes 72c98ed1ab48 ("fdt: Add a check to do_fdt() for coverity")
Signed-off-by: Tom Rini 
Reviewed-by: Simon Glass

fdt: Add a check to fdt_print() for coverity

2017-06-12T12:38:08+00:00

We know that fdt_getprop() does not return NULL when len is > 0 but
coverity does not. Add an extra check to keep it happy.

Signed-off-by: Simon Glass 
Reported-by: Coverity (CID: 163248)

fdt: Add a check to do_fdt() for coverity

2017-06-12T12:38:08+00:00

We know that fdt_getprop() does not return NULL when len is > 0 but
coverity does not. Add an extra check to keep it happy.

Signed-off-by: Simon Glass 
Reported-by: Coverity (CID: 163249)
Fixes: bc80295b (fdt: Add get commands to fdt)

cmd/fdt: support single value replacement within an array

2017-06-09T19:45:34+00:00

With this commit we can modify single values within an array of a dts
property.

This is useful if we have for example a pwm-backlight where we want to
modifiy the pwm frequency per u-boot script.

The pwm is described in dts like this:

backlight {
	pwms = <0x0000002b 0x00000000 0x004c4b40>;
};

For changing the frequency, here the 3rd parameter, we simply type:

fdt set /backlight pwms ;

For doing all this we:
- backup the property content into our 'SCRATCHPAD'
- only modify the array-cell if the new content doesn't start with '?'

Signed-off-by: Hannes Schmelzer 
Reviewed-by: Simon Glass

Kconfig: Drop CONFIG_CMD_FDT_MAX_DUMP

2017-05-22T13:33:56+00:00

This option is not used by any board. Drop it.

Signed-off-by: Simon Glass

cmd/fdt: Make fdt get value endian-safe for single-cell properties

2017-01-14T17:09:46+00:00

On a Raspberry Pi 2 disagreements on cell endianness can be observed:

  U-Boot> fdt print /soc/gpio@7e200000 phandle
  phandle = <0x0000000d>
  U-Boot> fdt get value myvar /soc/gpio@7e200000 phandle; printenv myvar
  myvar=0x0D000000

Fix this by always treating the pointer as BE and converting it in
fdt_value_setenv(), like its counterpart fdt_parse_prop() already does.

Consistently use fdt32_t, fdt32_to_cpu() and cpu_to_fdt32().

Fixes: bc80295 ("fdt: Add get commands to fdt")
Cc: Joe Hershberger 
Cc: Gerald Van Baren 
Signed-off-by: Andreas Färber 
Acked-by: Simon Glass