u-boot.git/cmd/fdt.c, branch v2024.01

cmd: Convert existing long help messages to the new macro

2023-10-16T14:24:58+00:00

- Generally we just drop the #ifdef CONFIG_SYS_LONGHELP and endif lines
  and use U_BOOT_LONGHELP to declare the same variable name as before
- In a few places, either rename the variable to follow convention or
  introduce the variable as it was being done inline before.

Signed-off-by: Tom Rini 
Reviewed-by: Simon Glass

cmd: fdt: Correct checking of configuration node

2023-05-31T21:23:01+00:00

fit_conf_get_node() returns a negative value on error.

Signed-off-by: Bin Meng 
Reviewed-by: Simon Glass

fdt: Make fdt addr -q quieter

2023-04-02T18:53:53+00:00

64597346 "fdt: Add -q option to fdt addr for distro_bootcmd" introduced
the -q option for fdt addr, which sets the current working fdt address
without printing any output.

baf41410 "fdt: Show a message when the working FDT changes" made the
utility function set_working_fdt_addr (in cmd/fdt.c) output a message
on each invocation, even if called via fdt addr -q, in which case its
output is now slightly noisier.

To fix this, split out set_working_fdt_addr into set_working_fdt_addr
plus the static function set_working_fdt_addr_quiet.
set_working_fdt_addr_quiet can be called by "quiet" fdt cmd logic and
set_working_fdt_addr is exported (as before) to other boot logic. The
latter calls the former.

Remove the assertion from the fdt addr test case when calling with the
-q argument.

Signed-off-by: Peter Hoyes 
Reviewed-by: Marek Vasut 
Reviewed-by: Simon Glass

cmd: fdt: Use env_set_hex() for "get addr" and "get size"

2023-04-02T18:53:53+00:00

The 'fdt get addr' and 'env get size' is always assumed to be hex
value, drop the prefix, and outright switch to env_set_hex(). Since
this might break existing users who depend on the existing behavior
with 0x prefix, this is a separate patch.

Revert if this breaks anything.

Signed-off-by: Marek Vasut 
Reviewed-by: Simon Glass

cmd: fdt: Drop the 0x prefix

2023-03-14T22:08:51+00:00

The 'fdt get addr' is always assumed to be hex value, drop the prefix.
Since this might break existing users who depend on the existing
behavior with 0x prefix, this is a separate patch. Revert if this
breaks anything.

Signed-off-by: Marek Vasut

cmd: fdt: Add support for integer arrays in fdt get value with index

2023-03-08T19:40:57+00:00

Currently any integer array value is set as long up-to-40 character
hexadecimal string into environment variable when extracted from an
FDT using 'fdt get value path prop index', because the support for
handling integer arrays is not implemented, and fdt_value_env_set()
code falls back into the hash handling behavior instead.

Implement this support simply by checking whether user supplied any
index. If index is set and the property length is multiple of four,
then this is an integer array, and the code would extract value at
specified index.

There is a subtle change where default index is set to -1 instead of 0.
This is OK, since the only place which checks for index to be less or
equal zero is the string array handling code in fdt_value_env_set() and
that code would work perfectly well with index -1 too.

Signed-off-by: Marek Vasut 
Reviewed-by: Simon Glass

cmd: fdt: Map address returned from fdt get addr to sysmem

2023-03-08T19:40:57+00:00

The address returned from 'fdt get addr' command must be mapped
into sysmem, as this is a working FDT. Access to this address
without mapping it would lead to crash e.g. in sandbox.

The following command triggers the crash:
"
./u-boot -Dc 'fdt addr $fdtcontroladdr ; fdt get addr var / compatible ; md $var'
"

Signed-off-by: Marek Vasut 
Reviewed-by: Simon Glass

cmd: fdt: Handle 64bit pointers in fdt get addr

2023-03-08T19:40:57+00:00

The command assumed 32bit pointers so far, with 64bit pointer the
command would overwrite a piece of stack. Fix it by extending the
array size to cater for 64bit pointer, and use snprintf() to avoid
writing past the end of the array ever again.

Signed-off-by: Marek Vasut 
Reviewed-by: Simon Glass

cmd: fdt: Align checksign parameter names in help text

2023-03-08T19:40:57+00:00

The help text references 'addr' as an optional key start address,
but the explanation references the same as 'start', make sure they
both read as 'addr'. Also update the abbreviated 'addr' in the
explanation to 'address'.

Signed-off-by: Marek Vasut 
Reviewed-by: Simon Glass

cmd: fdt: Check argc before accessing argv in fdt memory

2023-03-08T19:40:57+00:00

On case 'fdt memory' is invoked without parameters, argv[2]/argv[3]
is not valid and this command would SEGFAULT in sandbox environment.
Add missing argc test to avoid the crash and rather print usage help
message.

Signed-off-by: Marek Vasut 
Reviewed-by: Simon Glass