u-boot.git/cmd/nvedit.c, branch v2023.07.01

cmd: nvedit: remove error check, handle with Kconfig

2023-05-09T15:38:33Z

Avoid error messages when SPL,TPL,VPL build don't have the environment options of the main build. This is needed when defined(CONFIG_ENV_IS_IN_xxx) is changed to CONFIG_IS_ENABLED(ENV_IS_IN_xxx). Signed-off-by: Troy Kisky

nvedit: simplify do_env_indirect()

2023-03-30T19:09:59Z

Instead of calling env_get(from) up to three times, just do it once, computing the value we will put into 'to' and error out if that is NULL (i.e. no 'from' variable and no default provided). No functional change. Signed-off-by: Rasmus Villemoes Reviewed-by: Simon Glass

Correct SPL use of CMD_NVEDIT_EFI

2023-02-09T21:32:26Z

This converts 1 usage of this option to the non-SPL form, since there is no SPL_CMD_NVEDIT_EFI defined in Kconfig Signed-off-by: Simon Glass

env: Drop ENV_IS_IN_SATA

2023-02-07T19:33:48Z

This is not used anywhere, so drop it. Signed-off-by: Simon Glass

cmd: env: Add `indirect` to indirectly set values

2022-04-07T20:50:42Z

This allows an ergonomic-enough approximation of ${!variable} expansion. This could be used the following way: ``` for target in ${boot_targets}; do env indirect target_name target_name_${target} # ... done ``` Assuming `target_name_mmc0` and similar are set appropriately. A default value can be optionally provided. Note: this acts on environment variables, not hush variables. Signed-off-by: Samuel Dionne-Riel Cc: Simon Glass Cc: "Marek Behún" [trini: Don't enable by default]

env: Move non-cli env functions to env/common.c

2021-10-21T18:50:48Z

Move the following functions from cmd/nvedit.c to env/common.c: env_set_ulong() env_set_hex() env_get_hex() eth_env_get_enetaddr() eth_env_set_enetaddr() env_get() from_env() env_get_f() env_get_ulong() since these functions are not specific for U-Boot's CLI. We leave env_set() in cmd/nvedit.c, since it calls _do_env_set(), which is a static function in that file. Signed-off-by: Marek Behún Reviewed-by: Simon Glass

env: Simplify env_match() and inline into env_get_f()

2021-10-21T18:50:48Z

In the past the env_match() function was used to match envs with - name, i.e. string "name" - variable assignment, i.e. string "name=other_value" The latter is not the case anymore, since the env_match() function is now used only in env_get_f(), and so we can simplify the function into a simple strncmp() with an additional comparison to '='. Let's do this, and since the resulting function is quite simple, let's also inline its code into env_get_f(). Signed-off-by: Marek Behún Reviewed-by: Simon Glass

env: Use memcpy() instead of ad-hoc code to copy variable value

2021-10-21T18:50:48Z

Copy the value of the found variable into given buffer with memcpy() instead of ad-hoc code. Signed-off-by: Marek Behún Reviewed-by: Simon Glass

env: Make return value of env_get_f() behave like sprintf() on success

2021-10-21T18:50:48Z

Currently the env_get_f() function's return value behaves weirdly: it returns the number of bytes written into `buf`, but whether this is excluding the terminating NULL-byte or including it depends on whether there was enough space in `buf`. Change the function to always return the actual length of the value of the environment variable (excluding the terminating NULL-byte) on success. This makes it behave like sprintf(). All users of this function in U-Boot are compatible with this change. Signed-off-by: Marek Behún Reviewed-by: Simon Glass

env: Early return from env_get_f() on NULL name

2021-10-21T18:50:48Z

Test non-NULL name immediately, not in env_match(). Signed-off-by: Marek Behún Reviewed-by: Simon Glass