u-boot.git/cmd/pxe.c, branch v2022.01

pxe: Allow calling the pxe_get logic directly

2021-11-12T00:02:43+00:00

Refactor this code so that we can call the 'pxe get' command without going
through the command-line interpreter. This makes it easier to get the
information we need, without going through environment variables.

Signed-off-by: Simon Glass 
Reviewed-by: Artem Lapkin 
Tested-by: Artem Lapkin 
Reviewed-by: Ramon Fried

pxe: Return the file size from the getfile() function

2021-11-12T00:02:36+00:00

It is pretty strange that the pxe code uses the 'filesize' environment
variable find the size of a file it has just read.

Partly this is because it uses the command-line interpreter to parse its
request to load the file.

As a first step towards unwinding this, return it directly from the
getfile() function. This makes the code a bit longer, for now, but will be
cleaned up in future patches.

Signed-off-by: Simon Glass 
Reviewed-by: Artem Lapkin 
Tested-by: Artem Lapkin 
Reviewed-by: Ramon Fried

pxe: Clean up the use of bootfile

2021-11-12T00:02:28+00:00

The 'bootfile' environment variable is read in the bowels of pxe_util to
provide a directory to which all loaded files are relative.

This is not obvious from the API to PXE and it is strange to make the
caller set an environment variable rather than pass this as a parameter.

The code is also convoluted, which this feature implemented by
get_bootfile_path().

Update the API to improve this. Unfortunately this means that
pxe_setup_ctx() can fail, so add error checking.

Signed-off-by: Simon Glass 
Reviewed-by: Artem Lapkin 
Tested-by: Artem Lapkin 
Reviewed-by: Ramon Fried

pxe: Move common parsing coding into pxe_util

2021-11-12T00:02:27+00:00

Both the syslinux and pxe commands use essentially the same code to parse
and run extlinux.conf files. Move this into a common function.

Signed-off-by: Simon Glass 
Reviewed-by: Artem Lapkin 
Tested-by: Artem Lapkin 
Reviewed-by: Ramon Fried

pxe: Tidy up the is_pxe global

2021-11-12T00:02:19+00:00

Move this into the context to avoid a global variable. Also rename it
since the current name does not explain what it actually affects.

Signed-off-by: Simon Glass 
Reviewed-by: Artem Lapkin 
Tested-by: Artem Lapkin 
Reviewed-by: Ramon Fried

pxe: Add a userdata field to the context

2021-11-12T00:02:18+00:00

Allow the caller to provide some info which is passed back to the
readfile() method.

Signed-off-by: Simon Glass 
Reviewed-by: Artem Lapkin 
Tested-by: Artem Lapkin 
Reviewed-by: Ramon Fried

pxe: Move do_getfile() into the context

2021-11-12T00:02:14+00:00

Rather than having a global variable, pass the function as part of the
context.

Signed-off-by: Simon Glass 
Reviewed-by: Artem Lapkin 
Tested-by: Artem Lapkin 
Reviewed-by: Ramon Fried

pxe: Use a context pointer

2021-11-12T00:02:11+00:00

At present the PXE functions pass around a pointer to command-table entry
which is very strange. It is only needed in a few places and it is odd to
pass around a data structure from another module in this way.

For bootmethod we will need to provide some context information when
reading files.

Create a PXE context struct to hold the command-table-entry pointer and
pass that around instead. We can then add more things to the context as
needed.

Signed-off-by: Simon Glass 
Reviewed-by: Artem Lapkin 
Tested-by: Artem Lapkin 
Reviewed-by: Ramon Fried

cmd: pxe: Add relocation to pxe_sub cmds

2020-09-23T12:29:57+00:00

pxe sub commands need to be manually relocated for architectures which
enables MANUAL_RELOC as Microblaze.

Signed-off-by: T Karthik Reddy 
Signed-off-by: Michal Simek 
Reviewed-by: Simon Glass

command: Remove the cmd_tbl_t typedef

2020-05-18T22:36:55+00:00

We should not use typedefs in U-Boot. They cannot be used as forward
declarations which means that header files must include the full header to
access them.

Drop the typedef and rename the struct to remove the _s suffix which is
now not useful.

This requires quite a few header-file additions.

Signed-off-by: Simon Glass