u-boot.git/cmd/ubi.c, branch v2020.10

command: Remove the cmd_tbl_t typedef

2020-05-18T22:36:55+00:00

We should not use typedefs in U-Boot. They cannot be used as forward
declarations which means that header files must include the full header to
access them.

Drop the typedef and rename the struct to remove the _s suffix which is
now not useful.

This requires quite a few header-file additions.

Signed-off-by: Simon Glass

cmd: ubi: add a command to rename volume

2020-04-20T04:34:56+00:00

This commit adds the command ubi rename to rename an ubi volume.
The format of the command is: ubi rename  .
To enable this command, the option CMD_UBI_RENAME must be selected.

Signed-off-by: Philippe Reynes 
Reviewed-by: Simon Glass

dm: core: Create a new header file for 'compat' features

2020-02-06T02:33:46+00:00

At present dm/device.h includes the linux-compatible features. This
requires including linux/compat.h which in turn includes a lot of headers.
One of these is malloc.h which we thus end up including in every file in
U-Boot. Apart from the inefficiency of this, it is problematic for sandbox
which needs to use the system malloc() in some files.

Move the compatibility features into a separate header file.

Signed-off-by: Simon Glass

dm: core: Require users of devres to include the header

2020-02-06T02:33:46+00:00

At present devres.h is included in all files that include dm.h but few
make use of it. Also this pulls in linux/compat which adds several more
headers. Drop the automatic inclusion and require files to include devres
themselves. This provides a good indication of which files use devres.

Signed-off-by: Simon Glass 
Reviewed-by: Anatolij Gustschin

ubi: Add "skipcheck" command to set/clear this bit in the UBI volume hdr

2019-10-16T03:42:36+00:00

U-Boot now supports the "skip_check" flag to optionally skip the CRC
check at open time. Currently its only possible to set this bit upon
UBI volume creation. But it might be very useful to also set this bit
on already installed systems (e.g. field upgrade) to make also use of
the boot-time decrease on those systems.

This patch now adds a new "ubi" command "ubi skipcheck" to set or clear
this bit in the UBI volume header:

=> ubi skipcheck rootfs0 on
Setting skip_check on volume rootfs0

BTW: This saves approx. 10 seconds Linux bootup time on a MT7688 based
target with 128MiB of SPI NAND.

Signed-off-by: Stefan Roese 
Reviewed-by: Heiko Schocher 
Cc: Quentin Schulz 
Cc: Boris Brezillon 
Cc: Heiko Schocher 
Cc: Andreas Dannenberg

ubi: provide a way to skip CRC checks

2019-10-16T03:42:27+00:00

Some users of static UBI volumes implement their own integrity check,
thus making the volume CRC check done at open time useless. For
instance, this is the case when one use the ubiblock + dm-verity +
squashfs combination, where dm-verity already checks integrity of the
block device but this time at the block granularity instead of verifying
the whole volume.

Skipping this test drastically improves the boot-time.

Adapted to U-Boot by Stefan Roese.

Signed-off-by: Quentin Schulz 
Signed-off-by: Stefan Roese 
Reviewed-by: Heiko Schocher 
Cc: Quentin Schulz 
Cc: Boris Brezillon

env: Move env_set_hex() to env.h

2019-08-11T20:43:41+00:00

Move env_set_hex() over to the new header file along with env_set_addr()
which uses it.

Signed-off-by: Simon Glass 
Acked-by: Joe Hershberger

cmd: ubi: remove unreachable code

2019-01-15T20:28:44+00:00

It does not make sense to check if argc < 2 a second time, especially after
accessing argv[1].

Signed-off-by: Heinrich Schuchardt

cmd: ubi: Make ubi_detach() static

2018-11-22T06:09:52+00:00

Its only called from this file, so make it static. While at it, remove
some occurances of multiple blank lines as well.

Signed-off-by: Stefan Roese 
Cc: Boris Brezillon 
Cc: Miquel Raynal 
Reviewed-by: Miquel Raynal 
Reviewed-by: Boris Brezillon 
Reviewed-by: Jagan Teki

cmd: ubi: Remove useless call to mtdparts_init()

2018-11-13T13:23:10+00:00

Commit c58fb2cdb3e4 ("cmd: ubi: clean the partition handling")
introduced a call to mtd_probe_devices() in the ubi_attach() path
and this function takes care of parsing mtdparts/mtdids and
creating/registering the associated mtd partitions.

The mtdparts_init() call in the ubi_detach() path is not only
unnecessary but can sometimes print error messages even when things
work properly (that's the case with SPI NAND devices that have not
been probed with 'mtd list'), which is misleading.

Remove this call to mtdparts_init() and drop the dependency on
CMD_MTDPARTS.

Fixes: c58fb2cdb3e4 ("cmd: ubi: clean the partition handling")
Reported-by: Stefan Roese 
Signed-off-by: Boris Brezillon 
Tested-by: Stefan Roese 
Reviewed-by: Lukasz Majewski 
Reviewed-by: Jagan Teki