u-boot.git/common/cli.c, branch v2017.11-rc3

env: Rename getenv/_f() to env_get()

2017-08-16T12:30:24+00:00

We are now using an env_ prefix for environment functions. Rename these
two functions for consistency. Also add function comments in common.h.

Quite a few places use getenv() in a condition context, provoking a
warning from checkpatch. These are fixed up in this patch also.

Suggested-by: Wolfgang Denk 
Signed-off-by: Simon Glass

hush: complete renaming CONFIG_SYS_HUSH_PARSER to CONFIG_HUSH_PARSER

2016-06-24T21:24:34+00:00

There is no more define of CONFIG_SYS_HUSH_PARSER.  Rename some
remaining references and drop the backward compatible Kconfig entry.

Signed-off-by: Masahiro Yamada

common: cli: Fix typo CONFIG_CMDINE -> CONFIG_CMDLINE

2016-04-04T17:13:07+00:00

Patch f8bb6964 (Drop command-processing code when CONFIG_CMDLINE is
disabled) introduced a small typo. This patch fixes it and unbreaks
all boards again that don't have the Hush parser enabled.

Signed-off-by: Stefan Roese 
Cc: Simon Glass 
Cc: Tom Rini

Drop command-processing code when CONFIG_CMDLINE is disabled

2016-04-01T21:17:40+00:00

Command parsing and processing code is not needed when the command line is
disabled. Remove this code in that case.

Signed-off-by: Simon Glass 
Reviewed-by: Tom Rini

common: cli: avoid memory leak

2016-01-04T17:25:35+00:00

Whether CONFIG_SYS_HUSH_PARSER is defined or not, should always
check to free 'buff' to avoid memory leak.

Signed-off-by: Peng Fan 
Cc: Tom Rini 
Cc: Masahiro Yamada 
Cc: Simon Glass

Move console definitions into a new console.h file

2015-11-20T03:27:50+00:00

The console includes a global variable and several functions that are only
used by a small subset of U-Boot files. Before adding more functions, move
the definitions into their own header file.

Signed-off-by: Simon Glass

of: clean up OF_CONTROL ifdef conditionals

2015-08-18T17:46:05+00:00

We have flipped CONFIG_SPL_DISABLE_OF_CONTROL.  We have cleansing
devices, $(SPL_) and CONFIG_IS_ENABLED(), so we are ready to clear
away the ugly logic in include/fdtdec.h:

 #ifdef CONFIG_OF_CONTROL
 # if defined(CONFIG_SPL_BUILD) && !defined(SPL_OF_CONTROL)
 #  define OF_CONTROL 0
 # else
 #  define OF_CONTROL 1
 # endif
 #else
 # define OF_CONTROL 0
 #endif

Now CONFIG_IS_ENABLED(OF_CONTROL) is the substitute.  It refers to
CONFIG_OF_CONTROL for U-boot proper and CONFIG_SPL_OF_CONTROL for
SPL.

Also, we no longer have to cancel CONFIG_OF_CONTROL in
include/config_uncmd_spl.h and scripts/Makefile.spl.

Signed-off-by: Masahiro Yamada 
Reviewed-by: Tom Rini 
Reviewed-by: Simon Glass 
Acked-by: Linus Walleij

cli: hush: Adjust 'run' command to run each line of the env var

2014-10-27T15:03:33+00:00

The run command treats each argument an an environment variable. It gets the
value of each variable and executes it as a command. If an environment
variable contains a newline and the hush cli is used, it is supposed to
execute each line one after the other.

Normally a newline signals to hush to exit - this is used in normal command
line entry - after a command is entered we want to return to allow the user
to enter the next one. But environment variables obviously need to execute
to completion.

Add a special case for the execution of environment variables which
continues when a newline is seen, and add a few tests to check this
behaviour.

Note: it's not impossible that this may cause regressions in other areas.
I can't think of a case but with any change of behaviour with limited test
coverage there is always a risk. From what I can tell this behaviour has
been around since at least U-Boot 2011.03, although this pre-dates sandbox
and I have not tested it on real hardware.

Reported-by: Wolfgang Denk 
Signed-off-by: Simon Glass

Add run_command_repeatable()

2014-06-11T20:25:47+00:00

run_command() returns 0 on success and 1 on error. However, there are some
invocations which expect 0 or 1 for success (not repeatable or repeatable)
and -1 for error; add run_command_repeatable() for this purpose.

Signed-off-by: Thomas Betker 
Acked-by: Simon Glass 
Tested-by: Simon Glass

main: Make the execution path a little clearer in main.c

2014-05-29T21:52:03+00:00

bootdelay_process() never returns in some circumstances, whichs makes the
control flow confusing. Change it so that the decision about how to execute
the boot command is made in the main_loop() code, so it is easier to follow.
Move CLI stuff to cli.c.

Signed-off-by: Simon Glass