u-boot.git/common/cli_readline.c, branch v2024.07-rc1

cli: allow users to determine history buffer allocation method

2024-03-13T16:40:43Z

This commit allows users to choose the appropriate memory allocation method between static allocated and dynamically calloc. The previous static-array way will not obviously contribute to the final binary size since it is uninitialized, and might have better performance than the dynamical one. Now we provide the users with both the two options. Signed-off-by: Hanyuan Zhao

cli: panic when failed to allocate memory for the history buffer

2024-03-13T16:40:43Z

This commit simply modifies the history initialize function, replacing the return value by panic with reasons. The calling chains of hist_init don't have steps explicitly throwing or dealing with the ENOMEM error, and once the init fails, the whole system is died. Using panic here to provide error information instead. Signed-off-by: Hanyuan Zhao

getchar(): Correct usage

2024-01-19T01:24:13Z

The function getchar() returns an 'int' and not a 'char'. Coverity notes that "Assigning the return value of getchar to char ... truncates its value." and so for the most part we can resolve this easily by using 'int' as intended, and often used throughout the codebase. A few places are not so simple and would require further re-architecting of the code in order to change this, so we leave them be. Signed-off-by: Tom Rini

command: Allocate history buffer using calloc()

2023-12-20T15:46:54Z

The history buffer is currently a static array which can be some 10-40 kiB depending on configuration, and so adds considerably to the U-Boot binary size. Allocate it dynamically instead to reduce the U-Boot binary size. Signed-off-by: Marek Vasut

cli: Add a function to set up a new cread

2023-10-11T19:43:54Z

Create a init function so that it is easy to use command-line reading. Signed-off-by: Simon Glass

cli: Allow command completion to be disabled

2023-10-11T19:43:54Z

When inputting text outside the command line we don't want to use tab for command completion. Add an option to control this. Signed-off-by: Simon Glass

cli: Allow history to be disabled

2023-10-11T19:43:54Z

When inputting text outside the command line we don't want history to be accessible. Add an option to control this. Signed-off-by: Simon Glass

cli: Terminate the string in cread_line_process_ch()

2023-10-11T19:43:54Z

Rather than relying on the caller, terminate the string inside this function. Do this each time we return, whether input is finished or not. It is not needed when the input is aborted, since the string will be discarded in that case. Signed-off-by: Simon Glass

cli: Create a function to process characters

2023-10-11T19:43:54Z

Move most of the inner loop from cread_line() into a new function. This will allow using it from other code. This involves adding a few more members to the state struct. Signed-off-by: Simon Glass

cli: Unindent some code in cread_line()

2023-10-11T19:43:54Z

Reduce the indentation level of this code so it is easier to review the next patch, which moves it into a function. Signed-off-by: Simon Glass