u-boot.git/common/console.c, branch v2018.07

console: Fix handling of NULL global_data

2018-06-18T18:43:14+00:00

Both putc() and puts() can be called before global_data is set up. Some of
the code paths don't handle this correctly. Add an explicit test before
any member is accessed.

Reported-by: Coverity (CID: 169030)
Signed-off-by: Simon Glass 
Reviewed-by: Heinrich Schuchardt

SPDX: Convert all of our single license tags to Linux Kernel style

2018-05-07T13:34:12+00:00

When U-Boot started using SPDX tags we were among the early adopters and
there weren't a lot of other examples to borrow from.  So we picked the
area of the file that usually had a full license text and replaced it
with an appropriate SPDX-License-Identifier: entry.  Since then, the
Linux Kernel has adopted SPDX tags and they place it as the very first
line in a file (except where shebangs are used, then it's second line)
and with slightly different comment styles than us.

In part due to community overlap, in part due to better tag visibility
and in part for other minor reasons, switch over to that style.

This commit changes all instances where we have a single declared
license in the tag as both the before and after are identical in tag
contents.  There's also a few places where I found we did not have a tag
and have introduced one.

Signed-off-by: Tom Rini

stdio_names: Ensure MAX_NAMES is defined before use, don't use 3 directly

2018-05-06T17:35:16+00:00

With tighter build flags the fact that  doesn't have a
reference back to MAX_NAMES causes an error.  Include  here and
then in common/console.c use MAX_NAMES rather than 3 when working with
stdio_names.

Reported-by: Peter Robinson 
Signed-off-by: Tom Rini 
Tested-by: Peter Robinson

Revert "sandbox: Drop special case console code for sandbox"

2017-12-07T20:17:00+00:00

While sandbox works OK without the special-case code, it does result in
console output being stored in the pre-console buffer while sandbox starts
up. If there is a crash or a problem then there is no indication of what
is going on.

For ease of debugging it seems better to revert this change also.

This reverts commit d8c6fb8cedbc35eee27730a7fa544e499b3c81cc.

Signed-off-by: Simon Glass

Revert "console: simplify puts()"

2017-11-12T21:18:16+00:00

This reverts commit c61d0009feb966e0e93254a8c435a1889085e6b8.

A tbs2910 board user reported a very slow console frambuffer as
regression in current u-boot. I could bisect this down to the
above mentioned commit.

This revert brings back the fast framebuffer console (one
cache flush per string in puts(), not after each char).

Reported-by: Uwe Scheffler 
Signed-off-by: Soeren Moch 
Tested-by: Uwe Scheffler 
Reviewed-by: Simon Glass

common: console: Fix duplicated CONFIG in silent env callback

2017-08-28T11:19:12+00:00

The silent environment callback function does not update the silent
flag during silent env set or unset. That is because of duplicated
CONFIG keyword at preprocessor condition in silent environment
callback function and cause silent env callback unable to work.

This patch is to remove the duplicated CONFIG keywork in silent
environment callback function.

Signed-off-by: Wilson Lee 
Cc: Keng Soon Cheah 
Cc: Chen Yee Chew 
Cc: Joe Hershberger

env: Rename getenv/_f() to env_get()

2017-08-16T12:30:24+00:00

We are now using an env_ prefix for environment functions. Rename these
two functions for consistency. Also add function comments in common.h.

Quite a few places use getenv() in a condition context, provoking a
warning from checkpatch. These are fixed up in this patch also.

Suggested-by: Wolfgang Denk 
Signed-off-by: Simon Glass

env: Rename setenv() to env_set()

2017-08-16T12:22:18+00:00

We are now using an env_ prefix for environment functions. Rename setenv()
for consistency. Also add function comments in common.h.

Suggested-by: Wolfgang Denk 
Signed-off-by: Simon Glass

dm: console: Check for serial devices properly

2017-07-31T16:21:40+00:00

With driver model the serial device is often not called "serial". Mark
driver-model stdio devices so that they can be detected and we can look up
the uclass. This is a more reliable way of finding out whether the console
is connected to a serial device or not.

Signed-off-by: Simon Glass

console: Unify the check for a serial console

2017-07-31T16:21:40+00:00

Put the check for whether a console is a serial device in a function so
that we can share the code in the two places that use it.

Signed-off-by: Simon Glass