u-boot.git/common/env_flags.c, branch v2016.11-rc2

tools: fix env_flags build

2016-02-15T20:58:25+00:00

$ make tools-all
  ...
  In file included from tools/env/env_flags.c:1:0:
  tools/env/../../common/env_flags.c: In function
    ‘env_flags_parse_varaccess_from_binflags’:
    tools/env/../../common/env_flags.c:156:18: warning: implicit declaration
    of function ‘ARRAY_SIZE’ [-Wimplicit-function-declaration]
      for (i = 0; i < ARRAY_SIZE(env_flags_varaccess_mask); i++)
                      ^
Seems like the other utilities just add a copy of ARRAY_SIZE since
there's nowhere to include it from (tools/imagetool.h,
tools/mxsimage.h). Let's do the same here.

Signed-off-by: Lubomir Rintel

tools: env validate: pass values as 0-based array

2016-02-08T15:10:29+00:00

passing argv/argc can produce off-by-one errors

Signed-off-by: Andreas Fenkart

common: env_flags: fix loop condition when using env_flags_varaccess_mask

2016-01-14T02:05:26+00:00

We should use ARRAY_SIZE, but not sizeof. The size of
env_flags_varaccess_mask is 16bytes, but we only need 4 loops.
If using 16 as the end condition, we may access memory that
not belong to array env_flags_varaccess_mask.

Signed-off-by: Peng Fan 
Cc: Joe Hershberger 
Cc: York Sun 
Cc: Simon Glass 
Cc: Tom Rini 
Reviewed-by: Simon Glass 
Acked-by: Joe Hershberger

common: env: initialize scalar variable

2016-01-04T17:25:35+00:00

Before calling hsearch_r, initialize callback entry to NULL.

Coverity log:
"
Uninitialized scalar variable (UNINIT)
uninit_use_in_call: Using uninitialized value e.
Field e.callback is uninitialized when calling hsearch_r.
"

Reported-by: Coverity
Signed-off-by: Peng Fan 
Cc: Tom Rini 
Cc: Simon Glass

common/env_flags.c: Add function to validate a MAC address

2015-09-21T15:29:47+00:00

The code that checks if a string has the format of a MAC address has been
moved to a separate function called eth_validate_ethaddr_str().

This has been done to allow other components (such as vsc9953 driver)
to validate a MAC address.

Signed-off-by: Codrin Ciubotariu 
Acked-by: Joe Hershberger 
Reviewed-by: York Sun

env: Allow env_attr_walk to pass a priv * to callback

2015-05-21T13:13:19+00:00

In some cases it can be helpful to have context in the callback about
the calling situation. This is needed for following patches.

Signed-off-by: Joe Hershberger 
Reviewed-by: Simon Glass

common, env: optimize boottime

2014-01-14T14:01:06+00:00

when creating the hashtable, for each environmentvariable
getenv(ENV_CALLBACK_VAR) and getenv(ENV_FLAGS_VAR) is called,
which costs at this point a lot of time. So call this two
getenv() calls only once.

Boottime on the ids8313 board without this patch:

2013-12-19 13:38:22,894:  NAND:  128 MiB
2013-12-19 13:38:27,659:  In:    serial
(~4.8 sec)

Bootime with this patch on the ids8313 board:

2013-12-19 13:40:25,332:  NAND:  128 MiB
2013-12-19 13:40:25,546:  In:    serial
(~0.2 sec)

Signed-off-by: Heiko Schocher 
Cc: Tom Rini 
Cc: Joe Hershberger 
Cc: Wolfgang Denk

Add GPL-2.0+ SPDX-License-Identifier to source files

2013-07-24T13:44:38+00:00

Signed-off-by: Wolfgang Denk 
[trini: Fixup common/cmd_io.c]
Signed-off-by: Tom Rini

env: Handle write-once ethaddr and serial# generically

2012-12-13T18:46:57+00:00

Use the variable access flags to implement the protection for ethaddr
and serial# instead of hard-coding them.

Signed-off-by: Joe Hershberger

env: Add support for access control to .flags

2012-12-13T18:46:56+00:00

Add support for read-only, write-once, and change-default.

Signed-off-by: Joe Hershberger