u-boot.git/common/lcd.c, branch v2015.04

lcd: split splash code into its own function

2015-02-10T12:31:58+00:00

lcd_logo() currently performs tasks well beyond just displaying the logo.
It has code which displays splash image, it has logic which determines
when the different display features are displayed, and it is coupled with
the lcd console because it holds the responsibility of returning the
lcd console base address.

Make lcd_logo() just about the logo by:
* Moving splash image display code into a dedicated function
* Moving the logic regarding when various features are displayed to
  lcd_clear() (which is arguably not the correct name for housing such
  code either, but it is currently the most fitting location code wise)
* Move the responsibility of setting the console base address to
  lcd_clear() too.

Signed-off-by: Nikita Kiryanov 
Reviewed-by: Simon Glass 
Tested-by: Bo Shen 
Tested-by: Josh Wu 
Cc: Bo Shen 
Cc: Simon Glass 
Cc: Anatolij Gustschin

lcd: dt: extract simplefb support

2015-02-10T12:31:26+00:00

We now have api functions that can support compiling simplefb code as its own
module. Since this code is not part of the display functionality, extract it
to its own file.

Raspberry Pi is updated to accommodate the changes.

Signed-off-by: Nikita Kiryanov 
Acked-by: Stephen Warren 
Reviewed-by: Simon Glass 
Tested-by: Bo Shen 
Tested-by: Josh Wu 
Cc: Simon Glass 
Cc: Anatolij Gustschin 
Cc: Stephen Warren

lcd: rename bitmap_plot to better represent its functionality

2015-02-10T12:30:49+00:00

The name "bitmap_plot" is misleading because it implies that this is a generic
function capable of dealing with any bitmap, but its implementation only works
with the logo data.

Rename the function to better reflect this.

Signed-off-by: Nikita Kiryanov 
Reviewed-by: Simon Glass 
Tested-by: Bo Shen 
Tested-by: Josh Wu 
Cc: Simon Glass 
Cc: Anatolij Gustschin

lcd: various cleanups

2015-02-10T12:30:20+00:00

This cleanup mostly focuses on removing unnecessary whitespace and comments
which are superfluous and/or do not conform to the coding style.

Signed-off-by: Nikita Kiryanov 
Reviewed-by: Simon Glass 
Tested-by: Bo Shen 
Tested-by: Josh Wu 
Cc: Simon Glass 
Cc: Anatolij Gustschin

lcd: remove unused includes

2015-02-10T12:29:44+00:00

Remove unused includes.

Signed-off-by: Nikita Kiryanov 
Reviewed-by: Simon Glass 
Tested-by: Bo Shen 
Tested-by: Josh Wu 
Cc: Bo Shen 
Cc: Simon Glass 
Cc: Anatolij Gustschin

lcd: introduce lcd_set_cmap

2015-02-10T12:29:02+00:00

Reduce the lcd_display_bitmap #ifdef complexity by extracting Atmel-specific
code for setting cmap for bitmap images into a new function lcd_set_cmap().
A default version is implemented with the remainder of the code.

Signed-off-by: Nikita Kiryanov 
Reviewed-by: Simon Glass 
Tested-by: Bo Shen 
Tested-by: Josh Wu 
Cc: Bo Shen 
Cc: Simon Glass 
Cc: Anatolij Gustschin

lcd: logo: move generic cmap setting to lcd_logo_set_cmap()

2015-02-10T12:28:30+00:00

Get rid of platform-specific #ifdefs in bitmap_plot() by moving the generic
case of setting cmap into the weak lcd_logo_set_cmap().

Signed-off-by: Nikita Kiryanov 
Reviewed-by: Simon Glass 
Tested-by: Bo Shen 
Tested-by: Josh Wu 
Cc: Bo Shen 
Cc: Simon Glass 
Cc: Anatolij Gustschin

lcd: mpc823: move mpc823-specific lcd_logo_set_cmap code to mpc8xx_lcd.c

2015-02-10T12:27:58+00:00

Reduce the bitmap_plot #ifdef complexity by extracting MPC823-specific code for
setting cmap into its own implementation of lcd_logo_set_cmap(), implemented in
mpc8xx_lcd.c. In the MPC823 implementation, ARRAY_SIZE(bmp_logo_palette) is
switched for BMP_LOGO_COLORS to avoid having to include bmp_logo_data.h, which
would cause a compilation error because the logo data and palette arrays would
be defined twice.

This is a step towards cleaning bitmap_plot() of platform-specific code.

Signed-off-by: Nikita Kiryanov 
Reviewed-by: Simon Glass 
Tested-by: Bo Shen 
Tested-by: Josh Wu 
Cc: Simon Glass 
Cc: Anatolij Gustschin

lcd: atmel: introduce lcd_logo_set_cmap

2015-02-10T12:27:28+00:00

Reduce the bitmap_plot #ifdef complexity by extracting Atmel-specific code for
setting cmap into a new function lcd_logo_set_cmap(), which is implemented in
atmel_lcdfb driver and defined as part of common/lcd.c api with a weak dummy
version. In the Atmel implementation, ARRAY_SIZE(bmp_logo_palette) is
switched for BMP_LOGO_COLORS to avoid having to include bmp_logo_data.h, which
would cause a compilation error because the logo data and palette arrays would
be defined twice.

This is a step towards cleaning bitmap_plot() of platform-specific code.

Signed-off-by: Nikita Kiryanov 
Reviewed-by: Simon Glass 
Tested-by: Bo Shen 
Tested-by: Josh Wu 
Cc: Bo Shen 
Cc: Simon Glass 
Cc: Anatolij Gustschin

lcd: mpc8xx: move mpc823-specific fb_put_byte to mpc8xx_lcd.c

2015-02-10T12:26:53+00:00

Reduce the amount of platform-specific code in common/lcd.c by moving MPC823
implementation of fb_put_byte() to mpc8xx_lcd.c. Since we must also have a
default implementation for everybody else, make the remainder of the code
into a weak function.

Signed-off-by: Nikita Kiryanov 
Reviewed-by: Simon Glass 
Tested-by: Bo Shen 
Tested-by: Josh Wu 
Cc: Simon Glass 
Cc: Anatolij Gustschin