u-boot.git/drivers/ata, branch v2017.09-rc1

dm: ahci: Avoid scsi_scan_dev() in ahci_probe_scsi()

2017-07-28T18:02:47Z

Running 'scsi scan' command causes scsi_scan_dev() to be called, from which device_probe() is called and consequently AHCI driver probe routine will be called as SCSI driver's parent, and finally ahci_probe_scsi() calls scsi_scan_dev() again. Remove the call to scsi_scan_dev() in ahci_probe_scsi(). Signed-off-by: Bin Meng Reviewed-by: Simon Glass

dm: ahci: Add a driver for SCSI on AHCI

2017-07-11T16:08:19Z

Some AHCI drivers use SCSI under the hood. Rather than making the AHCI driver be in the SCSI uclass it makes sense to have the AHCI device create a SCSI device as a child. That way we can handle any AHCI-specific operations rather than trying to pretend tha the device is just SCSI. To handle this we need to provide a way for AHCI drivers to bind a SCSI device as its child, and probe it. Add functions for this. Signed-off-by: Simon Glass Reviewed-by: Bin Meng

dm: scsi: Adjust return value of scsi_exec()

2017-07-11T16:08:19Z

Change this function to return an error number instead of true/false. This allows us to return a proper error number. Signed-off-by: Simon Glass Reviewed-by: Bin Meng

dm: scsi: Add operations for SCSI devices

2017-07-11T16:08:19Z

The SCSI uclass currently has no operations. It just uses the global SCSI functions. Fix this by adding operations to the only two drivers that use the uclass, and replacing the global functions with those defined locally in the SCSI code. Signed-off-by: Simon Glass Reviewed-by: Bin Meng

dm: ahci: Create a local version of two SCSI functions

2017-07-11T16:08:19Z

With driver model we need to define implementations of exec() and bus_reset() separately for each SCSI driver. As a first step, create a local version of each function in the AHCI driver and call each from its global version. Signed-off-by: Simon Glass Reviewed-by: Bin Meng

dm: scsi: Add a device pointer to scan_exec(), scsi_bus_reset()

2017-07-11T16:08:19Z

With driver model these functions need a device pointer. Add one even when CONFIG_DM_SCSI is not defined. This avoids having ugly conditional function prototypes, When CONFIG_DM_SCSI is not defined we can just ignore the pointer. Signed-off-by: Simon Glass Reviewed-by: Bin Meng

dm: ahci: Drop use of probe_ent

2017-07-11T16:08:19Z

With driver model we cannot have static data or assume that there is only one device of each time. Adjust the code so that 'probe_ent' is not needed with driver model. Add a new ahci_init_dm() function which can init AHCI for driver model without re-allocating the uclass data. Move over the only existing driver to use this new function. Signed-off-by: Simon Glass Reviewed-by: Bin Meng

dm: ahci: Unwind the confusing init code

2017-07-11T16:08:19Z

Two AHCI drivers use SCSI with CONFIG_DM_SCSI. The SCSI uclass calls scsi_low_level_init() which is implemented by ahci.c. If CONFIG_SCSI_AHCI_PLAT is defined it does one thing and if it is not it does something else. We don't need to call through scsi_low_level_init() to get the init completed. Instead, adjust the two drivers to call into AHCI directly. Drop the post-probe init in the SCSI uclass. This means that driver model doesn't need to use scsi_low_level_init(). It is a legacy function and driver model should use a driver's probe() method instead. While we are here, add a comment to the top of the file explaining what ahci.c does. Signed-off-by: Simon Glass Reviewed-by: Bin Meng

dm: ahci: Move common code for starting ports into a function

2017-07-11T16:08:19Z

This code is duplicated. Create a ahci_start_ports() function to handle this and call it from both places. Signed-off-by: Simon Glass Reviewed-by: Bin Meng

dm: ahci: Refactor to avoid static variables

2017-07-11T16:08:19Z

With driver model we need each device to have its own state. As a step towards this, restrict use of the global 'probe_ent' to just a few places in the file. This will allow us to add driver-model functions which can pass the correct data around. Signed-off-by: Simon Glass Reviewed-by: Bin Meng