u-boot.git/drivers/block/ide.c, branch v2023.07.01

ide: Make use of U-Boot types

2023-04-27T17:51:07Z

Use standard U-Boot types in the file to make the code less verbose. Signed-off-by: Simon Glass

ide: Simplify expressions and hex values

2023-04-27T17:51:07Z

The code has quite a few unnecessary brackets and comparisons to zero, etc. Fix these up as well as some upper-case hex values and use of 0x in printf() strings. Signed-off-by: Simon Glass

ide: Convert to use log_debug()

2023-04-27T17:51:07Z

Avoid the use of the function name in a few of the debug() calls, since this causes a checkpatch warning. Convert all other calls too. Use lower-case hex consistently. Signed-off-by: Simon Glass

ide: Tidy up ide_reset()

2023-04-27T17:51:07Z

Avoid using #ifdef and use a single function declaration, so it is easier to read. Signed-off-by: Simon Glass

ide: Correct LBA setting

2023-04-27T17:51:07Z

Fix a longstanding bug where the LBA is calculated as the size of the media instead of the number of blocks. This was perhaps not noticed earlier since it prints the correct value first, before setting the wrong value. Drop the unnecessary blksz variable while we are here. Signed-off-by: Simon Glass Fixes: 68e6f221ed0 ("block: ide: Fix block read/write with driver model")

ide: Use a single local blk_desc for ide_ident()

2023-04-27T17:51:07Z

We only use one member of the ide_dev_desc[] array at a time and it does not stick around outside ide_probe(). Use a single element instead. Copy over the missing members of blk_desc at the same, since this was missing from the previous code. Signed-off-by: Simon Glass Fixes: 68e6f221ed0 ("block: ide: Fix block read/write with driver model")

ide: Move all blk_desc init into ide_ident()

2023-04-27T17:51:07Z

Rather than having the caller fill some of this in, do it all in the ide_ident() function, since it knows all the values. Signed-off-by: Simon Glass

ide: Make ide_ident() return an error code

2023-04-27T17:51:07Z

Update ide_ident() to indicate whether it finds a device or not. Use that to decide whether to create a block device for it, rather than looking DEV_TYPE_UNKNOWN. Signed-off-by: Simon Glass

ide: Use desc consistently for struct blk_desc

2023-04-27T17:51:06Z

Most of the code uses 'desc' as the variable name for a blk descriptor. Change ide to do the same. Tidy up some extra brackets and types while we are here. Leave the code in ide_probe() alone since it is about to be refactored. Signed-off-by: Simon Glass

ide: Combine the two loops in ide_probe()

2023-04-27T17:51:06Z

The two loops in this function operate on the same ide_dev_desc[] array. Combine them to reduce duplication. Signed-off-by: Simon Glass