u-boot.git/drivers/core/device.c, branch v2020.07-rc2

dm: core: Read parent ofdata before children

2020-04-16T14:07:58+00:00

At present a device can read its ofdata before its parent has done the
same. This can cause problems in the case where the parent has a 'ranges'
property, thus affecting the operation of dev_read_addr(), for example.

We already probe parent devices before children so it does not seem to be
a large step to do the same with ofdata.

Make the change and update the documentation in this area.

Signed-off-by: Simon Glass 
Tested-by: Ley Foon Tan

dm: core: remove redundant if statement

2020-04-16T14:07:57+00:00

The value of parent is not changed in the first if statement. So we can
merge the two if statements depending on parent.

Indicated by cppcheck.

Signed-off-by: Heinrich Schuchardt 
Reviewed-by: Simon Glass

dm: core: Add a way to iterate through children, probing each

2020-02-06T02:33:45+00:00

It is sometimes useful to process all children, making sure they are
probed first. Add functions to help with this and a macro to make it more
convenient.

Signed-off-by: Simon Glass

dm: core: Add a way to read platdata for all child devices

2020-02-06T02:33:45+00:00

When generating ACPI tables we need to make sure that all devices have
read their platform data, so that they can generate the tables correctly.

Rather than adding this code in ACPI, create a core function to handle it.

Signed-off-by: Simon Glass

dm: core: Use const where possible in device.h

2020-02-06T02:33:45+00:00

Update this header file to use const devices where possible, to permit
callers to also use const.

Signed-off-by: Simon Glass

dm: core: Add a new flag to track platform data

2020-01-07T23:02:38+00:00

We want to avoid allocating platform data twice. This could happen if
device_probe() is called after device_ofdata_to_platdata() for the same
device.

Add a flag to track whether device_ofdata_to_platdata() has been called on
a device. Check the flag to make sure it doesn't happen twice, and clear
the flag when the data is freed.

Signed-off-by: Simon Glass

dm: core: Export a new function to read platdata

2020-01-07T23:02:38+00:00

Add a new internal function, device_ofdata_to_platdata() to handle
allocating private space associated with each device and reading the
platform data from the device tree.

Call this new function from device_probe().

Signed-off-by: Simon Glass

dm: core: Allocate parent data separate from probing parent

2020-01-07T23:02:38+00:00

At present the parent is probed before the child's ofdata_to_platdata()
method is called. Adjust the logic slightly so that probing parents is
not done until afterwards.

Signed-off-by: Simon Glass

dm: core: Move ofdata_to_platdata() call earlier

2020-01-07T23:02:38+00:00

This method is supposed to extract platform data from the device tree. It
should be done before the device itself is probed. Move it earlier in the
device_probe() function.

Signed-off-by: Simon Glass

dm: core: Don't clear active flag twice when probe() fails

2020-01-07T23:02:38+00:00

Remove this duplicated code, since the 'fail' label does this immediately.

Signed-off-by: Simon Glass