u-boot.git/drivers/core/lists.c, branch v2015.04

dm: core: remove unnecessary return condition in uclass lookup

2014-11-22T09:16:49+00:00

These conditions never happen.
 - There is no real uclass with UCLASS_INVALID id.
 - uclass never becomes NULL because ll_entry_start() always returns
   a valid pointer.

Signed-off-by: Masahiro Yamada 
Acked-by: Simon Glass

dm: core: remove unnecessary return condition in driver lookup

2014-11-22T09:16:49+00:00

The variable "drv" never becomes NULL because ll_entry_start()
always returns a valid pointer even if there are no entries.

The case "n_ents == 0" is covered by the following "for" loop.

Signed-off-by: Masahiro Yamada 
Acked-by: Simon Glass

dm: core: remove meaningless if conditional

2014-11-22T09:16:48+00:00

If the variable "ret" is equal to "-ENOENT", it is trapped at [1] and
never reaches [2].  At [3], the condition "ret != -ENOENT" is always
true.

  if (ret == -ENOENT) {                       <------------------ [1]
          continue;
  } else if (ret == -ENODEV) {
          dm_dbg("Device '%s' has no compatible string\n", name);
          break;
  } else if (ret) {                           <------------------ [2]
          dm_warn("Device tree error at offset %d\n", offset);
          if (!result || ret != -ENOENT)      <------------------ [3]
                  result = ret;
          break;
  }

Signed-off-by: Masahiro Yamada 
Acked-by: Simon Glass

dm: Add a function to bind a device by driver name

2014-11-22T09:16:47+00:00

In some cases we need to manually bind a device to a particular driver.
Add a function to do this.

Signed-off-by: Simon Glass 
Reviewed-by: Jagannadha Sutradharudu Teki 
Acked-by: Heiko Schocher

dm: core: Allow access to the device's driver_id data

2014-11-22T09:16:45+00:00

When the device is created from a device tree node, it matches a compatible
string. Allow access to that string and the associated data.

Signed-off-by: Simon Glass 
Reviewed-by: Tom Rini 
Acked-by: Heiko Schocher

dm: simplify the loop in lists_driver_lookup_name()

2014-10-22T16:32:16+00:00

if (strncmp(name, entry->name, len))
                continue;

        /* Full match */
        if (len == strlen(entry->name))
                return entry;

is equivalent to:

        if (!strcmp(name, entry->name))
                return entry;

The latter is simpler.

Signed-off-by: Masahiro Yamada 
Acked-by: Simon Glass 
Acked-by: Igor Grinberg

dm: Adjust lists_bind_fdt() to return the bound device

2014-09-10T18:59:59+00:00

Allow the caller to find out the device that was bound in response to this
call.

Signed-off-by: Simon Glass

dm: Improve errors and warnings in lists_bind_fdt()

2014-07-23T13:08:37+00:00

Add a debug message for when a device tree node has no driver. Also reword
the warning when a device fails to bind, which was misleading.

Signed-off-by: Simon Glass

dm: Allow drivers to be marked 'before relocation'

2014-07-23T13:07:24+00:00

Driver model currently only operates after relocation is complete. In this
state U-Boot typically has a small amount of memory available. In adding
support for driver model prior to relocation we must try to use as little
memory as possible.

In addition, on some machines the memory has not be inited and/or the CPU
is not running at full speed or the data cache is off. These can reduce
execution performance, so the less initialisation that is done before
relocation the better.

An immediately-obvious improvement is to only initialise drivers which are
actually going to be used before relocation. On many boards the only such
driver is a serial UART, so this provides a very large potential benefit.

Allow drivers to mark themselves as 'pre-reloc' which means that they will
be initialised prior to relocation. This can be done either with a driver
flag or with a 'dm,pre-reloc' device tree property.

To support this, the various dm scanning function now take a 'pre_reloc_only'
parameter which indicates that only drivers marked pre-reloc should be
bound.

Signed-off-by: Simon Glass

dm: add missing includes

2014-07-18T21:53:23+00:00

lists.c / root.c do not include their own header and they
could potentially implement a different function. Therefore
actually include the headers.

cc: sjg@chromium.org
Signed-off-by: Jeroen Hofstee 
Acked-by: Simon Glass