u-boot.git/drivers/fpga, branch v2023.01

fpga: virtex2: Use logging feature instead of FPGA_DEBUG

2022-10-10T10:28:08+00:00

Instead of using DEBUG or LOG_DEBUG the driver still had its own
definition for debug output.

Signed-off-by: Alexander Dahl 
Signed-off-by: Michal Simek 
Link: https://lore.kernel.org/r/20221007122003.11239-11-ada@thorsis.com

fpga: spartan3: Use logging feature instead of FPGA_DEBUG

2022-10-10T10:28:08+00:00

Instead of using DEBUG or LOG_DEBUG the driver still had its own
definition for debug output.

Signed-off-by: Alexander Dahl 
Signed-off-by: Michal Simek 
Link: https://lore.kernel.org/r/20221007122003.11239-10-ada@thorsis.com

fpga: spartan2: Use logging feature instead of FPGA_DEBUG

2022-10-10T10:28:08+00:00

Instead of using DEBUG or LOG_DEBUG the driver still had its own
definition for debug output.

Signed-off-by: Alexander Dahl 
Signed-off-by: Michal Simek 
Link: https://lore.kernel.org/r/20221007122003.11239-9-ada@thorsis.com

fpga: ACEX1K: Use logging feature instead of FPGA_DEBUG

2022-10-10T10:28:08+00:00

Instead of using DEBUG or LOG_DEBUG the driver still had its own
definition for debug output.

Signed-off-by: Alexander Dahl 
Signed-off-by: Michal Simek 
Link: https://lore.kernel.org/r/20221007122003.11239-8-ada@thorsis.com

fpga: cyclon2: Use logging feature instead of FPGA_DEBUG

2022-10-10T10:28:08+00:00

Instead of using DEBUG or LOG_DEBUG the driver still had its own
definition for debug output.

Signed-off-by: Alexander Dahl 
Signed-off-by: Michal Simek 
Link: https://lore.kernel.org/r/20221007122003.11239-7-ada@thorsis.com

fpga: altera: Use logging feature instead of FPGA_DEBUG

2022-10-10T10:28:08+00:00

Instead of using DEBUG or LOG_DEBUG the driver still had its own
definition for debug output.

Signed-off-by: Alexander Dahl 
Signed-off-by: Michal Simek 
Link: https://lore.kernel.org/r/20221007122003.11239-6-ada@thorsis.com

fpga: virtex2: Fix printf format string warnings

2022-10-10T10:28:08+00:00

Warning appears if built with FPGA_DEBUG defined:

  CC      drivers/fpga/virtex2.o
/mnt/data/adahl/src/u-boot/drivers/fpga/virtex2.c: In function ‘virtex2_ssm_load’:
/mnt/data/adahl/src/u-boot/drivers/fpga/virtex2.c:333:11: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ {aka ‘long unsigned int’} [-Wformat=]
    PRINTF("%s:%d:done went active early, bytecount = %d\n",
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           __func__, __LINE__, bytecount);
                               ~~~~~~~~~
/mnt/data/adahl/src/u-boot/drivers/fpga/virtex2.c:25:37: note: in definition of macro ‘PRINTF’
 #define PRINTF(fmt, args...) printf(fmt, ##args)
                                     ^~~
/mnt/data/adahl/src/u-boot/drivers/fpga/virtex2.c: In function ‘virtex2_ss_load’:
/mnt/data/adahl/src/u-boot/drivers/fpga/virtex2.c:468:12: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ {aka ‘long unsigned int’} [-Wformat=]
     PRINTF("%s:%d:done went active early, bytecount = %d\n",
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            __func__, __LINE__, bytecount);
                                ~~~~~~~~~
/mnt/data/adahl/src/u-boot/drivers/fpga/virtex2.c:25:37: note: in definition of macro ‘PRINTF’
 #define PRINTF(fmt, args...) printf(fmt, ##args)
                                     ^~~

Signed-off-by: Alexander Dahl 
Signed-off-by: Michal Simek 
Link: https://lore.kernel.org/r/20221007122003.11239-5-ada@thorsis.com

fpga: spartan3: Fix printf arguments warning

2022-10-10T10:28:08+00:00

The additional comma messes up the arguments.
Warning appears if built with FPGA_DEBUG defined:

      CC      drivers/fpga/spartan3.o
    /mnt/data/adahl/src/u-boot/drivers/fpga/spartan3.c: In function ‘spartan3_sp_load’:
    /mnt/data/adahl/src/u-boot/drivers/fpga/spartan3.c:118:11: warning: too many arguments for format [-Wformat-extra-args]
       PRINTF ("%s: Function Table:\n"
               ^~~~~~~~~~~~~~~~~~~~~~~
    /mnt/data/adahl/src/u-boot/drivers/fpga/spartan3.c:18:37: note: in definition of macro ‘PRINTF’
     #define PRINTF(fmt,args...) printf (fmt ,##args)
                                         ^~~

Fixes: 875c78934ee2 ("Add Xilinx Spartan3 family FPGA support Patch by Kurt Stremerch, 14 February 2005")
Signed-off-by: Alexander Dahl 
Signed-off-by: Michal Simek 
Link: https://lore.kernel.org/r/20221007122003.11239-4-ada@thorsis.com

fpga: spartan2: Fix printf arguments warning

2022-10-10T10:28:08+00:00

That extra comma messes up format arguments.
Warning appears if built with FPGA_DEBUG defined:

      CC      drivers/fpga/spartan2.o
    /mnt/data/adahl/src/u-boot/drivers/fpga/spartan2.c: In function ‘spartan2_sp_load’:
    /mnt/data/adahl/src/u-boot/drivers/fpga/spartan2.c:112:11: warning: too many arguments for format [-Wformat-extra-args]
       PRINTF ("%s: Function Table:\n"
               ^~~~~~~~~~~~~~~~~~~~~~~
    /mnt/data/adahl/src/u-boot/drivers/fpga/spartan2.c:12:37: note: in definition of macro ‘PRINTF’
     #define PRINTF(fmt,args...) printf (fmt ,##args)
                                         ^~~
      CC      drivers/fpga/spartan3.o
    /mnt/data/adahl/src/u-boot/drivers/fpga/spartan3.c: In function ‘spartan3_sp_load’:
    /mnt/data/adahl/src/u-boot/drivers/fpga/spartan3.c:117:11: warning: too many arguments for format [-Wformat-extra-args]
       PRINTF ("%s: Function Table:\n"
               ^~~~~~~~~~~~~~~~~~~~~~~
    /mnt/data/adahl/src/u-boot/drivers/fpga/spartan3.c:17:37: note: in definition of macro ‘PRINTF’
     #define PRINTF(fmt,args...) printf (fmt ,##args)
                                         ^~~

Fixes: e221174377d7 ("Initial revision")
Signed-off-by: Alexander Dahl 
Signed-off-by: Michal Simek 
Link: https://lore.kernel.org/r/20221007122003.11239-3-ada@thorsis.com

fpga: Add missing Kconfig symbols for old FPGA drivers

2022-10-10T10:28:08+00:00

Those drivers could not be built anymore without those options present.

Signed-off-by: Alexander Dahl 
Signed-off-by: Michal Simek 
Link: https://lore.kernel.org/r/20221007122003.11239-2-ada@thorsis.com