u-boot.git/drivers/i2c, branch v2020.07

i2c: observe scl_count in i2c_deblock_gpio_loop()

2020-05-28T03:52:46+00:00

When compiling with -Wtype-limits we see this error:

drivers/i2c/i2c-uclass.c: In function ‘i2c_deblock_gpio_loop’:
drivers/i2c/i2c-uclass.c:517:21: error: comparison of
unsigned expression >= 0 is always true [-Werror=type-limits]
  517 |  while (scl_count-- >= 0) {
      |

Don't loop forever.

Fixes: 1f746a2c82b1 ("i2c: Make deblock delay and SCL clock configurable")
Signed-off-by: Heinrich Schuchardt

i2c: designware_i2c: Check if the device is powered

2020-05-28T03:50:47+00:00

If the device doesn't return a version that means the device is
non-functional.

The dw_i2c_regs had invalid offsets for the version field. I got the
correct value from the DesignWare databook. It also matches what the
Picasso PPR says.

Signed-off-by: Raul E Rangel 
Reviewed-by: Simon Glass 
Reviewed-by: Furquan Shaikh 
Tested on chromebook_coral:
Signed-off-by: Simon Glass

i2c: designware_i2c: Tidy up use of NULL priv

2020-05-28T03:50:00+00:00

At present we still have pre-driver-model code in this driver and it makes
things a bit confusing. In particular calc_bus_speed() is called with priv
as NULL if not using driver model.

This results in spk_cnt and comp_param1 being read from an invalid address
if not using driver model. For comp_param1 this may not cause problems if
reading from addresses close to 0 happens to be allowed, as high speed is
only supported by DM code. But spk_cnt is subsequently used to calculate
the bus periods and so this may cause problems (e.g. on spear600 board
which has not been migrated yet).

Add a new parameter regs parameter to calc_bus_speed() and add more
comments to this function and to _dw_i2c_set_bus_speed(), which calls it.

Signed-off-by: Simon Glass 
Reported-by: Heinrich Schuchardt

common: Drop linux/bitops.h from common header

2020-05-19T01:19:23+00:00

Move this uncommon header out of the common header.

Signed-off-by: Simon Glass

common: Drop linux/delay.h from common header

2020-05-19T01:19:23+00:00

Move this uncommon header out of the common header.

Signed-off-by: Simon Glass

common: Drop log.h from common header

2020-05-19T01:19:18+00:00

Move this header out of the common header.

Signed-off-by: Simon Glass

common: Drop image.h from common header

2020-05-18T21:33:33+00:00

Move this uncommon header out of the common header.

Signed-off-by: Simon Glass

rename symbol: CONFIG_TEGRA -> CONFIG_ARCH_TEGRA

2020-05-15T18:47:35+00:00

Have this symbol follow the pattern of all other such symbols.

Signed-off-by: Trevor Woerner

rename symbol: CONFIG_KIRKWOOD -> CONFIG_ARCH_KIRKWOOD

2020-05-15T18:47:35+00:00

Have this symbol follow the pattern of all other such symbols.
This patch also removes a TODO from the code.

Reviewed-by: Chris Packham 
Signed-off-by: Trevor Woerner

rename symbol: CONFIG_ORION5X -> CONFIG_ARCH_ORION5X

2020-05-15T18:47:35+00:00

Have this symbol follow the pattern of all other such symbols.
This patch removes a TODO from the code.

Signed-off-by: Trevor Woerner