u-boot.git/drivers/mtd, branch v2018.03-rc1

cfi_flash: Always define cfi_flash_num_flash_banks

2018-01-29T06:48:59Z

The variable cfi_flash_num_flash_banks is defined iff CONFIG_SYS_MAX_FLASH_BANKS_DETECT is defined, but it is used unconditionally in the function cfi_flash_init_dm. This leads to a undefined variable compile error when CONFIG_SYS_MAX_FLASH_BANKS_DETECT is not defined, but DM is enabled. Fix this by always defining the cfi_flash_num_flash_banks variable. Signed-off-by: Mario Six Signed-off-by: Stefan Roese

cfi_flash: Fix indention

2018-01-29T06:48:59Z

When long expressions surrounded by parentheses are split into multiple lines, each consecutive line should be aligned with the corresponding parenthesis. Fix all instances where this occurs. Signed-off-by: Mario Six Signed-off-by: Stefan Roese

cfi_flash: Fix long lines

2018-01-29T06:48:59Z

Long lines (>80 characters) should be avoided where possible. Break up some long lines where it's not detrimental to readability. Signed-off-by: Mario Six Signed-off-by: Stefan Roese

cfi_flash: Bound-check index before array access

2018-01-29T06:48:59Z

In a while loop in cfi_flash.c the array "start" is accessed at the index "sector" before the index variable "sector" is bounds-checked, which might lead to accesses beyond the bounds of the array. Swap the order of the checks in the "&&" expression, so that the short-circuit evaluation prevents out-of-bounds array accesses. Signed-off-by: Mario Six Signed-off-by: Stefan Roese

flash: Fix spelling of "ERR_TIMOUT"

2018-01-29T06:48:59Z

checkpatch.pl complains about the spelling of ERR_TIMOUT. Since the error is only used in a handful of files, we rename the error to ERR_TIMEOUT. Signed-off-by: Mario Six Signed-off-by: Stefan Roese

cfi_flash: Rename camel-case variables

2018-01-29T06:48:58Z

Camel-case naming should be avoided. Rename two camel-case variables, and fix their usage accordingly. Signed-off-by: Mario Six Signed-off-by: Stefan Roese

cfi_flash: Fix strings split across lines

2018-01-29T06:48:58Z

Strings should not be split accross multiple lines. Where possible and not detrimental to readability, fix the instances where this occurs. Signed-off-by: Mario Six Signed-off-by: Stefan Roese

cfi_flash: Use u8 pointers instead of void pointers

2018-01-29T06:48:58Z

According to the C standard, pointer arithmetic for pointers of type void is undefined behavior (the assumption that they're 8-bit wide is a GCC-specific assumption). In the interest of keeping the code standards-compliant, and also better communicate intent, switch all void* variables where pointer arithmetic is used to u8* variables. Signed-off-by: Mario Six Signed-off-by: Stefan Roese

cfi_flash: Remove assignments from if conditions

2018-01-29T06:48:58Z

The condition in if statements should not be used for variable assignment. Instead, the assignment should be done in a separate step beforehand. Fix all instances where this occurs. Signed-off-by: Mario Six Signed-off-by: Stefan Roese

cfi_flash: Remove return from void function

2018-01-29T06:48:58Z

void functions don't need an explicit return at the end. Signed-off-by: Mario Six Signed-off-by: Stefan Roese